From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753527AbbJGNGD (ORCPT ); Wed, 7 Oct 2015 09:06:03 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:48444 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751656AbbJGNGA (ORCPT ); Wed, 7 Oct 2015 09:06:00 -0400 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="308640409" From: Julien Grall To: CC: , , Julien Grall , Konrad Rzeszutek Wilk , Boris Ostrovsky , David Vrabel Subject: [PATCH] xen/balloon: Use the correct sizeof when declaring frame_list Date: Wed, 7 Oct 2015 14:04:33 +0100 Message-ID: <1444223073-2572-1-git-send-email-julien.grall@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Content-Type: text/plain X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The type of the item in frame_list is xen_pfn_t which is not an unsigned long on ARM but an uint64_t. With the current computation, the size of frame_list will be 2 * PAGE_SIZE rather than PAGE_SIZE. I bet it's just mistake when the type has been switched from "unsigned long" to "xen_pfn_t" in commit 965c0aaafe3e75d4e65cd4ec862915869bde3abd "xen: balloon: use correct type for frame_list". Signed-off-by: Julien Grall ---- Cc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky Cc: David Vrabel --- drivers/xen/balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c index b50d229..12eab50 100644 --- a/drivers/xen/balloon.c +++ b/drivers/xen/balloon.c @@ -141,7 +141,7 @@ struct balloon_stats balloon_stats; EXPORT_SYMBOL_GPL(balloon_stats); /* We increase/decrease in batches which fit in a page */ -static xen_pfn_t frame_list[PAGE_SIZE / sizeof(unsigned long)]; +static xen_pfn_t frame_list[PAGE_SIZE / sizeof(xen_pfn_t)]; /* List of ballooned pages, threaded through the mem_map array. */ -- 2.1.4