From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com
Cc: "Denis V. Lunev" <den@openvz.org>,
Andrey Smetanin <asmetanin@virtuozzo.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed
Date: Wed, 7 Oct 2015 19:01:46 -0700 [thread overview]
Message-ID: <1444269709-25270-7-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1444269709-25270-1-git-send-email-kys@microsoft.com>
From: Denis V. Lunev <den@openvz.org>
Before vmbus_connect() synic is setup per vcpu - this means
hypervisor receives writes at synic msr's and probably allocate
hypervisor resources per synic setup.
If vmbus_connect() failed for some reason it's neccessary to cleanup
synic setup by call hv_synic_cleanup() at each vcpu to get a chance
to free allocated resources by hypervisor per synic.
This patch does appropriate cleanup in case of vmbus_connect() failure.
Signed-off-by: Andrey Smetanin <asmetanin@virtuozzo.com>
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
CC: "K. Y. Srinivasan" <kys@microsoft.com>
CC: Haiyang Zhang <haiyangz@microsoft.com>
CC: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/hv/vmbus_drv.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index f19b6f7..3297731 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -867,7 +867,7 @@ static int vmbus_bus_init(int irq)
on_each_cpu(hv_synic_init, NULL, 1);
ret = vmbus_connect();
if (ret)
- goto err_alloc;
+ goto err_connect;
if (vmbus_proto_version > VERSION_WIN7)
cpu_hotplug_disable();
@@ -885,6 +885,8 @@ static int vmbus_bus_init(int irq)
return 0;
+err_connect:
+ on_each_cpu(hv_synic_cleanup, NULL, 1);
err_alloc:
hv_synic_free();
hv_remove_vmbus_irq();
--
1.7.4.1
next prev parent reply other threads:[~2015-10-08 0:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 1:59 [PATCH 00/10] Drivers: hv: Miscellaneous fixes K. Y. Srinivasan
2015-10-08 2:01 ` [PATCH 01/10] Drivers: hv: util: Increase the timeout for util services K. Y. Srinivasan
2015-10-08 2:01 ` [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context K. Y. Srinivasan
2015-10-08 13:24 ` Vitaly Kuznetsov
2015-10-08 13:30 ` Olaf Hering
2015-10-08 13:52 ` Vitaly Kuznetsov
2015-10-08 14:55 ` KY Srinivasan
2015-10-09 7:07 ` Olaf Hering
2015-10-09 10:13 ` Vitaly Kuznetsov
2015-10-09 11:28 ` Olaf Hering
2015-10-12 6:05 ` KY Srinivasan
2015-10-13 9:46 ` Olaf Hering
2015-10-13 21:33 ` KY Srinivasan
2015-10-08 2:01 ` [PATCH 03/10] tools: hv: report ENOSPC errors in hv_fcopy_daemon K. Y. Srinivasan
2015-10-08 2:01 ` [PATCH 04/10] tools: hv: remove repeated HV_FCOPY string K. Y. Srinivasan
2015-10-08 2:01 ` [PATCH 05/10] Drivers: hv: util: catch allocation errors K. Y. Srinivasan
2015-10-08 2:01 ` [PATCH 06/10] Drivers: hv: utils: use memdup_user in hvt_op_write K. Y. Srinivasan
2015-10-08 2:01 ` K. Y. Srinivasan [this message]
2015-10-08 17:19 ` [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed Denis V. Lunev
2015-10-08 17:28 ` KY Srinivasan
2015-10-08 17:31 ` Denis V. Lunev
2015-10-08 2:01 ` [PATCH 08/10] drivers:hv: Export a function that maps Linux CPU num onto Hyper-V proc num K. Y. Srinivasan
2015-10-08 2:01 ` [PATCH 09/10] drivers:hv: Export the API to invoke a hypercall on Hyper-V K. Y. Srinivasan
2015-10-08 2:01 ` [PATCH 10/10] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through K. Y. Srinivasan
2015-10-08 10:24 ` Vitaly Kuznetsov
2015-10-08 13:23 ` [PATCH 01/10] Drivers: hv: util: Increase the timeout for util services Olaf Hering
2015-10-08 14:40 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444269709-25270-7-git-send-email-kys@microsoft.com \
--to=kys@microsoft.com \
--cc=apw@canonical.com \
--cc=asmetanin@virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome