mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Morozov <alexandr.morozov@docker.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Alexander Morozov <lk4d4@docker.com>
Subject: [PATCH 0/2] Fix hardlinks in overlay
Date: Fri,  9 Oct 2015 12:34:55 -0700	[thread overview]
Message-ID: <1444419297-16232-1-git-send-email-lk4d4@docker.com> (raw)

There were reports that overlay doesn't work very well with unix-sockets.
In particular you can't access unix-socket through hardlink on overlay fs.
Problem is that overlay creates different inodes for hardlinks and code in
net/unix/af_unix.c relies on inodes for unix-socket lookup. I think this
affects any code which relies on inodes from kern_path. There is helper
d_backing_inode, which I think supposed to get inodes from underlying fs
(for example ext4), but in current implementation it does nothing.  These
patches made on top of v4.3-rc4 of main linux tree (master is broken for my
ubuntu VM), but I tested that they applying on master and there was no
changes to overlay since v4.3-rc4.

Alexander Morozov (2):
  fs/overlay: move update and instantiate dentry code to function
  fs/overlay: use same inodes for hardlinks

 fs/overlayfs/dir.c | 41 +++++++++++++++++++++++++++++------------
 1 file changed, 29 insertions(+), 12 deletions(-)

-- 
2.6.1


             reply	other threads:[~2015-10-09 19:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 19:34 Alexander Morozov [this message]
2015-10-09 19:34 ` [PATCH 1/2] fs/overlay: move update and instantiate dentry code to function Alexander Morozov
2015-10-09 19:34 ` [PATCH 2/2] fs/overlay: use same inodes for hardlinks Alexander Morozov
2015-11-23 23:23   ` Alexander Morozov
2016-03-07 10:49 ` [PATCH 0/2] Fix hardlinks in overlay Miklos Szeredi
2016-03-07 17:33   ` Alexander Morozov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444419297-16232-1-git-send-email-lk4d4@docker.com \
    --to=alexandr.morozov@docker.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lk4d4@docker.com \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®