From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751282AbbJJCoB (ORCPT ); Fri, 9 Oct 2015 22:44:01 -0400 Received: from mga09.intel.com ([134.134.136.24]:54486 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbbJJCn6 (ORCPT ); Fri, 9 Oct 2015 22:43:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,661,1437462000"; d="scan'208";a="788986559" From: Figo To: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, hpa@zytor.com Cc: linux-kernel@vger.kernel.org, Figo Subject: [PATCH 1/1] I have a board it block on i8259A_shutdown when I want to poweroff. It is not always re-produce. Date: Sat, 10 Oct 2015 18:36:44 +0800 Message-Id: <1444473404-24058-1-git-send-email-tianfei.zhang@intel.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is the log: [ 27.758391] xhci_hcd 0000:00:14.0: shutdown start [ 27.768329] xhci_hcd 0000:00:14.0: shutdown stop [ 27.773532] pci 0000:00:0b.0: shutdown start [ 27.778335] pci 0000:00:0b.0: shutdown stop [ 27.783041] pci 0000:00:0a.0: shutdown start [ 27.787847] pci 0000:00:0a.0: shutdown stop [ 27.792550] pci 0000:00:03.0: shutdown start [ 27.797362] pci 0000:00:03.0: shutdown stop [ 27.802087] i915 0000:00:02.0: shutdown start [ 27.816006] i915 0000:00:02.0: shutdown stop [ 27.832384] PM: Calling mce_syscore_shutdown+0x0/0x50 start [ 27.838651] PM: Calling mce_syscore_shutdown+0x0/0x50 stop [ 27.844813] PM: Calling i8259A_shutdown+0x0/0x20 start It seems has a potential race on i8259A_shutdown(). Signed-off-by: Figo --- arch/x86/kernel/i8259.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c index 16cb827..06906d4 100644 --- a/arch/x86/kernel/i8259.c +++ b/arch/x86/kernel/i8259.c @@ -257,12 +257,16 @@ static int i8259A_suspend(void) static void i8259A_shutdown(void) { + unsigned long flags; + + raw_spin_lock_irqsave(&i8259A_lock, flags); /* Put the i8259A into a quiescent state that * the kernel initialization code can get it * out of. */ outb(0xff, PIC_MASTER_IMR); /* mask all of 8259A-1 */ outb(0xff, PIC_SLAVE_IMR); /* mask all of 8259A-2 */ + raw_spin_unlock_irqrestore(&i8259A_lock, flags); } static struct syscore_ops i8259_syscore_ops = { -- 1.7.9.5