From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D38CA3FF1; Fri, 1 Nov 2024 09:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730453035; cv=none; b=aEGci3Je1GiKSWmAf/DJIE7RLStQe5vbhLobwwJ+rbzGlmVkg5JuaYx6Fk7UnSEm1JzEGO4X5r8tvrZjUs6Q7HJiQHoQGix979N2XZSb24xfSPnE3Pw0pDJ4ToRmDCBl0XH7coS5g43X3AwAqkgmxpzBs5UsuUafz9WTw9JGsaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730453035; c=relaxed/simple; bh=ELj8XYF+YCmi8TI/wRUv1Afq/83eTPVQ4o6A6cJZWSs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HoxId/ZrTGYgV5Sv8AFUzlIXFqND9uvBxRUH1Q/OVkp6/bWm7ee/vvp5cNMqTXNHUQWIxIWEIYjr86NmGhskif7EhjqYmNoAowswT/hCkYN1uUo3O6nA5Q1ylMILJ0mJG5HtXpCv3wKJNTEjdeWPzQGltzCglptKTGvrnKT7QpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JUiVQhmY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JUiVQhmY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6FCEC4CECD; Fri, 1 Nov 2024 09:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730453034; bh=ELj8XYF+YCmi8TI/wRUv1Afq/83eTPVQ4o6A6cJZWSs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JUiVQhmYO06Y/sVA1xmqj6PQ7KQ+5ExXYImx2ry8HI1U4Ooyeh7slrHuZP+3S2gwP xl+AURmqYHebsm4pR3b0gmnO9GsHLOgzKpOL3/pNAEWVZux/FSuc1bG2slHmZzRdm0 6n4cjp+8ixu0Yl/lu6Glr/r9l0UQjsLEkGkZYDq4SVuqaS73YndEcm1HGWFIUfrd0P 3aOa3fVnvNb9iHTN0Sd7pRH3GTrs29b9ve7JJdrKlP+PElbB1gVO8v5fSotSDurrmc 0xCJNnGEOFVLFHFXwuOyrPdCmMM7W3d8IEnsT8ZjiN0ht6g/OB3YhgedyNPsEQdI+e DcPIXdX6gocWg== Message-ID: <144458a6-6c63-4386-99da-3a27743288b4@kernel.org> Date: Fri, 1 Nov 2024 10:23:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindings: arm: qcom-soc: simplify SoC-matching patterns To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241101-sar2130p-dt-v3-0-61597eaf0c37@linaro.org> <20241101-sar2130p-dt-v3-1-61597eaf0c37@linaro.org> <80a37af3-ffef-4342-b7d3-f2eb36bb60ba@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 01/11/2024 09:52, Dmitry Baryshkov wrote: > On Fri, Nov 01, 2024 at 09:37:23AM +0100, Krzysztof Kozlowski wrote: >> On 01/11/2024 08:47, Dmitry Baryshkov wrote: >>> On Fri, Nov 01, 2024 at 08:26:04AM +0100, Krzysztof Kozlowski wrote: >>>> On Fri, Nov 01, 2024 at 02:49:22AM +0200, Dmitry Baryshkov wrote: >>>>> The patterns for individual SoC families grew up to be pretty complex, >>>>> containing lots of special cases and optional suffixes. Split them per >>>>> the suffix to make it easier to extend SoC patterns. >>>> >>>> This is doing something quite different - split is not important here. >>>> Instead you narrow the patterns significantly and disallow things like >>>> msm8994pro, sc8280p or sc8280px, and allow things like sa5200p. >>> >>> Just for the sake of correctness, msm8994pro is still allowed, if I'm >>> not mistaken. >>> >>>> I don't see here much of pattern simplifying - dropping (pro)? really >>>> makes little difference. >>> >>> Patterns are simplified by being explicit. E.g. in the previous >>> iteration I completely didn't notice the intersection of the |p that I >>> have added with the existing [a-z][a-z]? pattern. If you think that >>> sa5200p should be disallowed, I can tune the numeric part of the >>> pattern. And sc8280p / sc8280px should not be allowed in the first >>> place, such platforms don't exist. >> >> I am fine with this, but extend the commit msg with some good rationale. >> Have in mind that the point of this pattern was *not* to validate SoCs >> names. sa5200p is fine, sc8180p is fine and all others are fine, sc8280z >> as well, because we do not want to grow this pattern with every new model. >> >> The only, single point of this entire binding is to disallow incorrect >> order of block names in compatible. Not validate the SoC names. If you >> need narrower patterns to achieve that objective, sure. If you need >> narrower patterns to validate SoC names, then nope. > > I need narrower patterns to simplify adding new SoCs. > Another option is to define a mega-pattern like > qcom,(msm|sm|sd[am]|.....)[0-9]+[a-z]*-.* . Frankly speaking I'm fine > with that approach too. I do not see how narrower patterns, changing: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$" into pattern: "^qcom,sa[0-9]+p-.*$" instead of pattern: "^qcom,sa[0-9]+[a-z]-.*$" is needed for that. It's true that 'p' is simpler than '[a-z]' but if this results in new commit next time we have sa8995r, then benefit is lost. Best regards, Krzysztof