From: huangdaode <huangdaode@hisilicon.com>
To: <davem@davemloft.net>, <arnd@arndb.de>, <joe@perches.com>
Cc: <liguozhu@hisilicon.com>, <Yisen.Zhuang@huawei.com>,
<netdev@vger.kernel.org>, <linuxarm@huawei.com>,
<salil.mehta@huawei.com>, <huangdaode@hisilicon.com>,
<kenneth-lee-2012@foxmail.com>, <xuwei5@hisilicon.com>,
<lisheng011@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH net-next v2 2/2] hisilicon net: fix a bug on Hisilicon Network Subsystem
Date: Mon, 12 Oct 2015 11:23:45 +0800 [thread overview]
Message-ID: <1444620225-2339-3-git-send-email-huangdaode@hisilicon.com> (raw)
In-Reply-To: <1444620225-2339-1-git-send-email-huangdaode@hisilicon.com>
This patch fixes the wrong judgement of mac_id when get port num.
Signed-off-by: huangdaode <huangdaode@hisilicon.com>
Signed-off-by: yankejian <yankejian@huawei.com>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
index 95bf42a..e162e4a 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
@@ -179,7 +179,7 @@ static int hns_mac_get_inner_port_num(struct hns_mac_cb *mac_cb,
return -EINVAL;
}
} else if (mac_cb->dsaf_dev->dsaf_mode < DSAF_MODE_MAX) {
- if (mac_cb->mac_id <= DSAF_MAX_PORT_NUM_PER_CHIP) {
+ if (mac_cb->mac_id >= DSAF_MAX_PORT_NUM_PER_CHIP) {
dev_err(mac_cb->dev,
"input invalid,%s mac%d vmid%d!\n",
mac_cb->dsaf_dev->ae_dev.name,
--
1.9.1
prev parent reply other threads:[~2015-10-12 3:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 3:23 [PATCH net-next v2 0/2] hisilicon net: fix some bugs in HNS drivers huangdaode
2015-10-12 3:23 ` [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro huangdaode
2015-10-12 3:24 ` Joe Perches
2015-10-12 3:38 ` huangdaode
2015-10-12 11:53 ` Arnd Bergmann
2015-10-12 11:59 ` Arnd Bergmann
2015-10-12 16:12 ` Joe Perches
[not found] ` <561CAD6D.2060105@hisilicon.com>
2015-10-13 13:27 ` Fwd: " Kenneth Lee
2015-10-13 14:18 ` Arnd Bergmann
2015-10-15 15:32 ` Kenneth Lee
2015-10-12 3:23 ` huangdaode [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444620225-2339-3-git-send-email-huangdaode@hisilicon.com \
--to=huangdaode@hisilicon.com \
--cc=Yisen.Zhuang@huawei.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kenneth-lee-2012@foxmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®