From: Kaixu Xia <xiakaixu@huawei.com>
To: <ast@plumgrid.com>, <davem@davemloft.net>, <acme@kernel.org>,
<mingo@redhat.com>, <a.p.zijlstra@chello.nl>,
<masami.hiramatsu.pt@hitachi.com>, <jolsa@kernel.org>,
<daniel@iogearbox.net>
Cc: <xiakaixu@huawei.com>, <wangnan0@huawei.com>,
<linux-kernel@vger.kernel.org>, <pi3orama@163.com>,
<hekuang@huawei.com>, <netdev@vger.kernel.org>
Subject: [RFC PATCH 1/2] perf: Add the flag sample_disable not to output data on samples
Date: Mon, 12 Oct 2015 09:02:42 +0000 [thread overview]
Message-ID: <1444640563-159175-2-git-send-email-xiakaixu@huawei.com> (raw)
In-Reply-To: <1444640563-159175-1-git-send-email-xiakaixu@huawei.com>
In some scenarios we don't want to output trace data when sampling
to reduce overhead. This patch adds the flag sample_disable to
implement this function. By setting this flag and integrating with
ebpf, we can control the data output process and get the samples we
are most interested in.
Signed-off-by: Kaixu Xia <xiakaixu@huawei.com>
---
include/linux/bpf.h | 1 +
include/linux/perf_event.h | 2 ++
kernel/bpf/arraymap.c | 5 +++++
kernel/events/core.c | 3 +++
4 files changed, 11 insertions(+)
diff --git a/include/linux/bpf.h b/include/linux/bpf.h
index f57d7fe..25e073d 100644
--- a/include/linux/bpf.h
+++ b/include/linux/bpf.h
@@ -39,6 +39,7 @@ struct bpf_map {
u32 max_entries;
const struct bpf_map_ops *ops;
struct work_struct work;
+ atomic_t perf_sample_disable;
};
struct bpf_map_type_list {
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 092a0e8..0606d1d 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -483,6 +483,8 @@ struct perf_event {
perf_overflow_handler_t overflow_handler;
void *overflow_handler_context;
+ atomic_t *sample_disable;
+
#ifdef CONFIG_EVENT_TRACING
struct trace_event_call *tp_event;
struct event_filter *filter;
diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c
index 29ace10..4ae82c9 100644
--- a/kernel/bpf/arraymap.c
+++ b/kernel/bpf/arraymap.c
@@ -51,6 +51,9 @@ static struct bpf_map *array_map_alloc(union bpf_attr *attr)
array->elem_size = elem_size;
+ if (attr->map_type == BPF_MAP_TYPE_PERF_EVENT_ARRAY)
+ atomic_set(&array->map.perf_sample_disable, 1);
+
return &array->map;
}
@@ -298,6 +301,8 @@ static void *perf_event_fd_array_get_ptr(struct bpf_map *map, int fd)
perf_event_release_kernel(event);
return ERR_PTR(-EINVAL);
}
+
+ event->sample_disable = &map->perf_sample_disable;
return event;
}
diff --git a/kernel/events/core.c b/kernel/events/core.c
index b11756f..f6ef45c 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6337,6 +6337,9 @@ static int __perf_event_overflow(struct perf_event *event,
irq_work_queue(&event->pending);
}
+ if ((event->sample_disable) && atomic_read(event->sample_disable))
+ return ret;
+
if (event->overflow_handler)
event->overflow_handler(event, data, regs);
else
--
1.8.3.4
next prev parent reply other threads:[~2015-10-12 9:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 9:02 [RFC PATCH 0/2] bpf: enable/disable events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Kaixu Xia
2015-10-12 9:02 ` Kaixu Xia [this message]
2015-10-12 12:02 ` [RFC PATCH 1/2] perf: Add the flag sample_disable not to output data on samples Peter Zijlstra
2015-10-12 12:05 ` Wangnan (F)
2015-10-12 12:12 ` Peter Zijlstra
2015-10-12 14:14 ` kbuild test robot
2015-10-12 19:20 ` Alexei Starovoitov
2015-10-13 2:30 ` xiakaixu
2015-10-13 3:10 ` Alexei Starovoitov
2015-10-13 12:00 ` Sergei Shtylyov
2015-10-12 9:02 ` [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers Kaixu Xia
2015-10-12 19:29 ` Alexei Starovoitov
2015-10-13 3:27 ` Wangnan (F)
2015-10-13 3:39 ` Alexei Starovoitov
2015-10-13 3:51 ` Wangnan (F)
2015-10-13 4:16 ` Alexei Starovoitov
2015-10-13 4:34 ` Wangnan (F)
2015-10-13 5:15 ` Alexei Starovoitov
2015-10-13 6:57 ` Wangnan (F)
2015-10-13 10:54 ` He Kuang
2015-10-13 11:07 ` Wangnan (F)
2015-10-14 5:14 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444640563-159175-2-git-send-email-xiakaixu@huawei.com \
--to=xiakaixu@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®