From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751796AbbJLJf5 (ORCPT ); Mon, 12 Oct 2015 05:35:57 -0400 Received: from ozlabs.org ([103.22.144.67]:57171 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbbJLJf4 (ORCPT ); Mon, 12 Oct 2015 05:35:56 -0400 Message-ID: <1444642554.31951.0.camel@ellerman.id.au> Subject: Re: [PATCH] powerpc/mm: use memblock_is_memory From: Michael Ellerman To: Alexander Kuleshov Cc: Benjamin Herrenschmidt , Paul Mackerras , Anton Blanchard , Scott Wood , Dan Williams , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Mon, 12 Oct 2015 20:35:54 +1100 In-Reply-To: <1444415430-25827-1-git-send-email-kuleshovmail@gmail.com> References: <1444415430-25827-1-git-send-email-kuleshovmail@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-10-10 at 00:30 +0600, Alexander Kuleshov wrote: > The provides memblock_is_memory() function that > tries to find a given physical address in the memblock.memory.regions. > Let's use this function instead of direct coding of the same functionality. Are you sure it implements exactly the same logic? > diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c > index 22d94c3..85b462b 100644 > --- a/arch/powerpc/mm/mem.c > +++ b/arch/powerpc/mm/mem.c > @@ -82,11 +82,9 @@ int page_is_ram(unsigned long pfn) > return pfn < max_pfn; > #else > unsigned long paddr = (pfn << PAGE_SHIFT); > - struct memblock_region *reg; > > - for_each_memblock(memory, reg) > - if (paddr >= reg->base && paddr < (reg->base + reg->size)) > - return 1; > + if (memblock_is_memory(paddr)) > + return 1; > return 0; Why not just return memblock_is_memory(paddr) ? cheers