From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752075AbbJLMFq (ORCPT ); Mon, 12 Oct 2015 08:05:46 -0400 Received: from mail-bn1on0092.outbound.protection.outlook.com ([157.56.110.92]:23418 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751599AbbJLMFn (ORCPT ); Mon, 12 Oct 2015 08:05:43 -0400 Authentication-Results: spf=pass (sender IP is 137.71.25.55) smtp.mailfrom=analog.com; codeaurora.org; dkim=none (message not signed) header.d=none;codeaurora.org; dmarc=bestguesspass action=none header.from=analog.com; From: Paul Cercueil To: Jonathan Cameron CC: Michael Hennerich , Lars-Peter Clausen , Hartmut Knaack , Peter Meerwald , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , , , , Paul Cercueil Subject: [PATCHv2 3/3] iio: ad5064: Always use external vref if there is no internal vref Date: Mon, 12 Oct 2015 13:50:34 +0200 Message-ID: <1444650634-12025-3-git-send-email-paul.cercueil@analog.com> X-Mailer: git-send-email 2.6.1 In-Reply-To: <1444650634-12025-1-git-send-email-paul.cercueil@analog.com> References: <1444650634-12025-1-git-send-email-paul.cercueil@analog.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD007;1:Uizk7H0hS5Zv4S5Dr7hD+rEeB34Ymyr2YJ1j13uwQoM6G0xAByCebwNv4t7zXudlmbCmyWN0Aj66olwzGov9b8U59WOpgUYJ+Xz2E51KRB46v06Pf0GsBRQIyCcFbHnFKn93KI/l/R4w1BqoonWiMWLFFQ8vYsLT+KkKPMLKP5H/CyoJtxCIc++btCskNB0+bL0XFGbh9c6cHSvJOyAQyRQtbZD2MTgKaNnsOAm8MiRXb4zRC3SFJqle8KwIsWXyn1r81NIk60rLLln6LPPCOk5OoWBHkktjZVzPtrYwgbmMUyGfrt1tWp9cnhxp4nJR7GZiUzbhIVLRSn+ZLu/3sNncKA+Zci2B2wkow8ahAuYi60zT+Az6JCNcbUrUgSGMxzl+awUZVv2gNxghCCNFtypyANCP62wFlse6Sg46hl4= X-Forefront-Antispam-Report: CIP:137.71.25.55;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(189002)(5001970100001)(107886002)(2950100001)(50466002)(189998001)(5003600100002)(110136002)(106466001)(11100500001)(19580405001)(19580395003)(5007970100001)(5003940100001)(64706001)(92566002)(47776003)(36756003)(76176999)(229853001)(50986999)(50226001)(86362001)(5001920100001)(87936001)(46102003)(33646002)(5008740100001)(48376002)(77096005)(6806005)(7059030)(4001430100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR03MB365;H:nwd2mta1.analog.com;FPR:;SPF:Pass;PTR:nwd2mail10.analog.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB365;2:5zn8s+AYTY/ehNn6/u0O74gyU2a3q3+mj7cAeIufz7RrM5DOqqUKXnVeH0/MJyyL8eJo1NzJwaUhbWJ6NrxPphkxxA44/1RkaYx+nPMLrHXTR4CVJ09KUloo+TOKjn/PeRF40jMG6z7PdsIsZW+KzebOIIfueIzjKt1Ipts0Lj8=;3:K8rtFnx/wd7PD9H01CtFMhQAZ85nD9u+WoUN65H+xLw0YXOzhYCXQ9IE57utpFjqI8HF6rBtjkWteRZLW5pCwviWB7vOfQjWLah7E1BbcT0Bii/X+X1bF/epwmSz413zZ3Eefe3MqRUR/6AI+zMKXeV15WpeQZwNifSfgkK/lo3wzZ3u3yICyXIkIiN+kRa47F2x8LszHfbNOw1z+p8hAIpu35tnCUyPOR98T5g1TTwnxkC6vpxvd4q5FvP/7g0l;25:R/02U4RCm0HiEgVT042Iqe76Q9xn2ctkDWphLhps4mjMB21aSjtNjz8taWNIxLLdWs0lpDRbNnC34dGsWYC3AZMiZEV6DV/U7jTAM8krz8tkdJ6hdq+R0dVhdRgohziUZ2SqN/8AzP9qMT9kOwqe0o+rCeoPEOio6lcElxZku//A8HEu3boDuHh9wMuaq/p74inBJbgyAodUJ3EgmrFusKSTSOM4Tax+uY9Su7Gm0Uukk58W0e0W/FM+4Ee1Da0CPRrwVr8V5qwNRQz2003B2w== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:DM2PR03MB365; X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB365;20:3OANwaz6LwoQqD7M/pT1x16lPSGThFLvfYxp54EDI4OggboOYCAM6BvwFMF1g9/HhfUPSuoL5kt5J7n5LixOF8L9UP6SariDKRbYUbDreO1VfZbbNDF+D3TtwKXcv7dQrXX79PKeZLmSoZODIt81nkQNsAg5f0R/cRgtghTAmU79bB6WnSyn4MTRHEVp/WoRi66E3kHgWnzqriLC0WhpW74SXcNNgfGQEmqjl/V1tY1Z+wGnfO8OiQ+iurN4KXko4MW4EBl3EplOzieOEzJhOt/CCSz9Ri9sL4GnQCSwSfRAWA0ml1VBcznaXWIUAv8pjOHmj5QFdrilbB0My9kahVUB4Y3zo92joaSvxhv2iOPyCl7QMZ2qOyy8+0RcE7FOqeIhe4Jb6Nt13Da32pXubsnSENVDXruXKfZkxURHAGxqSK3IilCCUAJjd5mfcPXno6IytLMwr2ic66445HiiF8+645LQ8Pq5ohjAq7PErqvcZNaNx/oY24EfzIE099Rw;4:s0Cp+IrxWUTiOK3e+lLV6WhJbW5eMO19Q5UbJnkY1269fg0H8DGT2xdfodD0H5yXb1noPvYaprxD4tct0jke/RV0IjCJ0ZG9QAa04Nr75d16n3QF23JTlWvD5amcxypx4gtUkx8eOb0v0UoLLPqq7BXmib4oyXooEgzGEt/Yz63MYUotGzFidNWdS89QcuxWcF1whQ6DEKkJaYGz0gXNmRdZCBGKQhCBlFfh+rO+Qalp9R+yTBI48L8ahMY6Yowud3328spFlQI+Yv+k5OxnOPFzQb3ckTVp+IIIulhFE+vk+lMgKAoyP+wbxJwBGwQR3HlS933frw3KNuMmuiXLGThYHG9eAt7ifp4xhr1o+Zs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9192018764339); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001);SRVR:DM2PR03MB365;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB365; X-Forefront-PRVS: 0727122FC6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM2PR03MB365;23:ZaG0spS165OubIBFUkSdJhzuRNeRnVzDUe/kfEroD/?= =?us-ascii?Q?6+9Tvd1BJDRV84B+arkMSQX1Z8hjnWVoEDx39NSQRestv7CTi60lBTEP4kzQ?= =?us-ascii?Q?p+lPjD9UlLkyb5DWZbYNJcRKXyGT0q3xKA0v/LIpEuq1xlM6JpX24dW7DluV?= =?us-ascii?Q?mZRDGrfB9qwk7sC7z3NkPbVh3L+3AzDGpYW2wh0emovojP7Qdr8uQxjGDD/L?= =?us-ascii?Q?xWzFSoLcknQxlgRE58Cq4Gv34k6tYiQfQFlW2mD6QE7eIukK4B/2EHYwxR1U?= =?us-ascii?Q?PwCD/4p0jzC6LSUvcDsYUBMN0SzyaphVimn1lHvhy7Rv3VNnDjHjfg+6ceV4?= =?us-ascii?Q?Fy4eCERKtz02z3MD4bP8jIxQQdg6gFSJylqNfbXNCPD/RFyTIe6fC9ssOTAq?= =?us-ascii?Q?yBcfSDIbK/sqMum3bZEVZcSs0eW5PKewLuxfzR64sZd5oZjfqh2nQNIGu2uE?= =?us-ascii?Q?Zp0Zc8D9HMjZWr2CKVhX4VwziwmuO20DDasztiFneRapTOE88m1FYGVbamSa?= =?us-ascii?Q?5wa6nohvPvvgEGe7iCFqvOYqRRylfYhxRf9Tk5NiODYTEXDGpfXhsgiwijaG?= =?us-ascii?Q?slNMLFWtxAN69gd5wCcyX7+Dc3miBSt7vyL/X3KF0MUWqGsQcvfNZrgaUEE0?= =?us-ascii?Q?/fNAy6UQ93A3F9BTZwlJs8JsyphLKTxmGP/Ji8hIoaKrFG8q6JG4Uhb/J9W5?= =?us-ascii?Q?TFve4qNk0JXjbNc+ctGPmWceNgwhcxPVnxvUILlRqIePNObk3su1rDB0Pc67?= =?us-ascii?Q?AiJl0vxsYQ5M41ldX9BeY/zbmTMs1PJLHHnx4lbVGhScrWpnBTo6Qa8jvzkH?= =?us-ascii?Q?jvtLjFfStSjZ+XZkbRRiOlBt+JaL/GuZDE7lp4t/19IEqYNTW/MRxrXl5q/b?= =?us-ascii?Q?AF/naFMTrrPZ5DZp/0S2+ZeFBUNRA33uZiFN+V1t3S0ET6Zf+K5rAWHqhoMO?= =?us-ascii?Q?WlZdHoy50EvoM6fXGfhFdoeRiZpLmIXyygX85K5wY0D2wztXywVNPfv7+k7R?= =?us-ascii?Q?0rVM2PHn1j8uXnTKARMZdLHj+85qqb6Rcvy6hJ4eh74Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB365;5:krt67FRMVru0d/tWQ2hBYmg4ypafS24tZE5MDmu0wrJDsC+8JmFF9ksu0QH5m91hOXp7wV2dHifjmGruAszQEoVOAtPp8W1zOa8z4VoLZf2RS6CYLIHY80wjzmiAzRSPr3uFBiseugm4rsmEq7U2CQ==;24:3PgnWHTrrIOmYbLR4phE3rfl5fL2cfwv3DrhTjNlhE2IjL2IR0AqMwpiBtYXsleEsB5dezmwRaIHslMN6IFiq82TBL08G0W3GotB0fWLYjM=;20:zR0W3rY+g2wMqX4B14QTG5DSkyD6I8KtQyqLj2GBTbT2WzEVyYbuimBEDyp34qw2kZgUdgMq//bNKFUA7yJOdQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2015 11:50:57.4024 (UTC) X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.55];Helo=[nwd2mta1.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB365 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the device does not have an internal reference, there is no other choice but to use the external reference. In that case, it does not make much sense to have to specify it. This patch ensures that the external reference is used if the device does not feature an internal reference. Signed-off-by: Paul Cercueil --- drivers/iio/dac/ad5064.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) v2: No change in this patch diff --git a/drivers/iio/dac/ad5064.c b/drivers/iio/dac/ad5064.c index e77631d..18674e5 100644 --- a/drivers/iio/dac/ad5064.c +++ b/drivers/iio/dac/ad5064.c @@ -464,14 +464,16 @@ static int ad5064_probe(struct device *dev, enum ad5064_type type, for (i = 0; i < ad5064_num_vref(st); ++i) st->vref_reg[i].supply = ad5064_vref_name(st, i); - if (dev->of_node) { - for (i = 0; ext_vref && i < ad5064_num_vref(st); ++i) - ext_vref = of_property_read_bool(dev->of_node, - ad5064_vref_name(st, i)); - } else { - struct ad5064_platform_data *pdata = dev->platform_data; - - ext_vref = pdata && pdata->use_external_ref; + if (st->chip_info->internal_vref) { + if (dev->of_node) { + for (i = 0; ext_vref && i < ad5064_num_vref(st); ++i) + ext_vref = of_property_read_bool(dev->of_node, + ad5064_vref_name(st, i)); + } else { + struct ad5064_platform_data *pdata = dev->platform_data; + + ext_vref = pdata && pdata->use_external_ref; + } } if (ext_vref) { @@ -483,11 +485,6 @@ static int ad5064_probe(struct device *dev, enum ad5064_type type, if (ret) return ret; } else { - if (!st->chip_info->internal_vref) { - dev_err(dev, "No vref available\n"); - return -ENXIO; - } - st->use_internal_vref = true; ret = ad5064_write(st, AD5064_CMD_CONFIG, 0, AD5064_CONFIG_INT_VREF_ENABLE, 0); -- 2.5.3