From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751918AbbJLM0l (ORCPT ); Mon, 12 Oct 2015 08:26:41 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:35470 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134AbbJLM0k (ORCPT ); Mon, 12 Oct 2015 08:26:40 -0400 From: Liao Tonglang To: tj@kernel.org, axboe@fb.com, akpm@linux-foundation.org, jack@suse.cz, hannes@cmpxchg.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liao Tonglang Subject: [PATCH] mm: cleanup balance_dirty_pages() that leave variables uninitialized Date: Mon, 12 Oct 2015 20:24:58 +0800 Message-Id: <1444652698-28292-1-git-send-email-liaotonglang@gmail.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variables m_thresh and m_dirty in function balance_dirty_pages() may use uninitialized. GCC throws a warning on it. Fixed by assigned to 0 as initial value. Signed-off-by: Liao Tonglang --- mm/page-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 0a931cd..288db45 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1534,7 +1534,7 @@ static void balance_dirty_pages(struct address_space *mapping, for (;;) { unsigned long now = jiffies; unsigned long dirty, thresh, bg_thresh; - unsigned long m_dirty, m_thresh, m_bg_thresh; + unsigned long m_dirty = 0, m_thresh = 0, m_bg_thresh; /* * Unstable writes are a feature of certain networked -- 1.8.3.1