From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752746AbbJLTRg (ORCPT ); Mon, 12 Oct 2015 15:17:36 -0400 Received: from mout.gmx.net ([212.227.15.18]:64629 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752269AbbJLTPo (ORCPT ); Mon, 12 Oct 2015 15:15:44 -0400 From: Oleksij Rempel To: linux-kernel@vger.kernel.org, marc.zyngier@arm.com, jason@lakedaemon.net, tglx@linutronix.de Cc: Oleksij Rempel Subject: [PATCH v7 1/3] ARM: irqchip: mxs: do panic if icoll_base == NULL Date: Mon, 12 Oct 2015 21:15:30 +0200 Message-Id: <1444677334-12242-2-git-send-email-linux@rempel-privat.de> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1444677334-12242-1-git-send-email-linux@rempel-privat.de> References: <1444677334-12242-1-git-send-email-linux@rempel-privat.de> X-Provags-ID: V03:K0:W7qD4cKkAX4t/5rnUayayl7TqzdhKe95VcZJBlPCrxBL2Ktf77p JL6L8X1Skx/t3va0cDOwOdP8Vw6cc5gY/WTk2DgqOx19SZ/fDq7an7LaqT4nnxEWPYIKxA2 VpqsZzMxf60ndTqGknVrj0XGl6EB7UckOm5P8chacUnQnYJ4xW7d0gXg1oMRRSeBSXM9B5m 0Kq9rLbClIV7hrVcOT2Mw== X-UI-Out-Filterresults: notjunk:1;V01:K0:z00do7q9YoE=:iwwzSd4ReAxz4REiJqEhfs kq10RILQtsOvn2NLxQeTpk+xrgIeVa1ss8Azq67I7C9Vxzru2Lp6nT4kRZtx8E5IDL/DWHZGb 67gphldjvYdx6SdzLOPwMtTmWLjZ9zII+M1alXgWC1xWT+kTbpu/lPbdfWDCJ4xOalMvFvHr5 9t1Z7GasSUEXTj4S44BslundIicFij+1sBTsh/Ii+M80J6tE8p5vCsg1XpDWGkVnXP5xs+L58 3/YS/HEGcJYGV/ALWSCOduDLyW4Q6iPRFLeRXET9u6tSfu9rdcSw4D4ZIehc0ReeKSz4GQ/fw vGyna0RkPBG9aivOQJSF30Np27IoYULBXxrCcATjaXksw7MJV+LoLN6/7jGaoWgO2xI+67ozc Sj+lVs5XXPbVBiaSMW2StKUV6Gn+3TtsJzpLCm1qnLtmKyd3ycZTDFSjg8668iFFgLKZkq4BD ZZDUYZNAUzwrpcI6jwCktsPU+tDJrssJB9haW4tjSxocBXTvo8YeSG/HVJWR5uL6jPXXLm9qr c5sY6lJU4n7IoUvTub9k3+6XcnlBwkmBDpe/cSDhwp9h5OWKWMNN0rgcRn5DAPNMLQ5hDAo+w Czp9s+E9eLWsjWaFXnygqJLI0ebPG7tbh8d3YbLE3sLPQVMmZnqVu6UgXC08EXo8Uuo5TAP1e I2H5ddcFGBbdolhDfHtb9BOZ5y1xRO6i4Sc/NqpNv0+DpcjC4tURJVpp+G45fU5i+/x1N4M1E YZvCaPDb8Akt44jMeX3Xt5Y8QDQ64oiWG7jW9jjrToiZRBugrG8TT5D/9vc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Current code will only WARN_ON() and dereference the NULL pointer. In this case it is better to panic and stop execution. Signed-off-by: Oleksij Rempel --- drivers/irqchip/irq-mxs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c index 604df63..ce69860 100644 --- a/drivers/irqchip/irq-mxs.c +++ b/drivers/irqchip/irq-mxs.c @@ -97,7 +97,8 @@ static int __init icoll_of_init(struct device_node *np, struct device_node *interrupt_parent) { icoll_base = of_iomap(np, 0); - WARN_ON(!icoll_base); + if (!icoll_base) + panic("%s: unable to map resource", np->full_name); /* * Interrupt Collector reset, which initializes the priority -- 2.1.4