From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932249AbbJMCQz (ORCPT ); Mon, 12 Oct 2015 22:16:55 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:43414 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932092AbbJMCQx (ORCPT ); Mon, 12 Oct 2015 22:16:53 -0400 From: Tan Xiaojun To: , , CC: , Subject: [PATCH] EDAC: use debugfs_remove_recursive instead of debugfs_remove Date: Tue, 13 Oct 2015 10:22:51 +0800 Message-ID: <1444702971-94112-1-git-send-email-tanxiaojun@huawei.com> X-Mailer: git-send-email 2.5.3 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.38] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org debugfs_remove is used to remove a file or an empty directory from the debugfs filesystem, but mci->debugfs is not empty. This is not easily discovered, because debugfs_remove return nothing when failed. Reported-by: Yun Wu (Abel) Signed-off-by: Tan Xiaojun --- drivers/edac/edac_mc_sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 33df7d9..292e806 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -956,7 +956,7 @@ static int edac_create_debug_nodes(struct mem_ctl_info *mci) mci->debugfs = parent; return 0; nomem: - debugfs_remove(mci->debugfs); + debugfs_remove_recursive(mci->debugfs); return -ENOMEM; } #endif @@ -1070,7 +1070,7 @@ void edac_remove_sysfs_mci_device(struct mem_ctl_info *mci) edac_dbg(0, "\n"); #ifdef CONFIG_EDAC_DEBUG - debugfs_remove(mci->debugfs); + debugfs_remove_recursive(mci->debugfs); #endif #ifdef CONFIG_EDAC_LEGACY_SYSFS edac_delete_csrow_objects(mci); -- 2.5.3