From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751373AbbJMSWA (ORCPT ); Tue, 13 Oct 2015 14:22:00 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.163]:30617 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbbJMSV7 (ORCPT ); Tue, 13 Oct 2015 14:21:59 -0400 X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+yackYocTD1iAi8x+OWtqWFmrC5F/k8792rHpkQ== X-RZG-CLASS-ID: mo00 From: Olaf Hering To: kys@microsoft.com, haiyangz@microsoft.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, Olaf Hering Subject: [PATCH] Drivers: hv: vss: run only on supported host versions Date: Tue, 13 Oct 2015 18:21:51 +0000 Message-Id: <1444760511-4357-1-git-send-email-olaf@aepfle.de> X-Mailer: git-send-email 2.6.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Backup integration service on WS2012 has appearently trouble to negotiate with a guest which does not support the provided util version. Currently the VSS driver supports only version 5/0. A WS2012 offers only version 1/x and 3/x, and vmbus_prep_negotiate_resp correctly returns an empty icframe_vercnt/icmsg_vercnt. But the host ignores that and continues to send ICMSGTYPE_NEGOTIATE messages. The result are weird errors during boot and general misbehaviour. Check the Windows version to work around the host bug, skip hv_vss_init on WS2012 and older. Signed-off-by: Olaf Hering --- drivers/hv/hv_snapshot.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_snapshot.c index a548ae4..52f10ed 100644 --- a/drivers/hv/hv_snapshot.c +++ b/drivers/hv/hv_snapshot.c @@ -331,6 +331,16 @@ static void vss_on_reset(void) int hv_vss_init(struct hv_util_service *srv) { + switch (vmbus_proto_version) { + case VERSION_WS2008: + case VERSION_WIN7: + case VERSION_WIN8: + pr_warn("Integration service 'Backup (volume snapshot)'" + " not supported on this host version.\n"); + return -ENOTSUPP; + default: + break; + } recv_buffer = srv->recv_buffer; /*