From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753544AbbJMXUo (ORCPT ); Tue, 13 Oct 2015 19:20:44 -0400 Received: from mail-by2on0105.outbound.protection.outlook.com ([207.46.100.105]:29888 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752664AbbJMXUl (ORCPT ); Tue, 13 Oct 2015 19:20:41 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none;freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; From: "J. German Rivera" To: , , , CC: , , , , , , , , , , , , "J. German Rivera" Subject: [PATCH 10/12] staging: fsl-mc: Fixed WARN_ON() in fsl_mc_resource_pool_remove_device Date: Tue, 13 Oct 2015 18:03:30 -0500 Message-ID: <1444777412-5401-11-git-send-email-German.Rivera@freescale.com> X-Mailer: git-send-email 2.3.3 In-Reply-To: <1444777412-5401-1-git-send-email-German.Rivera@freescale.com> References: <1444777412-5401-1-git-send-email-German.Rivera@freescale.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC016;1:3MyYVImXogPcG0wz08MvEfIKDj/ZWujj1RHp6ZcDl12Qhg1lwT2l+7imGimGTSkmaKSnI1HYJMFq0yazoihXlGLLJBD2K0Nx+XPhIHpepGQnBUCz12sMTqQnrg9yNC4OcMqxTuFz30Jb/C/G6bP9lP7HgoLoOMSTvlll6PKrvEl150aqo3CgAespljs08xDx026SyORW2KLyLZ3Qst+ivmvn9Ud5+ujVY5ZIVH3ylyAFj7yPWUna5VhJ8Pt9NO8Jr0FOEmgsA+1HPfGlbPYL/OwtR4+r4pMfA2uUz/Z7OUi98lPijiSfWFmd5kN5799nPwGVO3WdLYQ1aC+QUb1iqK3hAHjhnbe8++rrhYVy9IG+x6sbXkJ1mvHGsIxaqW64pl/QHLoPKx4pQ6eNrdgWnA== X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(104016004)(92566002)(2950100001)(47776003)(46102003)(36756003)(86362001)(105606002)(64706001)(85426001)(50226001)(69596002)(76176999)(50986999)(106466001)(81156007)(5003940100001)(97736004)(5007970100001)(2201001)(77096005)(6806005)(5001960100002)(48376002)(87936001)(229853001)(11100500001)(5001770100001)(50466002)(107886002)(5008740100001)(189998001)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR03MB505;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB505;2:dEgRh8oNPYmQAlZg0aKBumOkP4GtXLbT0vVEabouT+UOcYfx6W2EywLaTVlFmbRZlFs0bN+kI4gsB14drOqVNdK5OJuU2aZvId/tF60XiA22pvjQP4blbLn7CTrEM2G78HriGFyoZeQePb8VuqSC+EY75eMQZ4ioDpY+3JoEOP4=;3:nFKe9WwnEo7PuTQ78uMg1yiY2pNid6ciu8I7LdUJVbT7VdhaYFyhgTo34k9XqO+I1Etl/ZVGFCHFUvHIWVru4I6fT1wT830jy3ih38RbSbXpsdi/gYMzT23F3z0b5I1Z701R9eOL16V704iItzq5E1Ml2Q2O5kIfzxR4o4ZvlLiI4cfRvBxoPUHEUfxkCNaVO0tVpU+6WIANs4QG7gpD8EXMn3pKS5+gYIM6HL291ss=;25:/PHZLEGissG1fxgaFcdprLT6dUsPWXBPXTGArM6RV2+whDSVvGktFkmpU84ErRzrWkNtTZuGJeW0ehZx//qV8HU98+JHZx4FWLfxT+zwdAgEUmXjj5DjFcLD85vTGS6ynWtWYmAcXe6TsVJJn7HBfqAJcADsvjZJa3dyUhTzval1JVzveT8cZ3VZYFDx3lcfNQuOmqix3oEM+cSNi3iRF9qJqbzUebtXKDvyHzysXpI8lJ8iuO7XedLNrD7ivYSY9EJ1f3/4nO7RUvU+bw0Otw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB505; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB505;20:gorbh4Rj8G17HL4ioDq1tCW8g+kRVOPUzK4y/jfh6kxvUtcBwpN7o9O6zncb1Eh0gfreWYbzJ2CiwmkuvMmzCWoWfBCwBtcvmhuqPoFNj4sKEFa4/Y93RatfwrqQ0XmWOl9MkkQT1GXl+DKlaAwCZQoqEkQQFBwFJ24/DqLNQ9LgNZCbm2ddYUtz9volZJZfgBqA1KgZpKIXfi0ScYC/H2inaRzzphIiqTOs+5lTphfdsXGq37jFIFP96mGvKf5pJpHet4D9sM3cTCwNjEDHyP316oxXzsnMaT3YCzKHnSO2cIuPLepxOJ/52fWzUDB0v7Sqhh93YxF90TUNxlwFOiMr9Mg8TtuWHKTJwcYrKzo=;4:lwoJ+Ddy3f599urnRZAKWjJDYllNvtVszMcOPiUMdv0xJnzXs+qn1SOLUAFLwgAUW5fCq/M/6T39RvySJ+p6EFWuoBK/8D+8vO18Yc1+1wqtUdLkqfzJnybKonc2l47p6RhRiN40S+zFJaut0mBPMeQOZSC9ietw3SltQIga5JGOs/Jv3C1o/dpO5+RLspcRpYZhINQ6UMpLZNsLgjWPEzdH+kS1U0dLaXi5980d3cXS/XI3xtDLEMOEHOe6pnghYya1OR8i9IaSMHEr30qIS9Oly866vLiZk4alQbPhANICKuefc2Z7sGkblKIUfO1jZ3pJtZvdSUAUq27hkGwXmTxrDetra6C5iF66NVFBnpA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001);SRVR:BY2PR03MB505;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB505; X-Forefront-PRVS: 07283408BE X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR03MB505;23:IbeibS/7V2ZcXItGy+Ousskk9pFvFJT+V+ApU2ePms?= =?us-ascii?Q?zzIKYojIkXMv0vFW+2wD3kKNps9GfVR1a9KIO+u8MBmiZRkcTwP0A07L1mKF?= =?us-ascii?Q?THwpD+Y5ZNcCGOJNJ6yIjmpTwu7pl5vraedyTJMcarvyhQjx9AsGec7XDG/3?= =?us-ascii?Q?CVxTUBBmgGXiIhU94a5iTxhUF0TacnWs03+7ArWwBYQfvIPAK0NN88t6LqnX?= =?us-ascii?Q?mmqMzEiV6x9BTk+9vqrjYcoUnuyQqIpaF7e6fhvoToHdPXCdmocV1JmMJZIe?= =?us-ascii?Q?lICr2mQHE0uGMPdQLbLAt+qRW3K0Rsbvj+/n/+/Mive8S/0txV3X1mU7yUW0?= =?us-ascii?Q?kHNXWqV0AOoYXqqhPHZ4LKqntn3uAiwVYTVU/AzQSLfgFTJFrZ0c4EGSqLhB?= =?us-ascii?Q?b7fS3NsoiErdT7WvNQxiAZO2CGzKvbGFIrX6F2N82MZTDeFPXTmiyJ+O4oXx?= =?us-ascii?Q?dhJPjkGOslvJMTRQyvPbEMC9tigHoluSsYMZpASk3vTF7NmLpNGPnlP5/ltj?= =?us-ascii?Q?c6cYSqb5FB5/HyLuIk6zCT/w/dhQjj2UzEksxCNkOQMy49bg6EUsZcSCHHi3?= =?us-ascii?Q?5Q6QTSqvtN/1Chai0a5Vr+TiThHN0eY4c+VTq0f2qhqOFoGijKMYmy3mFy0w?= =?us-ascii?Q?MEy6e/yNeZ72vXEHmS1NvxqhNJ6PLj2OjoZbB7kXAKEcBBuoP/ffU83hMHV2?= =?us-ascii?Q?Z5RuIyBLEULbDg+9wqlFhRD5hIMVwHpXUSB0OnuUua79MiKywFfpHzuLKYBN?= =?us-ascii?Q?W/YP+oy7HY+aLX3Ukp+ZU3RnkWGesdv8zALdT+SKn3EymZSWKqXQq+tJpmO+?= =?us-ascii?Q?63QYZ0x7R4bx3KBDnkVPlGkxVEkg27CJsbhaPMHTe1so+JOhlwTaXYOb6BHy?= =?us-ascii?Q?42Csit4gp0op0X1UkKGwXekL0b2JsiINW3QZPU0zYZYmyb4E1i/6S6ttaU+m?= =?us-ascii?Q?XWdshw2ORirrsdODf5RzXaaUFljfUXRaYwSp7ugeTN8D8Uz1WRNV66mIPqo1?= =?us-ascii?Q?HKmPHo+RM6zhsPkj1EId80lsbYKR9mhQh5qlLlC/hpYI4G+iJkcEu6zApEsv?= =?us-ascii?Q?odWHIWOXO3wmsAFPPwt/63IMYTEAZcykLrOHIEFJcRSzXqhg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB505;5:XtBqAypoMM/f/M0WdxBEiUyqtFa7dckYbjK7RI08j3O/BfkqXo9HR1R6ARVlbof3q8vVA2FLj5iQKD1bTTKSQQN9Ks/rI+YMeDwOptpsV4oD8x0h8SW3BbCPOGA2Jz3apl/QJBp/h58j67knbCXxPA==;24:wJGOfRvDQSycYMra87bjemxgaKRcPqIi5Au4FmfoUso3ISmKi9LA/0yV12FGNqlKy8SZUBAe7OfGgWLbk5qBwfgG12NcqIBIIzZaMr0S7r8=;20:jvqykoBzwK20CJpuMbaQmd/9BzDHf99H12t02nT/I82JB2HoL8tKbTgxD+a67TJkPJ8KPTn9M1ABuNRvnPvbOw== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2015 23:18:34.2146 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB505 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Check that resource is not NULL before de-referencing it. --- drivers/staging/fsl-mc/bus/mc-allocator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c b/drivers/staging/fsl-mc/bus/mc-allocator.c index a45293b..88d1857 100644 --- a/drivers/staging/fsl-mc/bus/mc-allocator.c +++ b/drivers/staging/fsl-mc/bus/mc-allocator.c @@ -111,7 +111,7 @@ static int __must_check fsl_mc_resource_pool_remove_device(struct fsl_mc_device goto out; resource = mc_dev->resource; - if (WARN_ON(resource->data != mc_dev)) + if (WARN_ON(!resource || resource->data != mc_dev)) goto out; mc_bus_dev = to_fsl_mc_device(mc_dev->dev.parent); -- 2.3.3