From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbbJNIx1 (ORCPT ); Wed, 14 Oct 2015 04:53:27 -0400 Received: from mail-bl2on0103.outbound.protection.outlook.com ([65.55.169.103]:47282 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751990AbbJNIxU (ORCPT ); Wed, 14 Oct 2015 04:53:20 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=none action=none header.from=freescale.com; From: Tang Yuantian To: CC: , , , , , "Tang Yuantian" , Arnd Bergmann Subject: [PATCH] ahci: qoriq: Fix a compiling warning Date: Wed, 14 Oct 2015 16:46:52 +0800 Message-ID: <1444812412-33321-1-git-send-email-Yuantian.Tang@freescale.com> X-Mailer: git-send-email 2.1.0.27.g96db324 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD044;1:nSSIpdZVCWVGu5BAxU2lz3ye7JhryU+9oQ5V0WmObNWAdXnILzKZaSnCcDwGxBB8NgpW4nKkAwnrruZ5/koqC65jCtrsvZu8bxYxavTuX/6sS0S9NSES6S8WGUhnjfhten/wt6JZW+z90UpFL9xHjTpcGR8lHzt1Xhzl77AXgeicomY1Ud6tSGJc2dT0DmnD+QPsaVH1otfvjR3JepRII9EMULyVhYUXN8RUKs9ZRcdupycDf1y8XZeZg7+H5FGsqN6oaWLoD+J5mpr2rYaRRdGbompMqJuM12WfOj//AwqbZHT+P51kgl0JRu/cQCeXoBo5AZnrUd0Ew1C1VrxVRGmOgSg6r9gopT34cpcvwZI99rbuFdX0SRndAt7qvBNpp+HmfyKNNQOV+fDqrgTpfw== X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(50226001)(105606002)(77096005)(36756003)(5001960100002)(64706001)(87936001)(81156007)(5007970100001)(97736004)(11100500001)(47776003)(50466002)(104016004)(5003940100001)(19580405001)(19580395003)(6806005)(92566002)(189998001)(5001920100001)(229853001)(69596002)(106466001)(50986999)(86362001)(5008740100001)(48376002)(110136002)(46102003)(2351001)(85426001);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR03MB562;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB562;2:bR+TJhMiSNFuDw40sLI1AfeQWbJ67FwPwZBdF9IrrsL+52x7wfxbp/JraZ92Y+EnOVCY0fcS1L9zJgi61ggbdAkbTpAuFhgHVibbQw17mXOqXthuNYC33m7ObQlfMWigzmuQMvXhtYh7ZJVXNZs4oCrsGVeFywL5w6QsHnMqZRk=;3:o0LBX5sTRmp7j4Oa3WyBl6KnlBl9c7Vucjx0yAcEI7Dad//Iomc3/yJ0bA09KNOJ2GtJvFDm1FCIHe0fUxLHoAfbp+0g8e+mL5o/8dIT2AmTaG5xVqojrXpz7n4v4OL/Iz6nBC1RtBNmx0lUHEBQg6L1GE+fPzgzBWSXQqJzcW8ngub/nPNIpEWKdb3cBmeUezX2eT3wBXFjsw75VbIXFWB4uf9ck3JR6ZueNWzqwig=;25:oOxT4iWd243mWvlw8x4HOCTVn2QqnzbXz9EHn2MZk9WM8qaGGQmBiHUyJoSvmGjQIC6oj2oElmYCaMzIfwQLuxJ8lt/0oftMH011SYJU8k9nMoxJ9nrzA1+/1qBErKyXBuvjyYsEntM9rJv//blZEhhCMMudcU2Iy/MI1mcLHirVtQDJKm4oi0Wt7AsTXmPQ6owVjyGFxmMdhBQl+wrmIYCsR70AbgOMobdoM3tZbgZqfcKnXutUgNFubgRv7/nFtr8aOkwS3wUAhB+7GRr1HA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB562; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB562;20:IzKDMMgsTvbJl462hOFlzltatGrcjSvtNeECojAQKhb22HWWEK6K2mqvLbJDSqYJiHPXQSl6LSpSrAx71P3V0cE1nsVUrG4Pl+XhxoLNvN+Xbv8RbEpbTZOEeHEYtIoJIBkLcMkUio6fxR+4Ak63l803fEwqOEIGEbJob8gwVoEkR0CCMlrJ0iBn5lv4XJs3gp6hqh6QIVhaCsRPnMqLgnmIJRZC8HjrMgxQ4eheGjIkzBkmJMpO4WxBiHQCVg43l9uxIReoFMjyUjPdUD1j5rlBp8iWTB6AmP2SpQlDCR90jbpBi2GTcdJ7tloOu1WQO2jR65IWAbxz7uLESag/gv3WN2n2ooak3JOXCLBac7Q=;4:EszQEKg+UqwvJKxR1fzaal/AfbY70lDQPws8zzp3h936x2P/xJxWRChHlN/OeJ8jy79XZrmklImf8hKuHqA9fF2VNnz25nn9Z4hF4F0E7TXdVzkiax1g1VmHAhBO77MPF4nB27q7K2s0RINIbt67VT6jBURetSEh8ac0uTWVM6GG39QF/A9gsgXx+wkh63Es7B9OHB/cKQCBMTrIvKMSAkrVRBveOASS6aOnA2wrGFSCAlF421QN/645kYxNBEZcFwndNt1gWxAq7a2aaDzWMZiab3d6CE5RcTTHlEWoHD3MAI/shLW1aEV0Q/snbw2ogegoIYoLFDQ9lBby2c3k8CYpR1WpgFM0/ANENNFPoTI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001);SRVR:BL2PR03MB562;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB562; X-Forefront-PRVS: 0729050452 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR03MB562;23:NYLkOlOTC5vh1Bqh03HAcSIDRZRro7J1dYuKeiyt15?= =?us-ascii?Q?GdYrAPUv/3P6ecJ9ZLiPwDnph4YrUJ5103v5+q9FJSlIR+3vCJYqEpE2n6YN?= =?us-ascii?Q?sZ5SeIkI6zVCyaj7h8HACEVrWbtI/fyhAdpdd1IhnFgCQrT/I7laAjbDETCB?= =?us-ascii?Q?4zv8k3w0e+GV8HLOu5yPD44weroXefOhxjfypAY+ssO5lnXIkZWib097oboE?= =?us-ascii?Q?+2gcw9PfJR5ZRmMb5Mg45Z+HGpfkVE32Ok5nFktlnCVT7MBEbENJhkdSexvV?= =?us-ascii?Q?/48puwWYLwF76qPYKWWunMcrYU27PNEOgLXyJFeFK4hL91J2yt0SwdPQ0VYN?= =?us-ascii?Q?0hrzJAnbxzc2a1Cxr2+h94MQrGn1nIcmuoQlDKH5ZR7vJUKNUhAN4AYUqjTA?= =?us-ascii?Q?A+Slcmldua5LyBOusfaeNCq0TG/iijvEmdRxxL+xvohZIIgn2uHhKfZGf4y0?= =?us-ascii?Q?xCtH98roD6h0h2/mLlIvWEVG1MpiWOn/Cw//fAbhnKuN8df6DYnsr/KyrkwH?= =?us-ascii?Q?kaAlhwR9fnBh4W07iUuszdtLlq/NVtVX+aw/FTlkCCdSZtjQ9eAVjD3li/Ez?= =?us-ascii?Q?qbOtyLsLbGZ65PWT752wQXq5kHoRv7YmFYGzFfPnNVkkv+icNVsVEO0F98Oy?= =?us-ascii?Q?AmOpdzQC0BBne12GmqMR3r7N+Lf+q+hNhkUa35EJmHYDIaKJmi8xrYjb/HK/?= =?us-ascii?Q?LoIw8wE+Oy8XgjKBCBQ+V9m2hGT2i2Us5V65s2h2U6plhQwKHOB/a8D8LZnR?= =?us-ascii?Q?ZzetWkImIzcn15z7Jgr9Q54nkb/EKUqZDGpC28eEOxmjkHBpG5Uy1wBWrGQD?= =?us-ascii?Q?7YzmeGwXu1k3DwEhMXpr2ufcJ7v5pr9ymLTUR3bZF3BOGxGcFURaMm25Agu4?= =?us-ascii?Q?h1+i/swI2RSV4Ii+MNeplOwSSj/ElLoXV4+pO/l0bxlyXiuxvi08xuNKqMp/?= =?us-ascii?Q?bw/sil2mwC6Wg/lxT44ri+OyKB7bKsZ/XsY9hbKknDx9/Qi+enCeFXqGFN2E?= =?us-ascii?Q?se1eCV0SiLItdqS7/Uhw5o9oKYfgij6eBpEXkwqPrUqP6rvS/rf0KPH7R3oR?= =?us-ascii?Q?QVHFs=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB562;5:F/O7znwfkAcn/N3Hk8blbPd6BNyB9Qn1AHOej1Az57LTL1g159w1hdSX4asGURDmpW9ZqbJZlHawyaIGKS1yx6edqUdqa6eqScZbGIiXgyyErfpQr49ipNz1hd4ChKSFwBRs+YTpc34JCehEf2WM7Q==;24:1aM7j9q+5ExPEl9UsZDkPq/bILOikNHdJkCnnisVGTGe6ynWUJXiqYHvCkV1UQM4zWHSqQHJ2M8ewiWKZjpVdsZdnJsTzKyCubtJb2uK4k8=;20:Z0j1rvegmx/wx4mHf0HyVLkKj+JqNwzMNslByJ3FVRr4VR74tP0qWEMChD/3P2H459hROwRVL4c/PU3Wqsc+hQ== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2015 08:53:17.1551 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB562 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kbuild test robot reports the warnings: drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset': >> include/asm-generic/io.h:163:2: warning: 'px_is' may be used >> uninitialized in this function [-Wuninitialized] drivers/ata/ahci_qoriq.c:70:14: note: 'px_is' was declared here >> include/asm-generic/io.h:163:2: warning: 'px_cmd' may be used >> uninitialized in this function [-Wuninitialized] drivers/ata/ahci_qoriq.c:70:6: note: 'px_cmd' was declared here This patch fixed it by introducing a local variable. Signed-off-by: Arnd Bergmann --- I found this warning again on gcc version 4.8.3 20131202. So this warning may not go way with newer gcc version. I verified Arnd's suggestion and it works. So please apply this patch which I sent on behalf of Arnd. drivers/ata/ahci_qoriq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c index e5e4988..58c1a94 100644 --- a/drivers/ata/ahci_qoriq.c +++ b/drivers/ata/ahci_qoriq.c @@ -76,6 +76,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, struct ata_taskfile tf; bool online; int rc; + bool ls1021a_workaround = (qoriq_priv->type == AHCI_LS1021A); DPRINTK("ENTER\n"); @@ -92,7 +93,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, * After the sequence is complete, software should restore the * PxCMD and PxIS with the stored values. */ - if (qoriq_priv->type == AHCI_LS1021A) { + if (ls1021a_workaround) { px_cmd = readl(port_mmio + PORT_CMD); px_is = readl(port_mmio + PORT_IRQ_STAT); } @@ -106,7 +107,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, ahci_check_ready); /* restore the PxCMD and PxIS on ls1021 */ - if (qoriq_priv->type == AHCI_LS1021A) { + if (ls1021a_workaround) { px_val = readl(port_mmio + PORT_CMD); if (px_val != px_cmd) writel(px_cmd, port_mmio + PORT_CMD); -- 2.1.0.27.g96db324