From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932250AbbJNULQ (ORCPT ); Wed, 14 Oct 2015 16:11:16 -0400 Received: from mail-by2on0112.outbound.protection.outlook.com ([207.46.100.112]:38882 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754037AbbJNUGz (ORCPT ); Wed, 14 Oct 2015 16:06:55 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none;freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; From: "J. German Rivera" To: , , , CC: , , , , , , , , , , , , "J. German Rivera" Subject: [PATCH v2 10/12] staging: fsl-mc: Fixed WARN_ON() in fsl_mc_resource_pool_remove_device Date: Wed, 14 Oct 2015 14:51:49 -0500 Message-ID: <1444852311-673-11-git-send-email-German.Rivera@freescale.com> X-Mailer: git-send-email 2.3.3 In-Reply-To: <1444852311-673-1-git-send-email-German.Rivera@freescale.com> References: <1444852311-673-1-git-send-email-German.Rivera@freescale.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD006;1:aW7NpZxJ8gm/XBAXD9wBFgx8bRVBBCz0IExIA/WboVQ5Ukkot+V8eoDSSgUwSjFvwa54gsD4KCDCrTqT/FUoGyAdHxGhgMk2MAc73m3DyYKp5WMQwggcuNbTgJQ91lUUh3nQZOvpasZ6qoJx0f5Dz1VHKN/2WejT2IoRozAi+db63UELJ6ieu5jnok7f1/GVIXyyKG2oPcr3HCkRWTO6MqzXyTv8k1ity+qwNE1Az4KNVtXt0YFOc2mVWTDsPfUFqXEB3WuZawOs4gWU8vZhlh7gYnu+MEf7GiWr4nHTeF8WrmYuxgL1aryrGXbjX4nrUZZpuJ7u7NpoDUHWARfmH+4PrkwfO1EUx7E5IH+3JShEbjCS9RK/w1ZgQv6/0hFU6fjFS7z4Ruz4YKgB6Vcm3A== X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(76176999)(77096005)(97736004)(47776003)(48376002)(85426001)(50986999)(87936001)(107886002)(36756003)(5001960100002)(5001770100001)(105606002)(189998001)(11100500001)(5007970100001)(5003940100001)(64706001)(50226001)(81156007)(2201001)(50466002)(2950100001)(86362001)(104016004)(5008740100001)(6806005)(229853001)(46102003)(69596002)(106466001)(92566002)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0301MB1306;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1306;2:ZC/LMZ9lAfFTs8x3GD46I2v0gu4OvGhMAVSeVcWJ3rQx+wlKNdIcHQtyhWTuoMtiUpLSL31VyL+yw8WZUONnr6CegEihm4eBqhjWmXfN6WqDDSNCSrXuyFPU7exdQJdkpIt7FNH17TfdfVdMp9A0qjz1QRLO7X0SPOy8bp4otj4=;3:xLHiKV4oK69uG8ew/uTTW1QaTnzzIglEDbUjCtOqkfjAwX6RJFUFh/MJSWEnUl95Nxfsv+gPTWU37fU3t3ICYon/uiG/NyNH17WMjwev24VkLJviAAjM8NMk438hMSYFIk11TtoxYHxkYfh6uLMbhSnBG2u4LLBFC6n3Jn4UjzWOJmx5fnapEQ3heH8LDjpWTbk6dFC7O5iRy+R4H6y1s1Wn5gZ5Bw3cgKEAJcEtqBg=;25:PCIZVRPzo0erWlxua1faLmAzY1yJU+ff2DMpyAs5t7m0+D0ZxVqTcqKQB/6nDbCQU0fomnotrGPWsi/du+55xyxfPGLtj/gUW4EHLd7fdYz23xpEIoG98zkyuZgjBZpBi3r4A4iiSOQgiyZ3/0qJvV07dNvdjmITSet+g1UWUSUwYZTKHH0TZj1re6FjtHdmEHGeLUKXhk3nZvBto3cPc8Uv0LwTCBtwSL33IGUZn6/lFpJP7gP9M4To0d/F0jbEJGmcj9AQ6I+EwM5fVfvjAA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1306; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1306;20:YudbmmX/8M5N10rQKDKVAfZAVKRj8Q73nuugB1HXG+2n0IaL4qAt0eC1fVYonDpRP9w5riBXsmRHd/3WJqbYoS24Y9sptADiNgfcgQawH5enxwPe/cNHT/fXWDdyQp5hXwPbbaF0WA6F9CedusFGb2fLu104lCi8TD1oquz0oY8t5mph74A1c2zeKRckHFVz6O2u3yOHhB0wZTDkHib/a3udDEHGtH825Is5iXHPbClxcgK864akr+ay6aF2VZoeQh6qVTjGtbqQM1REXo2l/ArpE/0F5cUojLCg0ylKJBlk60Z9MRp0AVyHsYjYrSyFbvOqHtmjWfoxtkziWHnnqWzZU4ifE+w6zDgnbXxcTOo=;4:pF28ghXJD8XG1GRM8jY22yLJsB4Iph6CP6LCr1NLqWHDkJvOK24kg8LYOt3Qv8ASGAdJo0GNaY2PinKKSIF+t4W33H44218cetdyq15hyu0Yoa/SNB8O+zNnQUOEjorbl86S2LApy5nNs4UNNkhIv4I12kPkG9o5OSyI8FiuKgnlOaPckxxYkLzkHKGEiZrAM/SQ+X633oq9Pi7t8YNDE1mQs4xUzSywcFe3km3iUxhMWZV+KR7Fbpsy3HMAQf5xmsxYieKc9L69YUynglYghsWpuPkm8syeZ9kkY9p11gWa3FXO56bQVtKbPHlJbLAYsogZUUU/HTGMMRL+A2AEHCPl5vVIXYp9sPTka586rlk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001);SRVR:CY1PR0301MB1306;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1306; X-Forefront-PRVS: 0729050452 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0301MB1306;23:v1XzvgTcYcAVBmBR9HG7OJxaIsWpuOSpnsCHVl4?= =?us-ascii?Q?n/LcczcjbEAvO7WMS88f1kTNDm99Y7uPm5aaak008iMThH2lpRumDjQKdaVT?= =?us-ascii?Q?v19a9enzpy+a+FR3n0y/kt9bDj/mmMWVnQ+XiwuGsOWyMg099FwuaWGh4zux?= =?us-ascii?Q?x/fgWdJDkpzk8NAV4IeotuSFbBAxk+u8xy6g+5IlxsayEDEQsqxz2a5xkZQP?= =?us-ascii?Q?GF4bQdLmevjobeGTT+8TZ5+fDGj3sMPz5OkrhJMCi5qP5uEf9kyhPcS4udw/?= =?us-ascii?Q?+VwrJqVhvHuUPMUw9ZgY4Y1Zm988BFgNpDf0HD2fyIVJNyXe7ySlqt2v1BeE?= =?us-ascii?Q?XShKqW75JirPfOYMCz9N8kSBXqpGwsTWAv5t22TRXwNNO/o34HTBOpSP3sJD?= =?us-ascii?Q?n1WqeK7jwHTdsUv+ufKzBrCXYD/dVhui/jaSRQq/FY4BTWFoeTU4mxWEsoYS?= =?us-ascii?Q?MLjm/icEzYBT/V9d9XunsvpFsHvmblr8wI2r0GDgF6KFgtH2nGTpRBRG75Cr?= =?us-ascii?Q?w0z90H1Blv/TnqOO1Pe8XE+u0G2CYnTxOw+Ga750yCB31jDzwL8baFTjtCzi?= =?us-ascii?Q?Occ+eX6wz+VMDC7xqGghzgz3KBnw+1Ii7AruY0Vt2M5j0VN1OOVYhOjIZX4K?= =?us-ascii?Q?3+Y0B2bK8xAUyPoaYKLmaQm9hkvE/3yrJ1CuLfsdBH+f9y5TW0V7YNtNf6kt?= =?us-ascii?Q?RivJgboXXaoitX5hHBOz+Ae6h3vEDkEG/7f91nPNRn5hX7R+ZsX09XEINCHa?= =?us-ascii?Q?EgjtA1CvEwDRG6UnOrZrZW+WViJHn+f35aHB6kqyKKAh3Qb8uRPekfwnf7E9?= =?us-ascii?Q?040IST0uOVb1HIx7WfYse3gm2Bo3pYLAV10AAa146WOiUCNJYtmjGbI8xiuk?= =?us-ascii?Q?G0PZRATqjuI0T4HqA1zHtVWbqY27IU0kXXbQuDOEbXso0/4084RqtujRdQKZ?= =?us-ascii?Q?7iMlUviWudHMuMWwUyfTUEI8uMGTwUVa9nkGmSHY/ytagnMh/BQ2oO20K/qC?= =?us-ascii?Q?35gmbEi4nn/B93pnjyvFDiTeEiXm1PHB6EAFxLUgX2tgJyo5J7n/8KxaNjr+?= =?us-ascii?Q?Dzou+pkZL/hZntzs4Izvy64R2Tgpniot1zwz2je/QLLK3slGxnw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1306;5:NvLrmzsdSX6OpQbhMCwn+zAAloV5kiTF2Rphc9RzfytXFgjDfttvw9enFVPJ2LS9OVSGWqi5Jr92PwF+tCXGvFKKYuxczcFRgf3jCHrESOnkFZmsuWncOziY7BHRAODrmnAUgIgIArDKd4OCPIooQg==;24:s7DY9UIf3MYWxYNDrKtVcEoquT3+R0hm37Fme7aYzNMFVgOrD/hG6KuEjhCqJWo04JoI3HRIEtSTY82UhPaBTYOhcCtFu9HqHFQzh9Fnemw=;20:fjwSzecyN1E5HgzPdk4viOLbC2wy0t2rA0S1Q0E5YyhPhPyaU/EeZRoKQCBl2af8U5dzwS8kN7MmOK7wgruVSA== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2015 20:06:52.2856 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1306 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Check that resource is not NULL before de-referencing it. --- CHANGE HISTORY Changes in v2: none drivers/staging/fsl-mc/bus/mc-allocator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c b/drivers/staging/fsl-mc/bus/mc-allocator.c index a45293b..88d1857 100644 --- a/drivers/staging/fsl-mc/bus/mc-allocator.c +++ b/drivers/staging/fsl-mc/bus/mc-allocator.c @@ -111,7 +111,7 @@ static int __must_check fsl_mc_resource_pool_remove_device(struct fsl_mc_device goto out; resource = mc_dev->resource; - if (WARN_ON(resource->data != mc_dev)) + if (WARN_ON(!resource || resource->data != mc_dev)) goto out; mc_bus_dev = to_fsl_mc_device(mc_dev->dev.parent); -- 2.3.3