From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754672AbbJOGgU (ORCPT ); Thu, 15 Oct 2015 02:36:20 -0400 Received: from ozlabs.org ([103.22.144.67]:54156 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753384AbbJOGgT (ORCPT ); Thu, 15 Oct 2015 02:36:19 -0400 Message-ID: <1444890977.5970.4.camel@ellerman.id.au> Subject: Re: [PATCH v2] powerpc/mpc5xxx: Avoid dereferencing potentially freed memory From: Michael Ellerman To: Christophe JAILLET Cc: benh@kernel.crashing.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Thu, 15 Oct 2015 17:36:17 +1100 In-Reply-To: <1444888580-12966-1-git-send-email-christophe.jaillet@wanadoo.fr> References: <20151014040011.8AB1514110A@ozlabs.org> <1444888580-12966-1-git-send-email-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-10-15 at 07:56 +0200, Christophe JAILLET wrote: > Use 'of_property_read_u32()' instead of 'of_get_property()'+pointer > dereference in order to avoid access to potentially freed memory. > > Use 'of_get_next_parent()' to simplify the while() loop and avoid the > need of a temp variable. > > Signed-off-by: Christophe JAILLET > --- > v2: Use of_property_read_u32 instead of of_get_property+pointer dereference > *** Untested *** Thanks. Can someone with an mpc5xxx test this? cheers