From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Javier Martinez Canillas <javier@osg.samsung.com>
Subject: [PATCH 0/3] ARM: dts: Mark SDIO as non-removable for Exynos Chromebooks
Date: Thu, 15 Oct 2015 12:55:27 +0200 [thread overview]
Message-ID: <1444906530-25048-1-git-send-email-javier@osg.samsung.com> (raw)
Hello,
The Exynos based Chromebooks have a Marvell WiFi SDIO chip which is always
present and cannot be detected. The mmc device node is marked as broken-cd
since that property is used in the vendor tree instead of non-removable.
This causes the device to be removed when the system enteres into a suspend
gettings the following warning when the system is resumed:
[ 181.944636] mmc2: error -2 during resume (card was removed?)
The rationale for that is explained in commit [0] and it was that using the
non-removable property caused issues with the driver whose reset logic used
the mmc_{remove,add}_host() functions.
But the reset logic in the mwifiex mainline driver has changed and this is
longer the case so it's safe to use non-removable. This series changes the
Snow, Peach Pi and Peach Pit boards to use the correct DT property.
To test, I've cherry picked commit [1] from the vendor tree that adds a
debugfs entry to force a card reset and after the reset, WiFi rescanning works
the card gets connected to an AP and works correctly:
$ echo 1 > /sys/kernel/debug/mwifiex/mlan0/reset
I don't have access to a Snow anymore so testing patch 3/3 on that board will
be appreciated.
[0]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ad348e1e2381
[1]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/5995363523de
Best regards,
Javier
Javier Martinez Canillas (3):
ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi
ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit
ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common
arch/arm/boot/dts/exynos5250-snow-common.dtsi | 2 +-
arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 +-
arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--
2.4.3
next reply other threads:[~2015-10-15 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 10:55 Javier Martinez Canillas [this message]
2015-10-15 10:55 ` [PATCH 1/3] ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi Javier Martinez Canillas
2015-10-15 10:55 ` [PATCH 2/3] ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit Javier Martinez Canillas
2015-10-15 10:55 ` [RFT PATCH 3/3] ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common Javier Martinez Canillas
2015-10-15 12:30 ` Tomeu Vizoso
2015-10-15 14:42 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444906530-25048-1-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=dianders@chromium.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®