From: Li Bin <huawei.libin@huawei.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Will Deacon <will.deacon@arm.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
Punit Agrawal <punit.agrawal@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <guohanjun@huawei.com>,
<xiexiuqi@huawei.com>, <zhouchengming1@huawei.com>,
<huawei.libin@huawei.com>, <dingtianhong@huawei.com>
Subject: [PATCH] arm64: ftrace: function_graph: dump real return addr in call trace
Date: Thu, 15 Oct 2015 20:12:35 +0800 [thread overview]
Message-ID: <1444911155-17480-1-git-send-email-huawei.libin@huawei.com> (raw)
When using function graph tracer, the printed call trace will be as
following that has many ftrace_graph_caller (return_to_handler - 4),
which is been placed in the stack by ftrace_graph tracer to replace
the real return address.
[ 198.582568] Call trace:
[ 198.583313] [<ffffffc0002a1070>] next_tgid+0x30/0x100
[ 198.584359] [<ffffffc0000907bc>] ftrace_graph_caller+0x6c/0x70
[ 198.585503] [<ffffffc0000907bc>] ftrace_graph_caller+0x6c/0x70
[ 198.586574] [<ffffffc0000907bc>] ftrace_graph_caller+0x6c/0x70
[ 198.587660] [<ffffffc0000907bc>] ftrace_graph_caller+0x6c/0x70
[ 198.588896] Code: aa0003f5 2a0103f4 b4000102 91004043 (885f7c60)
[ 198.591092] ---[ end trace 6a346f8f20949ac8 ]---
This patch fix it, and dump the real return address in the call trace.
Signed-off-by: Li Bin <huawei.libin@huawei.com>
---
arch/arm64/kernel/traps.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
index f93aae5..4a4e679 100644
--- a/arch/arm64/kernel/traps.c
+++ b/arch/arm64/kernel/traps.c
@@ -143,9 +143,38 @@ static void dump_instr(const char *lvl, struct pt_regs *regs)
set_fs(fs);
}
+#ifdef CONFIG_FUNCTION_GRAPH_TRACER
+static void print_ftrace_graph_addr(unsigned long addr,
+ struct task_struct *tsk,
+ unsigned long sp, int *graph)
+{
+ unsigned long ret_addr;
+ int index = tsk->curr_ret_stack;
+
+ if (addr != ((unsigned long)return_to_handler - 4))
+ return;
+
+ if (!tsk->ret_stack || index < *graph)
+ return;
+
+ index -= *graph;
+ ret_addr = tsk->ret_stack[index].ret;
+
+ dump_backtrace_entry(ret_addr - 4, sp);
+
+ (*graph)++;
+}
+#else
+static inline void print_ftrace_graph_addr(unsigned long addr,
+ struct task_struct *tsk,
+ unsigned long sp, int *graph)
+{}
+#endif
+
static void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk)
{
struct stackframe frame;
+ int graph = 0;
pr_debug("%s(regs = %p tsk = %p)\n", __func__, regs, tsk);
@@ -177,7 +206,9 @@ static void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk)
ret = unwind_frame(&frame);
if (ret < 0)
break;
+
dump_backtrace_entry(where, frame.sp);
+ print_ftrace_graph_addr(where, tsk, frame.sp, &graph);
}
}
--
1.7.12.4
next reply other threads:[~2015-10-15 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 12:12 Li Bin [this message]
2015-10-15 12:46 ` Arnd Bergmann
2015-10-15 12:51 ` Will Deacon
2015-10-15 14:18 ` Steven Rostedt
2015-10-20 15:32 ` Catalin Marinas
2015-10-22 0:55 ` libin
2015-10-22 1:13 ` Steven Rostedt
2015-10-28 15:21 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444911155-17480-1-git-send-email-huawei.libin@huawei.com \
--to=huawei.libin@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=dingtianhong@huawei.com \
--cc=guohanjun@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=punit.agrawal@arm.com \
--cc=rostedt@goodmis.org \
--cc=will.deacon@arm.com \
--cc=xiexiuqi@huawei.com \
--cc=zhouchengming1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®