From: Insu Yun <wuninsu@gmail.com>
To: rubini@gnudd.com, linux-kernel@vger.kernel.org
Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu,
Insu Yun <wuninsu@gmail.com>
Subject: [PATCH] fmc: correctly handle failed allocation
Date: Thu, 15 Oct 2015 11:42:52 -0400 [thread overview]
Message-ID: <1444923772-27625-1-git-send-email-wuninsu@gmail.com> (raw)
Since kmemdup can be failed in memory pressure,
return value should be checked and return -ENOMEM.
Signed-off-by: Insu Yun <wuninsu@gmail.com>
---
drivers/fmc/fmc-fakedev.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/fmc/fmc-fakedev.c b/drivers/fmc/fmc-fakedev.c
index 941d093..0515909 100644
--- a/drivers/fmc/fmc-fakedev.c
+++ b/drivers/fmc/fmc-fakedev.c
@@ -282,6 +282,8 @@ static struct ff_dev *ff_dev_create(void)
for (i = 0; i < ff_nr_dev; i++) {
fmc = kmemdup(&ff_template_fmc, sizeof(ff_template_fmc),
GFP_KERNEL);
+ if (!fmc)
+ goto no_memory;
fmc->hwdev = &ff->dev;
fmc->carrier_data = ff;
fmc->nr_slots = ff_nr_dev;
@@ -294,6 +296,12 @@ static struct ff_dev *ff_dev_create(void)
ff_template_fmc.device_id++;
}
return ff;
+
+no_memory:
+ for (i--; i >= 0; i--)
+ kfree(ff->fmc[i]);
+ kfree(ff);
+ return ERR_PTR(-ENOMEM);
}
/* init and exit */
--
1.9.1
reply other threads:[~2015-10-15 15:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444923772-27625-1-git-send-email-wuninsu@gmail.com \
--to=wuninsu@gmail.com \
--cc=insu@gatech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@gnudd.com \
--cc=taesoo@gatech.edu \
--cc=yeongjin.jang@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®