From: Insu Yun <wuninsu@gmail.com>
To: isdn@linux-pingi.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu,
Insu Yun <wuninsu@gmail.com>
Subject: [PATCH 1/2] isdn: correctly check failed allocation
Date: Thu, 15 Oct 2015 12:29:27 -0400 [thread overview]
Message-ID: <1444926568-29572-1-git-send-email-wuninsu@gmail.com> (raw)
Since skb_clone can be failed in memory pressure,
return value of skb_clone needs to be checked.
Signed-off-by: Insu Yun <wuninsu@gmail.com>
---
drivers/isdn/hisax/isdnl2.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/isdn/hisax/isdnl2.c b/drivers/isdn/hisax/isdnl2.c
index 18accb0..e74f847 100644
--- a/drivers/isdn/hisax/isdnl2.c
+++ b/drivers/isdn/hisax/isdnl2.c
@@ -1284,6 +1284,10 @@ l2_pull_iqueue(struct FsmInst *fi, int event, void *arg)
}
l2->windowar[p1] = skb_clone(skb, GFP_ATOMIC);
+ if (!l2->windowar[p1]) {
+ return;
+ }
+
i = sethdraddr(&st->l2, header, CMD);
if (test_bit(FLG_MOD128, &l2->flag)) {
--
1.9.1
next reply other threads:[~2015-10-15 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 16:29 Insu Yun [this message]
2015-10-15 16:29 ` [PATCH 2/2] " Insu Yun
2015-10-15 18:42 ` isdn
2015-10-16 6:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444926568-29572-1-git-send-email-wuninsu@gmail.com \
--to=wuninsu@gmail.com \
--cc=insu@gatech.edu \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=taesoo@gatech.edu \
--cc=yeongjin.jang@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®