From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753924AbbJOQ31 (ORCPT ); Thu, 15 Oct 2015 12:29:27 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:36768 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753673AbbJOQ3X (ORCPT ); Thu, 15 Oct 2015 12:29:23 -0400 From: Insu Yun To: isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, Insu Yun Subject: [PATCH 2/2] isdn: correctly check failed allocation Date: Thu, 15 Oct 2015 12:29:28 -0400 Message-Id: <1444926568-29572-2-git-send-email-wuninsu@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1444926568-29572-1-git-send-email-wuninsu@gmail.com> References: <1444926568-29572-1-git-send-email-wuninsu@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since skb_clone is memory allocation, it could be failed when lack of resource. Therefore, return value of skb_clone needs to be checked and handle error. Signed-off-by: Insu Yun --- drivers/isdn/mISDN/layer2.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c index 949cabb..888c610 100644 --- a/drivers/isdn/mISDN/layer2.c +++ b/drivers/isdn/mISDN/layer2.c @@ -1509,6 +1509,12 @@ l2_pull_iqueue(struct FsmInst *fi, int event, void *arg) } nskb = skb_clone(skb, GFP_ATOMIC); + if (!nskb) { + printk(KERN_WARNING "%s: no skb mem in %s\n", + mISDNDevName4ch(&l2->ch), __func__); + return; + } + p1 = skb_headroom(nskb); if (p1 >= i) memcpy(skb_push(nskb, i), header, i); -- 1.9.1