From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753288AbbJQQer (ORCPT ); Sat, 17 Oct 2015 12:34:47 -0400 Received: from mail-bn1on0117.outbound.protection.outlook.com ([157.56.110.117]:11139 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752856AbbJQQd3 (ORCPT ); Sat, 17 Oct 2015 12:33:29 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none;freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; From: "J. German Rivera" To: , , , CC: , , , , , , , , , , , , "J. German Rivera" Subject: [PATCH v3 10/12] staging: fsl-mc: Fixed WARN_ON() in fsl_mc_resource_pool_remove_device Date: Sat, 17 Oct 2015 11:18:22 -0500 Message-ID: <1445098704-11708-11-git-send-email-German.Rivera@freescale.com> X-Mailer: git-send-email 2.3.3 In-Reply-To: <1445098704-11708-1-git-send-email-German.Rivera@freescale.com> References: <1445098704-11708-1-git-send-email-German.Rivera@freescale.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD013;1:Tp/qMwPe6XnAJUKE0VnhKnGa2OhGPIDRmCJFcsKra0ADdA1fAUTfaGC/k2PJG7tdUPKFrVq4OvCz57jSrdc9F581Zn0b3E/XxOmMH/wn5AfqJlbr4kh9Yg2tpW6gI7k2V71OEQ/eMANZ0OzLtMgS7oTiqhxlaD5fsKY4eFkGOaK1ajwF1hH2rfzs1FfTuLLBlB+fg7nHIy9eFM4VMkZ+Vzy/sXDjOwMfRQW7HR26b6Y67XmCpe1UGqt1CXYgAlPlKGH7wTvKG+pCCV1CxM8nill2C3+EVAMwenXui7mURwCcdKbNeQ4d1p3eYd0Gm9M6b2+C6WhMvopcenXLTrchq5eYnndtHJDnMiazN9ej5V1w9UBeCCorvjWf1qskE4/lZ7JNOAgRzGROyW202N4d6A== X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(19580405001)(46102003)(50226001)(19580395003)(36756003)(77096005)(189998001)(2950100001)(5007970100001)(105606002)(6806005)(87936001)(50466002)(48376002)(106466001)(85426001)(104016004)(107886002)(76176999)(229853001)(64706001)(47776003)(50986999)(86362001)(5001960100002)(81156007)(5003940100001)(5008740100001)(97736004)(92566002)(5001770100001)(5001920100001)(2201001)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR03MB504;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB504;2:8jCka3v6wCiqjb6mh1DYMANRDmgGrEl5MCqTo1OiZPfAZ5LpQ6sKynLyJfZc7CWlHL6kntn7qoeTdoe542HRRcly0243z3ay8CNQLUCd5aBq0HNtKcVavNO8tAtF/iUgSSCBFc5yRFpSAHcv/FkG/U+/NdiX/9bwW0ETJw73YOs=;3:WCZKMspCWJozOMKXC3Mov0V4pFbgwbciJfsGAuGwDz6dkfkNbpSMkGxaJtgFa959SR0sIvFqd7dqBa1cN8fG4jna3Yh8zFyLXi4YFRRiIyrw3/z+608f5DtfoVNtdGtXMQ4GhqrNcqOQuFMxU8MROyQT5rF6abFdXq//ei0yzkzKngafN7n+xCfhku9ivZIyBB8E84eTW6L7p8+9ycyVbstHbGt6YIb7fWMjz2JOPTw=;25:Sm7QNl3gUopRQT5m8bfD6Jp25Eg5ap5IvyVtdaf3VeYnGC6J4dBjlab13B1fX0T9ep+9pNcKnjRZNivEPU266pZwXz9nqe3eQ/E7sLKA5gSR7gGMtt9u+aqVcuyyYPgWxzWR7dlXWKGcVltlkLMhs9YbKI/JQ295ei1kQi5N+8Xp5Fu497wl42iTHdrKO1U9UrAcWWc5JV1BTBJQzzbb94i7Q6ilRJwSrp34lSFUPHpH0zU6Spoy7GxOFCXdgCJWgQ63Y0BkKCobKk0XZbvNYg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB504; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB504;20:T4BjtsLlyGm/AcYiH6eE0Vah/PxxOeRYJPoqa9NIXA5AgWh6oVRxGwqTdvd6kY7XA9NhbaMe8X6t1c88jfb6gS9zX0q51sZTkpS3bkdYrxvoYKMU1s4BDcomrlD/i2FSyK/B2CL1ySMlp4k1FX1xLHGqjkbwxKj7VJms7N/7LucVnmpkl7TeAGy7TWgr3IGHDJlntpVFMTYxcdLNjlWydk//kN2dhjXpPC/0XPBMz+XzThndAGbgeIMNFOAgc/vd/baLno7PbNjF/fbc2HIvhOv1Eb3tlO1nHKl6Lx7i7BHD/Iqg7IiAIMrAFbQQjPuKnlkcgJ5N9G+oCBjyTiIGFvUwwisWWC/gkD2toTpdL8c=;4:UdgkdzsA0IyZL+hmB+YJyIHB5hnBB17ymKkqXRjiABJmdm8Lkf0hIkyjs037M2V4BWR9OhqOZT+dEWcOsElxCVbN7IG4J5tHh0Mo+900Wafys1/h/ybDwnzt+xeQna+xRi0XjFfZt7D76OazalD570QyF5H0KqzotuvwO1aObAulO5Mi3F1//H7sRTTE3b+BgannpaDhDwh2RZ7AOb+o0F775MHqansPZoyjbkC20ukd3sxirDEV8hgTUcVqZ2M2KR55UhTIMpYIWNPhp4plxzOXhPVnSoIg8n/hzWTUr3aOMigLVlvoVyivglFN5c2hfX4Vg7vOOdGM3e+qrmu1BQyCxwpS7LTCUMWp3dKlkLU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:BLUPR03MB504;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB504; X-Forefront-PRVS: 07326CFBC4 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR03MB504;23:M3kmGXcmRArWm87/kVdok09EJPvySDlV8+2ngS9IB0?= =?us-ascii?Q?xo+vE7BkojsQd12NWCefMfeA0fhh9hz593xo6ZOm0MN3nPiDaz37huvcDfeR?= =?us-ascii?Q?yXQjzTDVv+Nyng7aDDXIwkaEHXrsiLZCgFN5/mwcB28QFVnpjDWr3XmxbtmO?= =?us-ascii?Q?bxnwCRN93ykysVgZuGZ/RamtCvYZWVUHKdpmmFsIl/fYjGEK13lHjIucKWIF?= =?us-ascii?Q?XTknjpkWJ0JaSwjZ3yUN7Yo13i/l3k1bkRCPMY++OZUGFbrFJ3qh/c6oL3HC?= =?us-ascii?Q?I/NcOAjtCd9RNT/qNkhdlqgi8XDxQLOwV6Fx2aUCwkOK6xM8elW18ZcEjQnP?= =?us-ascii?Q?K7d3Waz38hQpyy1NqYBdmllfzJ65VAgBZqRs9GHKsD/zRKV1uOoIqzoPbmWy?= =?us-ascii?Q?ykgNIZicwjLLb5fsjwnN081Qk96xGJ8E4JCNipOZYlpXS/WvwAATOi0BUb6S?= =?us-ascii?Q?g7BRFgnOtU7PhH9c+0+N36Ne6rXrPBon7H2mBcsIZu4gcAVvufmSY9owyZoM?= =?us-ascii?Q?5vWi0O8YtZBxfschJGFCTyF8w3lfgeWWFv2MvSNDysRXlnbRd6MEph5xam2a?= =?us-ascii?Q?eDdLUR+3nnas/aRsNzeUye+VW1AuI+kd1gxdwpzvuef8NJTncBPq3zVOpBlk?= =?us-ascii?Q?Ny03zJjMA/Es5DQQ3pAlST/ddm/JCzUlwBBucwURLYHM8FuiAqnbU4JzTCdB?= =?us-ascii?Q?L05Ih7UcJj+Jwk28e/7wyNMkCZgN3RnHXAaQDgJEaBKoRwU8k4ECQ13Abi9j?= =?us-ascii?Q?Y6k/NabeGxOuX2Tdgeote5dS4fBey5q4EA//QOeY9x+4xCMC5bPPlSVQpNnD?= =?us-ascii?Q?z1PYmwIwH7fQHG9FPJfZ0zXVfX5r7YUp5WAWCnM4OMpAto+jJVLGy9hp7BWY?= =?us-ascii?Q?k8oMblbICMtFICT43cZIHJ9CGilqkweuSpP2OK+lujVEtnvJPxvkAKr+PKlR?= =?us-ascii?Q?beq5SyjxJAfSVMr/qI/AdvjepcM0dzzwasXJX2A//9LXeojAGzlmqT4W7yH+?= =?us-ascii?Q?c0K1YMhNOOBr/GicTA0agz9Pt/6D15CoW+UBNb+cfdn7LB25jr3jmy7Sbv0p?= =?us-ascii?Q?BzQxPo8923i/F32WXdGQ7Fd2kBFy3+sEIs3WZKoPA2agslf8VnWiUCDGBJr4?= =?us-ascii?Q?5fCRBD6IY=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB504;5:m1YXOBrLKzselpyZxA1zsJDxTlqu+w+WWa9MGzZELfS76lNf6e8RYblqVRNZDyGIB8BSOZOdXfug3jyt2JbyLhDsy/D8rjf+1Zazc3T/sQig9t4noBlITtSSLBN+kLCgctK37XNToUGLHekU/tOqog==;24:96gF/66BJfK+weHqxzwYjB7FlFavDFN2tfhzsXaS2JIccQoDePqeQWJm+avz/4Q7VLPubMPYuQK+pmAqb4g+Pw5E7U8h6ZxF3rxqJqFaosI=;20:0Ioegw3OCV0mm3z3ylqS09VEk00ntramYc8AengKPRGd7CsLTTc8jYFuRG8Tvb7BYB/m3fDmdqBjDuJqxkv9GA== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2015 16:33:25.8564 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB504 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Check that resource is not NULL before de-referencing it. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: - Added missing signed-off-by Changes in v2: none drivers/staging/fsl-mc/bus/mc-allocator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c b/drivers/staging/fsl-mc/bus/mc-allocator.c index a45293b..88d1857 100644 --- a/drivers/staging/fsl-mc/bus/mc-allocator.c +++ b/drivers/staging/fsl-mc/bus/mc-allocator.c @@ -111,7 +111,7 @@ static int __must_check fsl_mc_resource_pool_remove_device(struct fsl_mc_device goto out; resource = mc_dev->resource; - if (WARN_ON(resource->data != mc_dev)) + if (WARN_ON(!resource || resource->data != mc_dev)) goto out; mc_bus_dev = to_fsl_mc_device(mc_dev->dev.parent); -- 2.3.3