From: David Howells <dhowells@redhat.com>
To: Josh Triplett <josht@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] [afs] Add lock annotations to afs_proc_cell_servers_{start,stop}
Date: Wed, 26 Jul 2006 15:22:30 +0100 [thread overview]
Message-ID: <14452.1153923750@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <1153787433.31581.41.camel@josh-work.beaverton.ibm.com>
Josh Triplett <josht@us.ibm.com> wrote:
> afs_proc_cell_servers_start acquires a lock, and afs_proc_cell_servers_stop
> releases that lock. Add lock annotations to these two functions so that
> sparse can check callers for lock pairing, and so that sparse will not
> complain about these functions since they intentionally use locks in this
> manner.
Looks reasonable, though I'm surprised you can get this sort of checking to
work in sparse.
Acked-By: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2006-07-26 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 0:30 Josh Triplett
2006-07-26 14:22 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14452.1153923750@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=josht@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®