From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753528AbbJSIVW (ORCPT ); Mon, 19 Oct 2015 04:21:22 -0400 Received: from mail-bl2on0063.outbound.protection.outlook.com ([65.55.169.63]:50336 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752920AbbJSIUA (ORCPT ); Mon, 19 Oct 2015 04:20:00 -0400 Authentication-Results: spf=softfail (sender IP is 66.35.236.227) smtp.mailfrom=altera.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=altera.com; From: Ley Foon Tan To: Bjorn Helgaas , Russell King , Marc Zyngier CC: Arnd Bergmann , Dinh Nguyen , , , , , , Ley Foon Tan , , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , Lorenzo Pieralisi Subject: [PATCH v10 4/6] pci: altera: Add Altera PCIe MSI driver Date: Mon, 19 Oct 2015 16:19:26 +0800 Message-ID: <1445242768-4423-5-git-send-email-lftan@altera.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1445242768-4423-1-git-send-email-lftan@altera.com> References: <1445242768-4423-1-git-send-email-lftan@altera.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD017;1:eW9Nz72y7XRpwmhhGLhBxld2pd5/lbMnnuJcosD6J6AZZUiTW3HZSorY40OB3xV57tIred89wQNvrfyrEF5TPbWjCxfuMtTztBRQihcR19TTUyGN1ebesfcxhR6FYEOw30QZxqG1H0J4ARskzBRuyYyXoZD00fiB0E46r/ZmivT3KpqfOf78MXqr8VvnL+hFELt76DiYtCDl5Qi2pn+5g3hU45QsTcDKs3UMHYlXfSyR60TvyxNNBwbH5lI4aXpMVOhQlCc9ip2spMr3/CwihDEYjqqoMWGLWg1ItIpqSGR0jNnwQOp9sRWgPioexVXxenDKoXUK2vlnMkyp0Pl5i1KmgtvfClgmZ7tJVlEHJ52ol0Mu3iZvQKfdOlHMcVek X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(189002)(199003)(97736004)(5001770100001)(81156007)(5008740100001)(189998001)(19580395003)(19580405001)(48376002)(92566002)(33646002)(50466002)(87936001)(5001960100002)(76176999)(50986999)(42186005)(229853001)(105596002)(86362001)(106466001)(50226001)(46102003)(47776003)(64706001)(36756003)(5007970100001)(15975445007)(6806005)(5003940100001)(11100500001)(2950100001)(7099028)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1495;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:SoftFail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1495;2:yLTopbwV2scIIRLSu3ZGKeqvpkwV1z2E7BW4N7j6xGGNxltUyfOn86n8VoL0UIjyZpU5k/im/awM7x7gXh0mWGHjv4o1BofYyu2BwMVi1Xu4IJWyGLo7sFU1L/2GJBxRucY1WyIVOg+cWU1GBuuzz4+vtx8C71O8jpoo0IvElP4=;3:83oXgUi2sSZ8IID4O32CyHnIdVDT2XWDM9PqdGnb5o9g8crrvns9U6YNAxjUVHml5FA8LUTIHTaWMXyz7cEg62nZeuzp2bRr+DsNs07zYC8bkY6GYBA/WaU96o41ahasgQTgxZZeaL5L2tXPCTTw7dwVGiXUxkdwsOLemco3VaH9to6oHC0Vq9r/trlj67uG2bcsoefM4drXjtNvVeX9WLnvKXPOXvly6GoG9O94JhA=;25:K75YEg4XgMs9CMD5oBtyhsTNGrjaFFRG3Z78TDqQ/DV1SHV5k1S2g429E4B8ljtbqdQx4FbdrooHTccvHoHdLD6cc5DXmJo9BtT0fqsT9hRedNYrR+rCorRa7eJEG81Lmv/81bmHkaSvnZC3D9GRXCotE4pIAquJY3UDplfkdfW2tokCvIdVg8euVxp1tovMO7SjQjNt7gh0gd7clPazq3GY8TXnDH2Um0Vk3auuJexFU6kX4yTDWhEsZUgebWF4XpgScqjfVjatBpToFmZDtg==;20:A3tYE3bbp4ZUkO0+GSmP/oThjjvlXflf9aqkxXvZauduJFZAi3k4QO3uhfoq9lOiVizxx5CX+yxwSeukXXWPeflt9Eo4glvzU37JQf/n/GzQqU/uEPWKwpR+q/wZAGLb3oWl6KmRRzWIB8lzq8M0wP39PFS0FLpiyITE9F6wlW0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1495; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001);SRVR:BN3PR03MB1495;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1495; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1495;4:8v0Frg8xSC86Ra3Ma0XWQFJIGxZx/4rECxZpHY5esC3uj54nBFe/mzDXkMbjN+Dn8k9Xcs+PQYimhamahcMTaWgW0cPwhPbCToqx05/52gD6F8kd3xuNSvqEaHi+ujOgCc1eSqiY1Kmsktiq1cfPAfkIRE/6cBcCaOJqU/725ZEVbkxFT54narYHSBl34z2LwZQZxC9G9GSUjycRIatOw1v6e+XuelFhb35O3w0FyKamMbkS0FRNmlWNcW8C9GX/LFamT5LhO572H2qfg4Vwi2z6O7InwlnCzE3l/1vHXTqgP8ecpYANVZjqU23VEMZ1EbWjwwWEy14vXPvPbflxPoveG5TiqJNQDBuHYvU/l2o= X-Forefront-PRVS: 07349BFAD2 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR03MB1495;23:WfMtwPjMFGK/9jzhaYlPvJslW3oSDywp8tIWcc4ap?= =?us-ascii?Q?H4Uq9iA3C6g4Ogwj32/9GGyeqPp2wV23Wo2DCt5sNvVYpv/oEI7FAhrpSZaS?= =?us-ascii?Q?ZsV0RGoLQcfKioDXo6cBNLjq4/HmL+EGmMopAneHuBm2IQrsFu77TZcTUTM9?= =?us-ascii?Q?tjcVrtto8ZeoTMWa8oiEVdWbS+M51J7GStS4390Lh/0Eoh6KoT9lwJV9kq3B?= =?us-ascii?Q?vBkM1jsVHI7ruOkbeQ3x/cN18TTVdv5YZtbWDZyM2R98dzSevzeFxvEocGO4?= =?us-ascii?Q?iktsD/kbSoPrxb41IORMkXGdiJuphK1ST6w3jQoQqw4KpD32shLyme5gR7jJ?= =?us-ascii?Q?TfT+Hzd0ldsru3XbGwysPKuF4uVPxy15nbahXXQE9Pnu5LcFhyywhUW2TAA0?= =?us-ascii?Q?vby+9E/QSOX6efXyVJVHha+jBohz9tX0AkUy1B24yOYy2x4+Unum2RrIhSM0?= =?us-ascii?Q?zCYYa/cOvIemLR1Ya5qb0i7Z8KuzEyLjMxz8e8QDce8uVmFQXiFceZGkcAdQ?= =?us-ascii?Q?2Gbz8upLdtlAs6wFYcE6QybDBj+joIHtp30SfwN4gBhKOu6QtXgvEnUd7/D4?= =?us-ascii?Q?s6kuX4d4lj6X9lJYQ1oLn9P8FF7tyAMvvRjOOLD9u8SdOYLHZdgDFJz6tlTh?= =?us-ascii?Q?rMcKc/8hYoEhZOlpHkgTc3sRYWMCEskUO7wznRqut/8rsPiUvuX0KUjqyZCw?= =?us-ascii?Q?7gwgZVLzzNtC1xlI6jCNKwrP137xU+1BwVovM3oKiMQnJEHBzc92RN/FlAPd?= =?us-ascii?Q?npTAy54HyM25+ZtYFfEU399t/nvEBqiVQxyrcYF4kRKtwmGiuDU7YS13//kZ?= =?us-ascii?Q?3xPuAkLRwD1Tup2SrTYZf9IxGKQkXTQD5w6NBSFFUh3umi4twEw5HCf+huE8?= =?us-ascii?Q?x2tMHscy/ZcGstH+ndiwKQWdAU8osAovX839yfrbJPEF40ndIeVQrMmspa09?= =?us-ascii?Q?uNx37hs0J+FAWDluphuB2nYmEqjKZb44AjyATWIf0minn8DOE0XPZ3uqWO49?= =?us-ascii?Q?eaMlaXPF51fLVnFqDpDtBnk33gnqiv+CfUBgT4hVqGOhg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1495;5:2W1PSYDR2Ltq3FYF4hKZZS1JzUoTCbFO3gYqh01KkhjVJ6kabV6msK3LJMtA3FK/OhX2aDlIyiS+AVNHeeMlczKY9b1uw6ZEvWegKXZ84F8ggYoi41moBQMTGuKphFOBAluxEQIo4vMb5GOJbfQ5yA==;24:/50OhzZR8tiKaae00sUeMX+dmMs6I/siB+pncPtIBeQuA30Why/Epg/OHX4r4TJbRLjBV14yxOEsFHttaUE+RcoQXQbRAN56BRWM01FEUKg=;20:Wx0IyB4dcnch8c8tjUGPrBIrAc9r56QUatOWIvfecrv0MTM83xPi99HpLA8NTLWCk7IkTuKZnrZfhmba//2ZXd1itLEnhRErVJvSgkcPZVdaq5EZPkBWSC/k5mz9R+pHfK2BNsa9tqtS7P6Z50ZwJvz3rRJl631TazdX7dKuHrs= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2015 08:19:57.9549 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1495 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan Reviewed-by: Marc Zyngier --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera-msi.c | 313 +++++++++++++++++++++++++++++++++++++ 3 files changed, 322 insertions(+) create mode 100644 drivers/pci/host/pcie-altera-msi.c diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index a9f6db4..35eba16 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -152,4 +152,12 @@ config PCIE_ALTERA Say Y here if you want to enable PCIe controller support on Altera FPGA. +config PCIE_ALTERA_MSI + bool "Altera PCIe MSI feature" + depends on PCI_MSI + select PCI_MSI_IRQ_DOMAIN + help + Say Y here if you want PCIe MSI support for the Altera FPGA. + This MSI driver supports Altera MSI to GIC controller IP. + endmenu diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile index 6954f76..6c4913d 100644 --- a/drivers/pci/host/Makefile +++ b/drivers/pci/host/Makefile @@ -18,3 +18,4 @@ obj-$(CONFIG_PCIE_IPROC) += pcie-iproc.o obj-$(CONFIG_PCIE_IPROC_PLATFORM) += pcie-iproc-platform.o obj-$(CONFIG_PCIE_IPROC_BCMA) += pcie-iproc-bcma.o obj-$(CONFIG_PCIE_ALTERA) += pcie-altera.o +obj-$(CONFIG_PCIE_ALTERA_MSI) += pcie-altera-msi.o diff --git a/drivers/pci/host/pcie-altera-msi.c b/drivers/pci/host/pcie-altera-msi.c new file mode 100644 index 0000000..1d8a1b6 --- /dev/null +++ b/drivers/pci/host/pcie-altera-msi.c @@ -0,0 +1,313 @@ +/* + * Copyright Altera Corporation (C) 2013-2015. All rights reserved + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program. If not, see . + */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define MSI_STATUS 0x0 +#define MSI_ERROR 0x4 +#define MSI_INTMASK 0x8 + +#define MAX_MSI_VECTORS 32 +struct altera_msi { + DECLARE_BITMAP(used, MAX_MSI_VECTORS); + struct mutex lock; /* proctect used variable */ + struct platform_device *pdev; + struct irq_domain *msi_domain; + struct irq_domain *inner_domain; + void __iomem *csr_base; + void __iomem *vector_base; + phys_addr_t vector_phy; + u32 num_of_vectors; + int irq; +}; + +static inline void msi_writel(struct altera_msi *msi, const u32 value, + const u32 reg) +{ + writel_relaxed(value, msi->csr_base + reg); +} + +static inline u32 msi_readl(struct altera_msi *msi, const u32 reg) +{ + return readl_relaxed(msi->csr_base + reg); +} + +static void altera_msi_isr(struct irq_desc *desc) +{ + struct irq_chip *chip = irq_desc_get_chip(desc); + struct altera_msi *msi; + unsigned long status; + u32 num_of_vectors; + u32 bit; + u32 virq; + + chained_irq_enter(chip, desc); + msi = irq_desc_get_handler_data(desc); + num_of_vectors = msi->num_of_vectors; + + while ((status = msi_readl(msi, MSI_STATUS)) != 0) { + for_each_set_bit(bit, &status, msi->num_of_vectors) { + /* Dummy read from vector to clear the interrupt */ + readl_relaxed(msi->vector_base + (bit * sizeof(u32))); + + virq = irq_find_mapping(msi->inner_domain, bit); + if (virq) + generic_handle_irq(virq); + else + dev_err(&msi->pdev->dev, "unexpected MSI\n"); + } + } + + chained_irq_exit(chip, desc); +} + +static struct irq_chip altera_msi_irq_chip = { + .name = "Altera PCIe MSI", + .irq_mask = pci_msi_mask_irq, + .irq_unmask = pci_msi_unmask_irq, +}; + +static struct msi_domain_info altera_msi_domain_info = { + .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | + MSI_FLAG_PCI_MSIX), + .chip = &altera_msi_irq_chip, +}; + +static void altera_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) +{ + struct altera_msi *msi = irq_data_get_irq_chip_data(data); + phys_addr_t addr = msi->vector_phy + (data->hwirq * sizeof(u32)); + + msg->address_lo = lower_32_bits(addr); + msg->address_hi = upper_32_bits(addr); + msg->data = data->hwirq; + + dev_dbg(&msi->pdev->dev, "msi#%d address_hi 0x%x address_lo 0x%x\n", + (int)data->hwirq, msg->address_hi, msg->address_lo); +} + +static int altera_msi_set_affinity(struct irq_data *irq_data, + const struct cpumask *mask, bool force) +{ + return -EINVAL; +} + +static struct irq_chip altera_msi_bottom_irq_chip = { + .name = "Altera MSI", + .irq_compose_msi_msg = altera_compose_msi_msg, + .irq_set_affinity = altera_msi_set_affinity, +}; + +static int altera_irq_domain_alloc(struct irq_domain *domain, unsigned int virq, + unsigned int nr_irqs, void *args) +{ + struct altera_msi *msi = domain->host_data; + unsigned long bit; + u32 mask; + + WARN_ON(nr_irqs != 1); + mutex_lock(&msi->lock); + + bit = find_first_zero_bit(msi->used, msi->num_of_vectors); + if (bit >= msi->num_of_vectors) { + mutex_unlock(&msi->lock); + return -ENOSPC; + } + + set_bit(bit, msi->used); + + mutex_unlock(&msi->lock); + + irq_domain_set_info(domain, virq, bit, &altera_msi_bottom_irq_chip, + domain->host_data, handle_simple_irq, + NULL, NULL); + + mask = msi_readl(msi, MSI_INTMASK); + mask |= 1 << bit; + msi_writel(msi, mask, MSI_INTMASK); + + return 0; +} + +static void altera_irq_domain_free(struct irq_domain *domain, + unsigned int virq, unsigned int nr_irqs) +{ + struct irq_data *d = irq_domain_get_irq_data(domain, virq); + struct altera_msi *msi = irq_data_get_irq_chip_data(d); + u32 mask; + + mutex_lock(&msi->lock); + + if (!test_bit(d->hwirq, msi->used)) { + dev_err(&msi->pdev->dev, "trying to free unused MSI#%lu\n", + d->hwirq); + } else { + __clear_bit(d->hwirq, msi->used); + mask = msi_readl(msi, MSI_INTMASK); + mask &= ~(1 << d->hwirq); + msi_writel(msi, mask, MSI_INTMASK); + } + + mutex_unlock(&msi->lock); +} + +static const struct irq_domain_ops msi_domain_ops = { + .alloc = altera_irq_domain_alloc, + .free = altera_irq_domain_free, +}; + +static int altera_allocate_domains(struct altera_msi *msi) +{ + msi->inner_domain = irq_domain_add_linear(NULL, msi->num_of_vectors, + &msi_domain_ops, msi); + if (!msi->inner_domain) { + dev_err(&msi->pdev->dev, "failed to create IRQ domain\n"); + return -ENOMEM; + } + + msi->msi_domain = pci_msi_create_irq_domain(msi->pdev->dev.of_node, + &altera_msi_domain_info, msi->inner_domain); + if (!msi->msi_domain) { + dev_err(&msi->pdev->dev, "failed to create MSI domain\n"); + irq_domain_remove(msi->inner_domain); + return -ENOMEM; + } + + return 0; +} + +static void altera_free_domains(struct altera_msi *msi) +{ + irq_domain_remove(msi->msi_domain); + irq_domain_remove(msi->inner_domain); +} + +static int altera_msi_remove(struct platform_device *pdev) +{ + struct altera_msi *msi = platform_get_drvdata(pdev); + + msi_writel(msi, 0, MSI_INTMASK); + irq_set_chained_handler(msi->irq, NULL); + irq_set_handler_data(msi->irq, NULL); + + altera_free_domains(msi); + + platform_set_drvdata(pdev, NULL); + return 0; +} + +static int altera_msi_probe(struct platform_device *pdev) +{ + struct altera_msi *msi; + struct device_node *np = pdev->dev.of_node; + struct resource *res; + int ret; + + msi = devm_kzalloc(&pdev->dev, sizeof(struct altera_msi), + GFP_KERNEL); + if (!msi) + return -ENOMEM; + + mutex_init(&msi->lock); + msi->pdev = pdev; + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "csr"); + if (!res) { + dev_err(&pdev->dev, + "no csr memory resource defined\n"); + return -ENODEV; + } + + msi->csr_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(msi->csr_base)) { + dev_err(&pdev->dev, "failed to map csr memory\n"); + return PTR_ERR(msi->csr_base); + } + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, + "vector_slave"); + if (!res) { + dev_err(&pdev->dev, + "no vector_slave memory resource defined\n"); + return -ENODEV; + } + + msi->vector_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(msi->vector_base)) { + dev_err(&pdev->dev, "failed to map vector_slave memory\n"); + return PTR_ERR(msi->vector_base); + } + + msi->vector_phy = res->start; + + if (of_property_read_u32(np, "num-vectors", &msi->num_of_vectors)) { + dev_err(&pdev->dev, "failed to parse the number of vectors\n"); + return -EINVAL; + } + + ret = altera_allocate_domains(msi); + if (ret) + return ret; + + msi->irq = platform_get_irq(pdev, 0); + if (msi->irq <= 0) { + dev_err(&pdev->dev, "failed to map IRQ: %d\n", msi->irq); + ret = -ENODEV; + goto err; + } + + irq_set_chained_handler_and_data(msi->irq, altera_msi_isr, msi); + platform_set_drvdata(pdev, msi); + + return 0; + +err: + altera_msi_remove(pdev); + return ret; +} + +static const struct of_device_id altera_msi_of_match[] = { + { .compatible = "altr,msi-1.0", NULL }, + { }, +}; + +static struct platform_driver altera_msi_driver = { + .driver = { + .name = "altera-msi", + .of_match_table = altera_msi_of_match, + }, + .probe = altera_msi_probe, + .remove = altera_msi_remove, +}; + +static int __init altera_msi_init(void) +{ + return platform_driver_register(&altera_msi_driver); +} + +subsys_initcall(altera_msi_init); + +MODULE_AUTHOR("Ley Foon Tan "); +MODULE_DESCRIPTION("Altera PCIe MSI support"); +MODULE_LICENSE("GPL v2"); -- 1.8.2.1