From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754389AbbJSPXC (ORCPT ); Mon, 19 Oct 2015 11:23:02 -0400 Received: from mail-yk0-f171.google.com ([209.85.160.171]:36274 "EHLO mail-yk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753820AbbJSPXA (ORCPT ); Mon, 19 Oct 2015 11:23:00 -0400 From: Insu Yun To: erik.andren@gmail.com, hdegoede@redhat.com, mchehab@osg.samsung.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu, Insu Yun Subject: [PATCH] m5602: correctly check failed thread creation Date: Mon, 19 Oct 2015 15:24:13 +0000 Message-Id: <1445268253-23157-1-git-send-email-wuninsu@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since thread creation can be failed, check return value of kthread_create and handle an error. Signed-off-by: Insu Yun --- drivers/media/usb/gspca/m5602/m5602_s5k83a.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c index bf6b215..76b40d1 100644 --- a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c +++ b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c @@ -221,6 +221,10 @@ int s5k83a_start(struct sd *sd) to assume that there is no better way of accomplishing this */ sd->rotation_thread = kthread_create(rotation_thread_function, sd, "rotation thread"); + if (IS_ERR(sd->rotation_thread)) { + err = PTR_ERR(sd->rotation_thread); + goto fail; + } wake_up_process(sd->rotation_thread); /* Preinit the sensor */ @@ -234,9 +238,11 @@ int s5k83a_start(struct sd *sd) data[0]); } if (err < 0) - return err; + goto fail; return s5k83a_set_led_indication(sd, 1); +fail: + return err; } int s5k83a_stop(struct sd *sd) -- 1.9.1