From: Insu Yun <wuninsu@gmail.com>
To: hdegoede@redhat.com, mchehab@osg.samsung.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu,
changwoo@gatech.edu, Insu Yun <wuninsu@gmail.com>
Subject: [PATCH] gspca: correctly checked failed allocation
Date: Mon, 19 Oct 2015 16:43:14 +0000 [thread overview]
Message-ID: <1445272994-25312-1-git-send-email-wuninsu@gmail.com> (raw)
create_singlethread_workqueue can be failed in memory pressue.
So, check return value and return -ENOMEM
Signed-off-by: Insu Yun <wuninsu@gmail.com>
---
drivers/media/usb/gspca/sq905.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/usb/gspca/sq905.c b/drivers/media/usb/gspca/sq905.c
index a7ae0ec..b1c25d9a 100644
--- a/drivers/media/usb/gspca/sq905.c
+++ b/drivers/media/usb/gspca/sq905.c
@@ -392,6 +392,8 @@ static int sd_start(struct gspca_dev *gspca_dev)
}
/* Start the workqueue function to do the streaming */
dev->work_thread = create_singlethread_workqueue(MODULE_NAME);
+ if (!dev->work_thread)
+ return -ENOMEM;
queue_work(dev->work_thread, &dev->work_struct);
return 0;
--
1.9.1
next reply other threads:[~2015-10-19 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 16:43 Insu Yun [this message]
2015-10-20 8:20 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445272994-25312-1-git-send-email-wuninsu@gmail.com \
--to=wuninsu@gmail.com \
--cc=changwoo@gatech.edu \
--cc=hdegoede@redhat.com \
--cc=insu@gatech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=taesoo@gatech.edu \
--cc=yeongjin.jang@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®