mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	mike.rapoport@gmail.com, Larry.Finger@lwfinger.net,
	florian.c.schilhabel@googlemail.com, carlos@cgarcia.org,
	sudipm.mukherjee@gmail.com, punitvara@gmail.com,
	vthakkar1994@gmail.com, jteki@openedev.com, Julia.Lawall@lip6.fr,
	shivanib134@gmail.com, luca@lucaceresoli.net,
	mahfouz.saif.elyazal@gmail.com, cristina.opriceana@gmail.com,
	fabf@skynet.be, stillcompiling@gmail.com,
	Luis de Bethencourt <luisbg@osg.samsung.com>
Subject: [PATCH v2 0/3] staging: code cleanup
Date: Mon, 19 Oct 2015 18:10:54 +0100	[thread overview]
Message-ID: <1445274654-10103-1-git-send-email-luisbg@osg.samsung.com> (raw)

Hi,

I initially submitted a patch to remove all the explicit boolean comparisons
in rtl8712. These code changes included two instances where braces needed to be
added to clean the output of checkpatch.pl on this patch.

Mike Rapaport correctly pointed out those changes had to go in a separate
patch. Not wanting to only fix those two instances, but cover the whole
rtl8712, I've added a second patch fixing these.

The checkpatch.pl of the second patch included some checks about needing spaces
around operands. Including this fix as well for a nicer checkpatch.pl output.
Plus also making it cover all rtl8712.

In other words, these are a series of recursive cleanup changes.

Thanks for the review Mike,
Luis


Luis de Bethencourt (3):
  staging: rtl8712: Remove boolean comparisons
  staging: rtl8712: braces should be used on all arms
  staging: rtl8712: spaces preferred around operands

 drivers/staging/rtl8712/hal_init.c            |  11 +-
 drivers/staging/rtl8712/ieee80211.c           |  36 ++---
 drivers/staging/rtl8712/mlme_linux.c          |   2 +-
 drivers/staging/rtl8712/os_intfs.c            |   6 +-
 drivers/staging/rtl8712/rtl8712_cmd.c         |  27 ++--
 drivers/staging/rtl8712/rtl8712_efuse.c       | 138 ++++++++++---------
 drivers/staging/rtl8712/rtl8712_io.c          |   6 +-
 drivers/staging/rtl8712/rtl8712_led.c         | 187 +++++++++++++-------------
 drivers/staging/rtl8712/rtl8712_recv.c        |  53 ++++----
 drivers/staging/rtl8712/rtl8712_xmit.c        |  74 +++++-----
 drivers/staging/rtl8712/rtl871x_cmd.c         |  25 ++--
 drivers/staging/rtl8712/rtl871x_eeprom.c      |  22 +--
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 153 +++++++++++----------
 drivers/staging/rtl8712/rtl871x_ioctl_rtl.c   |  53 +++++---
 drivers/staging/rtl8712/rtl871x_ioctl_set.c   |  33 ++---
 drivers/staging/rtl8712/rtl871x_mlme.c        | 144 ++++++++++----------
 drivers/staging/rtl8712/rtl871x_mlme.h        |   2 +-
 drivers/staging/rtl8712/rtl871x_mp.c          |  23 ++--
 drivers/staging/rtl8712/rtl871x_mp_ioctl.c    |  38 +++---
 drivers/staging/rtl8712/rtl871x_pwrctrl.c     |   6 +-
 drivers/staging/rtl8712/rtl871x_recv.c        |  70 +++++-----
 drivers/staging/rtl8712/rtl871x_security.c    | 133 +++++++++---------
 drivers/staging/rtl8712/rtl871x_sta_mgt.c     |  10 +-
 drivers/staging/rtl8712/rtl871x_xmit.c        |  95 ++++++-------
 drivers/staging/rtl8712/usb_halinit.c         |  13 +-
 drivers/staging/rtl8712/usb_intf.c            |  17 +--
 drivers/staging/rtl8712/usb_ops.c             |  20 +--
 drivers/staging/rtl8712/usb_ops_linux.c       |  20 +--
 drivers/staging/rtl8712/xmit_linux.c          |   4 +-
 29 files changed, 753 insertions(+), 668 deletions(-)

-- 
2.5.3


             reply	other threads:[~2015-10-19 17:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 17:10 Luis de Bethencourt [this message]
2015-10-19 17:14 ` [PATCH v2 1/3] staging: rtl8712: Remove boolean comparisons Luis de Bethencourt
2015-10-22 19:05   ` Dan Carpenter
2015-10-24 11:56     ` Luis de Bethencourt
2015-10-19 17:15 ` [PATCH v2 2/3] staging: rtl8712: braces should be used on all arms Luis de Bethencourt
2015-10-19 17:16 ` [PATCH v2 3/3] staging: rtl8712: spaces preferred around operands Luis de Bethencourt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445274654-10103-1-git-send-email-luisbg@osg.samsung.com \
    --to=luisbg@osg.samsung.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=Larry.Finger@lwfinger.net \
    --cc=carlos@cgarcia.org \
    --cc=cristina.opriceana@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fabf@skynet.be \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jteki@openedev.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@lucaceresoli.net \
    --cc=mahfouz.saif.elyazal@gmail.com \
    --cc=mike.rapoport@gmail.com \
    --cc=punitvara@gmail.com \
    --cc=shivanib134@gmail.com \
    --cc=stillcompiling@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=vthakkar1994@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®