From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751793AbbJSXdB (ORCPT ); Mon, 19 Oct 2015 19:33:01 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:35883 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750814AbbJSXc7 (ORCPT ); Mon, 19 Oct 2015 19:32:59 -0400 Message-ID: <1445297565.2561.8.camel@decadent.org.uk> Subject: Re: [PATCH 4.2 022/258] toshiba_acpi: Fix hotkeys registration on some toshiba models From: Ben Hutchings To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Azael Avalos , Darren Hart Date: Tue, 20 Oct 2015 00:32:45 +0100 In-Reply-To: <20151018014731.316677835@linuxfoundation.org> References: <20151018014729.976101177@linuxfoundation.org> <20151018014731.316677835@linuxfoundation.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-izPNi+mowNfTdqs5/BGe" X-Mailer: Evolution 3.18.0-2+b1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.247 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-izPNi+mowNfTdqs5/BGe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2015-10-17 at 18:55 -0700, Greg Kroah-Hartman wrote: > 4.2-stable review patch.=C2=A0=C2=A0If anyone has any objections, please = let me know. >=20 > ------------------ >=20 > From: Azael Avalos >=20 > commit 53147b6cabee5e8d1997b5682fcc0c3b72ddf9c2 upstream. >=20 > Commit a2b3471b5b13 ("toshiba_acpi: Use the Hotkey Event Type function > for keymap choosing") changed the *setup_keyboard function to query for > the Hotkey Event Type to help choose the correct keymap, but turns out > that here are certain Toshiba models out there not implementing this > feature, and thus, failing to continue the input device registration and > leaving such laptops without hotkey support. >=20 > This patch changes such check, and instead of returning an error if > the Hotkey Event Type is not present, we simply inform userspace about it= , > changing the message printed from err to notice, making the function > responsible for registering the input device to continue. [...] But then this function proceeds without events_type being initialised at all, with unpredictable results. =C2=A0This doesn't look like a proper fix. Ben. --=20 Ben Hutchings The first rule of tautology club is the first rule of tautology club. --=-izPNi+mowNfTdqs5/BGe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAViV9nee/yOyVhhEJAQqS9hAAoQ2kfe629Kztz7LtWaj1w5m3GiFDisrK DSyk07K3MXTA8NkvYXvXe8ewpY1Av5cCZYj1FGiNBCLjeX8c3MsuuEb6MYeYpXpi lF4zn7R3j16N6S9B0lgYeqT54Mx99lY0qOC8JXeAHWNo4ESZjf+jb+b1TjtDJV5e Xc6S9/rVOOUee3Ig5b9WX+8GR+t1kTnHcSdh/YIvHdM0iq1lNVqToYnovgg6Gj36 aeJHmeDxCwlhlC2mQiWx9mPAJKSBQ3rMz/2JQZNign/cNjCQ4UPdL9df5rjmqBvx pGZAnqwJir7iNUTYD2EzgiJ3+LnwuNgN/bJEYHqcZrpBc6kewqz+kzZjpjCLQcGu EX+j/Smh+ED3011weeBYb+x7P36HcSiKcqSgjgGkq1fXubuuY/j0ezDpNYHXv7v+ dh8qIHC906hlQTLhEw7jDR6VQmXkVx6fJdXaEixPnVqrsDLcC+AzvcZX+DKym+se pZEr9uyjWpMhQRiLlywsFteIAVuLarbsgoZPEtAZb4paxTsFLCWQRwUF/5ZFmKGj aPa5LXS5YBcPgROvXFxtVhUJ+1tYWombN6E9mEoUKx3sqA7MLvfZCRTgTXCvIZOy 9H7b7q5VkmsifYWSUoQHQoz+L53xfRjtCum2B4k8gFAXv+Oo35t5nBUacwBFuEK1 mqJYew4IXZ8= =OLLp -----END PGP SIGNATURE----- --=-izPNi+mowNfTdqs5/BGe--