From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753584AbbJTHrA (ORCPT ); Tue, 20 Oct 2015 03:47:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:34498 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753460AbbJTHq5 (ORCPT ); Tue, 20 Oct 2015 03:46:57 -0400 Message-ID: <1445327214.16404.0.camel@suse.de> Subject: Re: [PATCH] scsi: mvsas: fix misleading indentation From: Johannes Thumshirn To: Luis de Bethencourt , linux-kernel@vger.kernel.org Cc: JBottomley@odin.com, linux-scsi@vger.kernel.org, hare@suse.de, tj@kernel.org, dan.j.williams@intel.com Date: Tue, 20 Oct 2015 09:46:54 +0200 In-Reply-To: <1445287000-1370-1-git-send-email-luisbg@osg.samsung.com> References: <1445287000-1370-1-git-send-email-luisbg@osg.samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.0 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-10-19 at 21:36 +0100, Luis de Bethencourt wrote: > Fix a smatch warning: > drivers/scsi/mvsas/mv_sas.c:740 mvs_task_prep() warn: curly braces > intended? > > The code is correct, the indention is misleading. When the device is > not > ready we want to return SAS_PHY_DOWN. But current indentation makes > it > look like we only do so in the else branch of if (mvi_dev). > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > > The aim of this patch is to improve code readability, and at the same > time > silence the smatch warning. > > Thanks for the review, > Luis > >  drivers/scsi/mvsas/mv_sas.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/mvsas/mv_sas.c > b/drivers/scsi/mvsas/mv_sas.c > index 454536c..b1c5dec 100644 > --- a/drivers/scsi/mvsas/mv_sas.c > +++ b/drivers/scsi/mvsas/mv_sas.c > @@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, > struct mvs_info *mvi, int is_tmf >   mv_dprintk("device %016llx not ready.\n", >   SAS_ADDR(dev->sas_addr)); >   > - rc = SAS_PHY_DOWN; > - return rc; > + rc = SAS_PHY_DOWN; > + return rc; >   } >   tei.port = dev->port->lldd_port; >   if (tei.port && !tei.port->port_attached && !tmf) { Reviewed-by: Johannes Thumshirn