From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Seungwon Jeon <tgih.jun@samsung.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
"Barry Song" <baohua@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Sascha Hauer <s.hauer@pengutronix.de>,
Howard Chen <ibanezchen@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kristina Martsenko <kristina.martsenko@gmail.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Minda Chen <Minda.Chen@csr.com>,
Dong Aisheng <b29396@freescale.com>,
"Johan Derycke" <johan.derycke@barco.com>,
Haibo Chen <haibo.chen@freescale.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Georgi Djakov <georgi.djakov@linaro.org>,
Ivan Ivanov <ivan.ivanov@linaro.org>,
"Weijun Yang" <Weijun.Yang@csr.com>,
Kevin Hao <haokexin@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
srv_heupstream <srv_heupstream@mediatek.com>
Subject: Re: [PATCH v2 0/9] Add tune support of Mediatek MMC driver
Date: Thu, 22 Oct 2015 10:18:49 +0800 [thread overview]
Message-ID: <1445480329.1593.4.camel@mhfsdcap03> (raw)
In-Reply-To: <CAPDyKFrTrR5U7QoXpiWj29bUD5SEp4ccbx8qNs9HF0cYxuqdBw@mail.gmail.com>
On Tue, 2015-10-20 at 18:41 +0200, Ulf Hansson wrote:
> On 20 October 2015 at 11:13, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> > Change in v2:
> > Drop the 400mhz and use assigned-clock-parents to instead
> > Split the original tune patch to several independent patches
> > Re-write the mmc_send_tuning()
> > Fix GPD checksum error
> > Move the HS400 setting to ops->prepare_hs400_tuning()
> > Modify SD driving settings
> >
> > Change in v1:
> > Add DT bindings for eMMC hardware reset
> > Add pinctrl of data strobe pin for HS400 mode
> > Modify eMMC driving settings
> > Add 400mhz source clock for HS400 mode
> > Add eMMC HS200/HS400 mode support
> > Add SD SDR50/SDR104 mode support
> > Add implement of tune function with CMD19/CMD21
> >
> > Chaotian Jing (9):
> > mmc: core: Add DT bindings for eMMC hardware reset support
> > mmc: dt-bindings: update Mediatek MMC bindings
> > mmc: mediatek: make cmd_ints_mask to const
> > mmc: mediatek: change the argument "ddr" to "timing"
> > mmc: mediatek: fix got GPD checksum error interrupt when data transfer
> > mmc: mediatek: add implement of ops->hw_reset()
> > mmc: mmc: extend the mmc_send_tuning()
> > mmc: mediatek: add HS400 support
> > arm64: dts: mediatek: add HS200/HS400/SDR50/SDR104 support
> >
> > Documentation/devicetree/bindings/mmc/mmc.txt | 1 +
> > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 11 +-
> > arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 27 ++-
> > drivers/mmc/core/host.c | 2 +
> > drivers/mmc/core/mmc_ops.c | 8 +-
> > drivers/mmc/host/dw_mmc-exynos.c | 4 +-
> > drivers/mmc/host/dw_mmc.c | 2 +-
> > drivers/mmc/host/dw_mmc.h | 2 +-
> > drivers/mmc/host/mtk-sd.c | 296 ++++++++++++++++++++---
> > drivers/mmc/host/sdhci-esdhc-imx.c | 6 +-
> > drivers/mmc/host/sdhci-msm.c | 2 +-
> > drivers/mmc/host/sdhci-sirf.c | 2 +-
> > include/linux/mmc/core.h | 2 +-
> > 13 files changed, 314 insertions(+), 51 deletions(-)
> >
> > --
> > 1.8.1.1.dirty
>
> I have reviewed the patches, I think they overall looks good! Some
> comments though.
>
> You need to split patch 9, the DT parts enabling hw reset shall go in
> separately.
>
Ok, will separate it at next revision.
> Regarding the hw-reset changes in patch1, patch6 and patch9, I believe
> I requested you to separate the HW reset changes from $subject
> patchset as they are unrelated, please do this.
>
As you know, the hw-reset is a part of mmc retune.
so that I add it to this series.
> Running checkpatch, it gave me warnings and errors for patch 8.
> Patch7 didn't apply to my next branch.
>
I will fix the checkpatch warnings and errors at next revision.
by the way, I tried to use "git am
0007-mmc-mmc-extend-the-mmc_send_tuning.patch" in your branch,
there was no conflict, so why couldn't apply it ?
Thx!
> Kind regards
> Uffe
prev parent reply other threads:[~2015-10-22 2:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 9:13 Chaotian Jing
2015-10-20 9:13 ` [PATCH v2 1/9] mmc: core: Add DT bindings for eMMC hardware reset support Chaotian Jing
2015-10-20 9:13 ` [PATCH v2 2/9] mmc: dt-bindings: update Mediatek MMC bindings Chaotian Jing
2015-10-20 9:13 ` [PATCH v2 3/9] mmc: mediatek: make cmd_ints_mask to const Chaotian Jing
2015-10-20 9:13 ` [PATCH v2 4/9] mmc: mediatek: change the argument "ddr" to "timing" Chaotian Jing
2015-10-20 9:13 ` [PATCH v2 5/9] mmc: mediatek: fix got GPD checksum error interrupt when data transfer Chaotian Jing
2015-10-20 9:13 ` [PATCH v2 6/9] mmc: mediatek: add implement of ops->hw_reset() Chaotian Jing
2015-10-20 9:13 ` [PATCH v2 7/9] mmc: mmc: extend the mmc_send_tuning() Chaotian Jing
2015-10-20 9:13 ` [PATCH v2 8/9] mmc: mediatek: add HS400 support Chaotian Jing
2015-10-20 9:13 ` [PATCH v2 9/9] arm64: dts: mediatek: add HS200/HS400/SDR50/SDR104 support Chaotian Jing
2015-10-20 16:41 ` [PATCH v2 0/9] Add tune support of Mediatek MMC driver Ulf Hansson
2015-10-22 2:18 ` Chaotian Jing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445480329.1593.4.camel@mhfsdcap03 \
--to=chaotian.jing@mediatek.com \
--cc=Minda.Chen@csr.com \
--cc=Weijun.Yang@csr.com \
--cc=adrian.hunter@intel.com \
--cc=b29396@freescale.com \
--cc=baohua@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=galak@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=haibo.chen@freescale.com \
--cc=haokexin@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ibanezchen@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivan.ivanov@linaro.org \
--cc=javier.martinez@collabora.co.uk \
--cc=jh80.chung@samsung.com \
--cc=johan.derycke@barco.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kristina.martsenko@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@codeaurora.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=srv_heupstream@mediatek.com \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome