From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751179AbbJVEBm (ORCPT ); Thu, 22 Oct 2015 00:01:42 -0400 Received: from filter03.dlls.pa.frontiernet.net ([199.224.80.233]:54233 "EHLO filter03.dlls.pa.frontiernet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbbJVEBk (ORCPT ); Thu, 22 Oct 2015 00:01:40 -0400 X-Originating-IP: [50.43.35.110] X-Previous-IP: 50.43.35.110 Message-ID: <1445486486.5667.33.camel@Lunix2.home> Subject: Re: [PATCH] pcnet32: fix a logic error with pci_set_dma_mask From: Don Fry To: David Miller Cc: geliangtang@163.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 21 Oct 2015 21:01:26 -0700 In-Reply-To: <20151012.053814.1870650163021801761.davem@davemloft.net> References: <20151012.053814.1870650163021801761.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-10-12 at 05:38 -0700, David Miller wrote: > From: Geliang Tang > Date: Fri, 9 Oct 2015 03:45:39 -0700 > > > pcnet32 can't work on my machine recently. It says "architecture > > does not support 32bit PCI busmaster DMA". There is a logic error > > in it: pci_set_dma_mask() return 0 means return successfully. > > > > Signed-off-by: Geliang Tang > > This driver doesn't call pci_set_dma_mask() in any of my tree(s). I failed. My system with pcnet32 boards was down with a dead power supply and a visual review was not good enough. I missed that pci_dma_supported returns 1 on success and pci_set_dma_mask returns 0 on success. The original patch needs to have the ! removed as Geliang Tang points out. Acked-by: Don Fry