From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932407AbbJVFBT (ORCPT ); Thu, 22 Oct 2015 01:01:19 -0400 Received: from mail-bl2on0064.outbound.protection.outlook.com ([65.55.169.64]:41424 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751553AbbJVFBR (ORCPT ); Thu, 22 Oct 2015 01:01:17 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; grandegger.com; dkim=none (message not signed) header.d=none;grandegger.com; dmarc=bestguesspass action=none header.from=xilinx.com; From: Kedareswara rao Appana To: , , , , , CC: , , , Subject: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite Date: Thu, 22 Oct 2015 10:16:02 +0530 Message-ID: <1445489163-11045-1-git-send-email-appanad@xilinx.com> X-Mailer: git-send-email 2.1.2 X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21892.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD011;1:4lV/7InZfvJ3nLblFjZLzyqb3RmHmLShzOL75Zr3aWFCANmzqdM2hx5QN5U9p1KnFBQmGVTSqzzRjyFZiZxX6VbDBSeYoxa28qOltx7S6wYKz1xzgdMMShOI8RdrwjQ5WeizReLt1NZfOeYpsyPAkWi8xJ6yxWMWuIsAkUGV8xoRf7IICjbcaBnJ44aGk1lIZmOXuPbGHml2dfGP8x/iuWn/4aY7Xjt5yWTYhinaXMlwjilWyUrxDosvJjSF1fVQWp632SpdhFEa4ety+9WiHE0NFjLeg70Op/yFvPor7MA2STFnU1vYoFpAqCPDDUW++uQwQdAYTKdTYyAwjAK4CU0v06e3eLqSFZroxialq4wN8GagkugAuJHHnDwxxOekqJW2jYm5ulU4JOMzDmXsMA== X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(189002)(5003940100001)(5007970100001)(46386002)(50226001)(4001450100002)(5001960100002)(106466001)(42186005)(6806005)(229853001)(103686003)(45336002)(7049001)(46102003)(36756003)(92566002)(50986999)(189998001)(19580405001)(64706001)(48376002)(86362001)(50466002)(2201001)(47776003)(5008740100001)(36386004)(5001920100001)(63266004)(19580395003)(33646002)(81156007)(90966002)(5001770100001)(52956003)(87936001)(107986001)(5001870100001)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2FFO11HUB015;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;A:1;MX:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB015;2:E8KtLFAljMrCkEHmNZPkNsCbIcb6EYI+MWuEq+58JPm1/J3waVHUItIRwIvbIwWsDxuZCNtIroLBzavy0OmW3K6lRNUpEdI3gLhDmRktfOhg6pABw+zyaEd9CIuJYW69Z8ci3S5bp0Z1fwBQB++gYeU6cdmSACDKaZgEmefenrU=;3:FBMR3PMtd+RI3bDMkwnF7dodpYxuilQ4T27g4+cpDYTG5/AS8HsU/vWaCvtQjG8s/ULbkPy3tqZN18nnZZYXqOt07L5H48BoaJTjLcJ4QoIiNTTREsViqkhPKfeCLEGLRfnNIpbCSyLuwkr4DsFQZjYOgPAjJnqPK9JRHoJQdM9uyo+/Bn0KP8h7kdyGgrkHecRKxFA4ob9mkLsfq+oJWAmUsb2lUih6ViA8uDH0NB+lH171S8bfMBSGiYD1SCPlgz9FPHGGiZgnn9XaywY4GQ==;25:BWChhHiMERbX1Ccvpb21ixg3KsBwrGe+sxh0iOZj8muxhjxs58TO2R3fsdNX0Vd9q5gZzKu6gYFkkKEdlslnsNM0x/myCxqH7UxoybY64O6pM2x2vFDwadoymyQGDOsTAO/lPkPXfIovyynuCOeK+3ADnNrOflulDbCHV1MlThEa4Hz2WVmAb98Of1p+XV/NvJLo5xxjb0YTvJIgQGYuC9CdLy4/B53wp374wgkSGwnIWh/3eW8xac3eoSvWelScYeDa5UdIrJpoRypKyISA7Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BY2FFO11HUB015; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB015;20:Ntk73c1GzPImfBV/XuL4h5QqSzpnPzuwbQ7SC7OcOjVxRkLMbxwS0YVIUK/tRyoF10drzcygVBGL8ZX6eK0geB0XfKfiVADJHvVaY7XF972hYMVHzF8EiEZ3jCmivLlJxTSj6JtN3D1Kjg3yHYumX2aQF/Ls6qrtKmh84tCFkyD/H7LTfJx+YiLSIGZPg9qva80uXwd62KPHSyIGM/R4iGQAjpkex5vrfbaAf+j/SwXEceMDQigwtfIPeZJv585WD/aFTRI61Ozhx3TW+lI/70K6FTs0ejJLvoF07FwL/GwPnNp7/KyBT07fUCb24YNJRtSQD1pARIhS94liIp5DVT4Lxb8ny361/DtLk5NPHYxAh2ndE11pXsIgo56ZAbsRIF7b/a4YteH//T1kfYTzx+jUftWKrJsR5Auxu0cp99kfaJeW0jvNJW5zuJEQl4zuGSVvCl9AHP+6Ggw+6pCUgnWaIp66qG0+sBe39Lb7XyKn8JofhHJeGnclzeoeiXQm;4:RlBrWbf05vG3JdZsr6kj8XhXUxREJcuXwUdgcD/iu9B2uPBs8ra9069rOR7gCXyCKuWmsxxCTQbo52QYJFnjHBErxyMLHwZ6USGMaqc+LeMd+DEBiNuY+sv2tpBSoIS8Z6jVhO4uXAMYES416ZY3hF8Lr2RbUzhKfziUI7fIhl3hsYybxhN5W4CRZLWJj8e9FCiQ5lV90nsrgS57/vxGsu1y8mzTghxHfA/R10b/M3rbI3sg42ygTvhaiayb7NApEVXOpFqn+uLFjmxJ+lErTay5FuLjyEpNuUJnQRU1pynGSxUygguaW4D1+WZPcFqEmYD83EihEjgW9+qWYrV0gE68IuV/9haPIc+QtuaJETQLdk/t+UTWl6O863rsq/YQVse3+g/FeMOSCE+wsDWKug== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(102215023)(10115024);SRVR:BY2FFO11HUB015;BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB015; X-Forefront-PRVS: 0737B96801 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2FFO11HUB015;23:uhAai/CUz+k5vR78s17rCdXEu4w7Cc6wcLSRaalG?= =?us-ascii?Q?MvdY3MY/6r6ZYfmaca5K9x/vlioQEZigJAKuEl2okGXE5LkTc+PdTKGHQKqF?= =?us-ascii?Q?s58854D9a0alLxjQ2K/+ChymN5pMhc/idcf0ELWwRW9jH26fbEs/V3DYvxxn?= =?us-ascii?Q?21pMiXutR8nTCiONq7it2sNZEa648NrAlgYDdxK5pzP4ddVmm8+h/jY9m5w7?= =?us-ascii?Q?UYVTtdq402X19xCcfcrlAlUijlQutuo8kBp7cGSZ6UkPM3C/yBXWRg5AdQw2?= =?us-ascii?Q?nh3EnFqr+w2fNylZYZxrVH3IgTaV/LeHOqRf4K8lQNPZPcTwT6F85g2j1Afu?= =?us-ascii?Q?wbNhSLAOuJvtJIwQg+dAoAAqM7rGeYEXRLelNPph+eIEKOsFdY0LOKLw61vT?= =?us-ascii?Q?FzVavuAvqqueOsEbEBk9DKC40ry3z/dtopi0ZoAxqw8//NvMrgcI3bkNG4Gb?= =?us-ascii?Q?F7XzfXkv6Xhxxi1S7953j8m54luY3biU+eHLXW+y82nlDgWh4TWoWCkGxOxj?= =?us-ascii?Q?AO6v9hERHmCkM5F76WvK8/PZQiaECTVhBvN1vBT6PnplrvEeue5+ndcB1vgt?= =?us-ascii?Q?6vnxsOu0DMFytU2DRLGXC68gP3mCsOEXc6CYrwHwhzvw+MPOHCc4V8gVdzY1?= =?us-ascii?Q?chCq0fKC5QNa28gF/bFIGcBoNVzaxWHxBFiFlk/ao96rS3Z0d5CFIpnn7tnV?= =?us-ascii?Q?h/+l3yYe94Not8a/1ghzLdqfnj+mF27FBHuY/8Tf4aa7bLTWJsxWXt6U2Ins?= =?us-ascii?Q?U96u4Lg8mM7JVYFvy6JSOQkAGCnoW7eOPttsa71QEHnGquPjSRMt/jQCYSF5?= =?us-ascii?Q?SaQdVuWi1BCH0vT2yUmC6Ub0EnOwjVAEg1mvryyddU6EVCx3CAUekTnqjrk1?= =?us-ascii?Q?nyjiIFF5jD1MUOeQBviy8hy7bW4m4zcuyn6/76XX//BOfVa3QiSyaLty9N0s?= =?us-ascii?Q?vdMS6i/kSuZ/KgNMu8gx81lAC+ZXeso3LYwOrMidICKjnX33ElNvZK1FkHkp?= =?us-ascii?Q?EsYw+SCgeHR4lJrnim4V4PulenbRLI2zuLTmiD1LJdEKjIB2zx1DOEkkSont?= =?us-ascii?Q?A0kt7uc4b7+LI2UrL5h/sLcYhp/V7625Ds2iwP9/JteVrhed5kzKYPvIL4ka?= =?us-ascii?Q?vBUzm3anBGjoggaF69/1rRvQdISUE/mD+gfjlurft2pflKdWp3c2HLT2oKhG?= =?us-ascii?Q?frnAaedwPqhVhB8=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB015;5:4H2X6x1+0zMqYwSJaNiXOT7UTRVSHQeEwkX0uLu6DDkK58BiIl+E94MToU/w/6JT3bQpAzZdOWodUM8YehLOWAfUq9oroKbPlfPgkpd+4iM931wN1qlKRcdwTwcbtSOxlex3uqviuMpB55F2xcqrLQ==;24:4QMbylvGN/Dvox4+f1VkhJmssYp/i28HFsiO/eJI7Jsi4fvPG/VC+DMDUlRFfL1RAbSdIQyeiSpnJLfMX8GkOFOaKd2zWEcYQo9OQHSxZz0= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2015 04:46:46.4786 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2FFO11HUB015 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver only supports memory-mapped I/O [by ioremap()], so readl/writel is actually the right thing to do, IMO. During the validation of this driver or IP on ARM 64-bit processor while sending lot of packets observed that the tx packet drop with iowrite Putting the barriers for each tx fifo register write fixes this issue Instead of barriers using writel also fixed this issue. Signed-off-by: Kedareswara rao Appana --- drivers/net/can/xilinx_can.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 6114214..055d6f3 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -170,7 +170,7 @@ static const struct can_bittiming_const xcan_bittiming_const = { static void xcan_write_reg_le(const struct xcan_priv *priv, enum xcan_reg reg, u32 val) { - iowrite32(val, priv->reg_base + reg); + writel(val, priv->reg_base + reg); } /** @@ -183,7 +183,7 @@ static void xcan_write_reg_le(const struct xcan_priv *priv, enum xcan_reg reg, */ static u32 xcan_read_reg_le(const struct xcan_priv *priv, enum xcan_reg reg) { - return ioread32(priv->reg_base + reg); + return readl(priv->reg_base + reg); } /** -- 2.1.2