From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932286AbbJVHWu (ORCPT ); Thu, 22 Oct 2015 03:22:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:48429 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910AbbJVHWt (ORCPT ); Thu, 22 Oct 2015 03:22:49 -0400 Message-ID: <1445498567.16404.18.camel@suse.de> Subject: Re: [PATCH] scsi: wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE From: Johannes Thumshirn To: Muhammad Falak R Wani , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ondrej Zary Date: Thu, 22 Oct 2015 09:22:47 +0200 In-Reply-To: <1445466207-23265-1-git-send-email-falakreyaz@gmail.com> References: <1445466207-23265-1-git-send-email-falakreyaz@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.0 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-10-22 at 03:53 +0530, Muhammad Falak R Wani wrote: > Use struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with > the goal of getting rid of this macro completely, as this macro > is deprecated. > > Signed-off-by: Muhammad Falak R Wani > --- >  drivers/scsi/wd719x.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c > index e3da1a2..2a9da2e 100644 > --- a/drivers/scsi/wd719x.c > +++ b/drivers/scsi/wd719x.c > @@ -962,7 +962,7 @@ static void wd719x_pci_remove(struct pci_dev > *pdev) >   scsi_host_put(sh); >  } >   > -static DEFINE_PCI_DEVICE_TABLE(wd719x_pci_table) = { > +static const struct pci_device_id wd719x_pci_table[] = { >   { PCI_DEVICE(PCI_VENDOR_ID_WD, 0x3296) }, >   {} >  }; Reviewed-by: Johannes Thumshirn