From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757869AbbJVO2n (ORCPT ); Thu, 22 Oct 2015 10:28:43 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34771 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756713AbbJVO2m (ORCPT ); Thu, 22 Oct 2015 10:28:42 -0400 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Adrian Hunter , Borislav Petkov , Brendan Gregg , Chandler Carruth , Frederic Weisbecker , Stephane Eranian , Wang Nan Subject: [PATCH 1/2] perf tools: Setup pager when printing usage and help Date: Thu, 22 Oct 2015 23:28:31 +0900 Message-Id: <1445524112-5201-1-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 2.6.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's annoying to see error or help message when command has many options like in perf record, report or top. So setup pager when print parser error or help message - it should be OK since no UI is enabled at the parsing time. The usage_with_options() already disables it by calling exit_browser() anyway. Cc: Adrian Hunter Cc: Borislav Petkov Cc: Brendan Gregg Cc: Chandler Carruth Cc: Frederic Weisbecker Cc: Stephane Eranian Cc: Wang Nan Signed-off-by: Namhyung Kim --- tools/perf/util/parse-options.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/parse-options.c b/tools/perf/util/parse-options.c index 8aa7922397a9..388d385df5ad 100644 --- a/tools/perf/util/parse-options.c +++ b/tools/perf/util/parse-options.c @@ -648,6 +648,8 @@ int usage_with_options_internal(const char * const *usagestr, if (!usagestr) return PARSE_OPT_HELP; + setup_pager(); + fprintf(stderr, "\n Usage: %s\n", *usagestr++); while (*usagestr && **usagestr) fprintf(stderr, " or: %s\n", *usagestr++); -- 2.6.0