From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965646AbbJVTND (ORCPT ); Thu, 22 Oct 2015 15:13:03 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33909 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbbJVTNA (ORCPT ); Thu, 22 Oct 2015 15:13:00 -0400 From: Moritz Fischer To: atull@opensource.altera.com Cc: linux-kernel@vger.kernel.org, Moritz Fischer Subject: [RFC] fpga: socfpga: Fix check of return value of devm_request_irq Date: Thu, 22 Oct 2015 12:12:47 -0700 Message-Id: <1445541167-7095-1-git-send-email-moritz.fischer@ettus.com> X-Mailer: git-send-email 2.4.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The return value should be checked for non-zero, instead of checking it being IS_ERR_VALUE(). Signed-off-by: Moritz Fischer --- drivers/fpga/socfpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c index 706b80d..27d2ff2 100644 --- a/drivers/fpga/socfpga.c +++ b/drivers/fpga/socfpga.c @@ -577,7 +577,7 @@ static int socfpga_fpga_probe(struct platform_device *pdev) ret = devm_request_irq(dev, priv->irq, socfpga_fpga_isr, 0, dev_name(dev), priv); - if (IS_ERR_VALUE(ret)) + if (ret) return ret; return fpga_mgr_register(dev, "Altera SOCFPGA FPGA Manager", -- 2.4.3