From: Caesar Wang <wxt@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
dianders@chromium.org, Eduardo Valentin <edubezval@gmail.com>,
Caesar Wang <wxt@rock-chips.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Zhang Rui <rui.zhang@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] thermal: rockchip: ensure the otp states before resetting the controller
Date: Fri, 23 Oct 2015 09:54:55 +0800 [thread overview]
Message-ID: <1445565296-31517-3-git-send-email-wxt@rock-chips.com> (raw)
In-Reply-To: <1445565296-31517-1-git-send-email-wxt@rock-chips.com>
We need the OTP pin is gpio state before resetting the TSADC controller,
since the tshut polarity will generate a high signal.
Says:
The TSHUT temperature is setting more than 80 degree, the
default tshut polarity is high.
If T > 80C, the OTP output the high signal.
If T < 80C, the OTP output the low signal.
On the moment, the tshut polarity will be low in a short period of time
if the TSADC controller is reset.
So:
If T < 80C, the OTP output the High Signal.
If T > 80C, the OTP output the Low Signal.
In some cases, the OTP pin is connected to the PMIC, maybe the PMIC can
accept the reset response time to avoid this issue.
In other words, the system will be always reboot if we
make the OTP pin is connected the others IC to control the power.
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
---
Changes in v3:
- Add the pinctrl state for in the suspend/resume.
Changes in v2: None
Changes in v1: None
drivers/thermal/rockchip_thermal.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index c89ffb2..3b8fbda 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -642,6 +642,8 @@ static int __maybe_unused rockchip_thermal_suspend(struct device *dev)
clk_disable(thermal->pclk);
clk_disable(thermal->clk);
+ pinctrl_pm_select_sleep_state(dev);
+
return 0;
}
@@ -678,6 +680,8 @@ static int __maybe_unused rockchip_thermal_resume(struct device *dev)
for (i = 0; i < ARRAY_SIZE(thermal->sensors); i++)
rockchip_thermal_toggle_sensor(&thermal->sensors[i], true);
+ pinctrl_pm_select_default_state(dev);
+
return 0;
}
--
1.9.1
next prev parent reply other threads:[~2015-10-23 1:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 1:54 [PATCH v3 0/3] fix the TSHUT issue on rockchip thermal Caesar Wang
2015-10-23 1:54 ` [PATCH v3 1/3] dt-bindings: rockchip-thermal: Add the pinctrl states in this document Caesar Wang
2015-10-23 1:54 ` Caesar Wang [this message]
2015-10-23 4:04 ` [PATCH v3 2/3] thermal: rockchip: ensure the otp states before resetting the controller Doug Anderson
2015-10-23 6:31 ` Caesar Wang
2015-10-23 6:32 ` Caesar Wang
2015-10-23 1:54 ` [PATCH v3 3/3] ARM: dts: rockchip: Add the OTP gpio pinctrl Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445565296-31517-3-git-send-email-wxt@rock-chips.com \
--to=wxt@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®