From: LABBE Corentin <clabbe.montjoie@gmail.com>
To: acme@ghostprotocols.net, al.drozdov@gmail.com,
alexander.h.duyck@redhat.com, daniel@iogearbox.net,
davem@davemloft.net, dmitry.tarnyagin@lockless.no,
dwmw2@infradead.org, edumazet@google.com, eyal.birger@gmail.com,
fw@strlen.de, gustavo@padovan.org, hannes@stressinduktion.org,
herbert@gondor.apana.org.au, jiri@resnulli.us, jmorris@namei.org,
johan.hedberg@gmail.com, kaber@trash.net, kuznet@ms2.inr.ac.ru,
marcel@holtmann.org, mst@redhat.com, pablo@netfilter.org,
samuel@sortiz.org, tom@herbertland.com, viro@zeniv.linux.org.uk,
willemb@google.com, yoshfuji@linux-ipv6.org
Cc: linux-bluetooth@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject:
Date: Fri, 23 Oct 2015 14:10:25 +0200 [thread overview]
Message-ID: <1445602236-24130-1-git-send-email-clabbe.montjoie@gmail.com> (raw)
Hello
This patch series was begun by my finding that memcpy_[to|from]_msg have
a parameter len which is an int but used as size_t in whole functions.
Without blindly changing the parameter to size_t, I have tried to see if
anywhere in linux source code, someone give a negative argument with
the following (unfinished) coccinnelle patch.
virtual report
@@
type T;
signed T i;
@@
(
memcpy_from_msg
|
memcpy_to_msg
)
(...,
- i)
+ (size_t)i)
With that I found many place where int variable is used to store unsigned values
and which could be set as size_t since there are used againt size_t
and/or given to functions that wait for size_t.
It permit also to found a bug in net/llc/af_llc.c where a size_t variable
stored error codes.
Regards
next reply other threads:[~2015-10-23 12:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 12:10 LABBE Corentin [this message]
2015-10-23 12:10 ` [PATCH 01/11] net: change len parameter type for memcpy_[to|from]_msg LABBE Corentin
2015-10-23 12:10 ` [PATCH 02/11] net: llc: fix a setting of error value to size_t LABBE Corentin
2015-10-23 12:10 ` [PATCH 03/11] net: llc: change copied to size_t in llc_ui_sendmsg LABBE Corentin
2015-10-23 12:10 ` [PATCH 04/11] net: packet: change vnet_hdr_len from int to size_t LABBE Corentin
2015-10-23 13:35 ` Michael S. Tsirkin
2015-10-23 12:10 ` [PATCH 05/11] net: irda: change chunk " LABBE Corentin
2015-10-23 12:10 ` [PATCH 06/11] net: ipv6: set the length parameter of rawv6_send_hdrinc() " LABBE Corentin
2015-10-23 12:10 ` [PATCH 07/11] net: caif: change chunk from int " LABBE Corentin
2015-10-23 12:10 ` [PATCH 08/11] net: bluetooth: change the len parameter of sco_send_frame() " LABBE Corentin
2015-10-23 12:30 ` kbuild test robot
2015-10-23 12:36 ` kbuild test robot
2015-10-23 12:40 ` kbuild test robot
2015-10-25 19:54 ` Marcel Holtmann
2015-10-23 12:10 ` [PATCH 09/11] net: ipv6: hlen could be set as size_t LABBE Corentin
2015-10-23 12:33 ` kbuild test robot
2015-10-23 12:46 ` kbuild test robot
2015-10-23 12:10 ` [PATCH 10/11] net: ipv4: " LABBE Corentin
2015-10-23 12:43 ` kbuild test robot
2015-10-23 13:08 ` David Miller
2015-10-23 13:21 ` LABBE Corentin
2015-10-23 13:51 ` David Miller
2015-10-23 12:10 ` [PATCH 11/11] crypto: algif: Change some variable to size_t LABBE Corentin
2015-11-17 14:08 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445602236-24130-1-git-send-email-clabbe.montjoie@gmail.com \
--to=clabbe.montjoie@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=al.drozdov@gmail.com \
--cc=alexander.h.duyck@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dmitry.tarnyagin@lockless.no \
--cc=dwmw2@infradead.org \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=fw@strlen.de \
--cc=gustavo@padovan.org \
--cc=hannes@stressinduktion.org \
--cc=herbert@gondor.apana.org.au \
--cc=jiri@resnulli.us \
--cc=jmorris@namei.org \
--cc=johan.hedberg@gmail.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=samuel@sortiz.org \
--cc=tom@herbertland.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willemb@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®