From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752895AbbJWU4p (ORCPT ); Fri, 23 Oct 2015 16:56:45 -0400 Received: from mail-bn1bbn0108.outbound.protection.outlook.com ([157.56.111.108]:31616 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751908AbbJWU4m (ORCPT ); Fri, 23 Oct 2015 16:56:42 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1445633780.701.228.camel@freescale.com> Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common From: Scott Wood To: Zhao Qiang-B45475 CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "lauraa@codeaurora.org" , Xie Xiaobo-R63061 , "benh@kernel.crashing.org" , Li Yang-Leo-R58472 , "paulus@samba.org" Date: Fri, 23 Oct 2015 15:56:20 -0500 In-Reply-To: References: <1444806968-4627-1-git-send-email-qiang.zhao@freescale.com> <1444806968-4627-4-git-send-email-qiang.zhao@freescale.com> <1445569799.701.142.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [192.88.168.50] X-ClientProxiedBy: BLUPR0401CA0024.namprd04.prod.outlook.com (25.162.114.162) To CY1PR03MB1487.namprd03.prod.outlook.com (25.163.17.17) X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;2:vCEZP2waqhED4vcrufa1WzNGOoX2edgNmn0Xaj0zKXOX+tEgiqc5X/iDNLkMIg6H4Yr93PX84QQJGjr148WxxMPBv5J38qW5otiZ1M/+ZS5brBEJp2dqIc5KfRuqZCehrazbMttJpyZpfPqfMqjklgSjzSSsW87CoWAPk27gqH4=;3:BJi5WYDoyaNRpuWRZOjXdyN3yNizT9nMbNx7UYQavPqCU+0+QUVaDHRve/2dGvkIYfGGSt0mQbcrtWTVaXb9PJsbZvPfrUui18ARCVEuQOgHtpnufg3m7u0HJZdJKRXIkSNRHYe2Jd/GGPrNk49/EA==;25:tAZ8z0xfIGEEukrrqKPcgzEyCvdclf6t3x5boiyFdaaCs0u6eP3oENqX5dgZ1K0u2BZR4l92Q0URohWABOfKKNykbvSJlT69auUowGRwHCq3jNZeKXRvAzMgtZJRNHcl+ujQ0S7DrDsLNZdR2UWnqmeTG65k5cztCsdTDV44fSDWCVJzu30K3T27Q6I1hOiO5O2lK67omIgcn+iNiat5I1WOnbp9fSLXoPSps1ERUchWUkSQsk/hgAp6ZeEd/z1yiLEav6S3IZQoKGIF0H2v+w== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;20:mLlg2cSlaPuTBVJPKBHRMFxBNnb9X7uacFp6gYWPpgHb927nO+RSChTRJllKNAvByEMNcpyloufDF0eSVunV9JtkeJBfrP1FT4i6RTHDpMFh78U8/rz9QDndLy9cthX4RttoEsEKUdTbmihOdYvPY6CX7pM55aN4+OOnSOXlD89/cA+QX0Rpqcb0z0UNGydeu/fGobfqzbrbG1jgJzCM9PSn7X1tMY+OEjFUhTe6158NcRMGbeadgVZ8EY1Q3k3f5exXH/I3yhiAzXkERAYka/KxTMeU1zI09vHrXkXUHvYvecgVXuBOuvqXe3jJCO8qdjVDppAVPQP7rmttbsgKYUQ4yPT/2rPoaPDo3Iqev6QKdiBBmD4lWl1NAsaXO/u22GKm3UzVeOFYxWSGWJM92js8MU5Tadz1GnxZdZp8nQs/b2rtI6xXDjTagu8Q7sw+Kdfy+Z804OyHO0L9nsmlgpfwQKoR02uyZ+meFaqdxpzTwstJRoiv81FO2oc8kRE5/1TLdNHmgz5A79HRy14qmm+geOEHgiDfKL1dXNEpErkBw43b8lBhJ2vb85Gf2wSy5dGOObLlI6pLlafoWnr3rUh87FVjdmtxVwJsE23gux0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(102215026);SRVR:CY1PR03MB1487;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;4:9NjhZ430jDaNmbQciaQhq1dj9BFWhO30MlNDqdDe2kGL5ctAY3qLy7avu2RCXpmFvEwIG41FYU80FanImB/jQJuTSeO/WS/J6tgNW6Ve/sm1SgTGGm2HNqEaADmV3GGdlsdP9MKX1i13WNWsp2fWxZIxui9+UHs0upKV56DJVzHvZy3C1WG1rNfHkCGSc24hGeUmCCJEsSZGuR5swCdkADnMAC9wkZw7z+UFqZaOjWUzSSK7gsmvHl+Cd7kOpNl5ChG/xpiuyY4nG6xaDYp3jtCOrRTpk+42/3CQj8YBFKwjz3geZAI/W8y0kb+xXfPNwCzLxybDTE78zNDcsc4oZEOPUVMjNxsXf/XObR+rNMNQTawYd/Su8wJWSaG/7K7D X-Forefront-PRVS: 0738AF4208 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(6049001)(24454002)(199003)(377454003)(54534003)(13464003)(189002)(377424004)(4001150100001)(50226001)(76176999)(101416001)(5008740100001)(50986999)(189998001)(81156007)(97736004)(103116003)(36756003)(5001960100002)(106356001)(4001450100002)(5820100001)(105586002)(5007970100001)(110136002)(5004730100002)(86362001)(5001920100001)(92566002)(66066001)(47776003)(87976001)(2950100001)(50466002)(93886004)(122386002)(42186005)(40100003)(77096005)(33646002)(19580405001)(23676002)(19580395003)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1487;H:[10.214.82.141];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIxNDg3OzIzOlBqYmdXVkhsY1U1NENkbWJscEpVWkJpclZY?= =?utf-8?B?dzFYMW5xUE0yQXBYRE5GQlZsdm1XaWdmVlBXeFF2TmsyK1FYbHd3M0pmajdu?= =?utf-8?B?Ylg0T1hsUEhsd2xuQWhaQnp4N0loVTlOYTY0ZUV3cU9VcEZWYmtUVVNvYlNs?= =?utf-8?B?RDBCSkZjRXY5T1ZoMzMwTE1wVUFEZ1YzZS9PZzJSdnJ6ZC84WFd0TXhuTXNz?= =?utf-8?B?M3NGdkJUNnhYLzNEVUo3WGVBNDFkczNIblBGRDFJOG9qcGwrZGRMbVdaeTJI?= =?utf-8?B?b2g4Wk44SFFpV1ZPVFM2MFNjUjRYY0hQSDVWOW9tNGpPanRjS3RUeW9Ecm9o?= =?utf-8?B?eUFVSjFQMTNuZ3BCOVRad0Y1VitwZ1J2eXhxdERiRU1WUUpZRUpkN3NrTnJp?= =?utf-8?B?aG5UdTZLOEthUDQzcUpRZUFTd2JJREVkZ2w4V1JOZ1dBRk5aMTNtdzh6UVVU?= =?utf-8?B?WVl6aWI0SXp5Z2tzR3l6Q2tpdmFOOFF5RzE2eFd2YWxmb0ZPbG5tNWZka0lh?= =?utf-8?B?TnIzUFFPK0lqa3o0UFNvWUVqcWJHcTd4d25nQUVEQkpqV3FFbWpERE0wN2hJ?= =?utf-8?B?ZkhaRExvMjM0enJBbG1LYzF3TFZ1TVk5WEVNRFhHUXV2RGlaTC90NXU2eEk5?= =?utf-8?B?cTA0enpJQnBqN1REYW5QN0VxR3l3NCt4c24xMGtWZHZyOUx1LzdVemcvQkRW?= =?utf-8?B?c0dSVHVEWU01UDRvT0xwWklLR2xSYkZMcnozb0k2V2JxeGlWdTRKQ3VQTVJY?= =?utf-8?B?MkpQRVhWYW1GcFIvWDNMaE5XMW9IbDg0L1lvbjZMK0hNc2V5Si9ScEF3anYw?= =?utf-8?B?aXdpTHhzYk1wMXBxclBuUDI5ektMRWtsdjlaR3VCb016K0NON0x1emVZR0dW?= =?utf-8?B?UDRtQmMrT2h3NjZ0cEMvL1VyWG9tNHk4UjV2ekh4czF3Z3FZUUhnaWsxM1hL?= =?utf-8?B?Q1Q4ZUlHV3RUQmNpYjViL0d5TmlYWHhQN2RWODJmOVp4akVOSGZXT1FsSFJj?= =?utf-8?B?MThrVDNEMlRqbXJEY2tIWFJnQVF4Qm9zN3kySS94VWRnbkJQaDlRKzFoZVFl?= =?utf-8?B?TGlDbWlJck9sS2pnNVJpK3hmZzQ1K1haTnJYVlJoM2NHdEZhbndtUnRBNG1n?= =?utf-8?B?WmxqSzI5MHBCdldwVE1TY0FRcUs0WmZGMVN3Sjk4MXBXZG1yc3RvVnhtZy9y?= =?utf-8?B?a25udHY1K0k2UG1iZ0x6a3JvQWpscnJaZU9pRFRGNzhsZTNMa1lBSDBZcXo4?= =?utf-8?B?OWxTcnMvMUhnMEhlUm8rK2xzZndyR21UaFVPYUQvNU1yYjc4U2ROTTBWTXNl?= =?utf-8?B?aVBCbWN5S2N6cXg2NmRGUC9aRXdyUS9lTWFCSEk1bDVVdHNLdWhMRHg0YVhz?= =?utf-8?B?T0FycUEzRGtzRjFRbkpvT1hMRzVVTXI2UmF4WThLYWdvRzY4NU9UbW1pb21m?= =?utf-8?B?THN3ekp4dUd1cURCTk1sK3RDNGdEZ1FjbFdFbVBiN01rUmVpdER5dHhzc1p6?= =?utf-8?B?bXJmVklDSVptNXY3dUZFWndOYytPbitnY2lWQjlZd0JXOVBicVdoWnpCU1gv?= =?utf-8?B?SXBWSE11dzduZmJRTUdlZmIwMitQKzB4SWJ1UFRzNU42RkVBODFlQ0hCdU1m?= =?utf-8?B?OHNiZVlkZ2NJd2pKSm9vdlpmVStPQ2RBS3BvTy9peHJGWE96c2JadnFObGhk?= =?utf-8?Q?gEy40DSCmoG/fgVQRc=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;5:oUv/X/dNd4iWH7aBinXVa4lCYblXd1ZNym7oJcPWOwFPjFEsJag9EUXZNfvmwgJFmc3F+jUMTU/kWYC2Nd3Js4MHXfFMwP4DH0c8jisC5AyCjpQS8pIoXTSex8cd0xklNJp78oJMi2Z1657uMkW5Tw==;24:7eUDGXNVLlUGhkfEfX/sunxeLoIINZFp0L3UzY0xt8T+aBqYIIlztv3++vP+FuC/Ky0JkY3cREINjSAOoOahwVoUsxKK9tteK64P2ZQjzlg=;20:y4OEncK/ZNcLxy6g6QJLt63YeqXc14JrUV0QVohn1zO5i5PS227i0z3ovC3KcwZRrFzsEzg6pFYjI8yHbPI8+Q== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2015 20:56:37.8384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1487 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-10-23 at 02:45 -0500, Zhao Qiang-B45475 wrote: > On Fri, 2015-10-23 at 11:10 AM, Wood Scott-B07421 > wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Friday, October 23, 2015 11:10 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > > paulus@samba.org > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to > > qe_common > > > > On Wed, 2015-10-14 at 15:16 +0800, Zhao Qiang wrote: > > > QE and CPM have the same muram, they use the same management > > > functions. Now QE support both ARM and PowerPC, it is necessary to > > > move QE to "driver/soc", so move the muram management functions from > > > cpm_common to qe_common for preparing to move QE code to "driver/soc" > > > > > > Signed-off-by: Zhao Qiang > > > --- > > > Changes for v2: > > > - no changes > > > Changes for v3: > > > - no changes > > > Changes for v4: > > > - no changes > > > Changes for v5: > > > - no changes > > > Changes for v6: > > > - using genalloc instead rheap to manage QE MURAM > > > - remove qe_reset from platform file, using > > > - subsys_initcall to call qe_init function. > > > Changes for v7: > > > - move this patch from 3/3 to 2/3 > > > - convert cpm with genalloc > > > - check for gen_pool allocation failure Changes for v8: > > > - rebase > > > - move BD_SC_* macro instead of copy Changes for v9: > > > - doesn't modify CPM, add a new patch to modify. > > > - rebase > > > Changes for v10: > > > - rebase > > > Changes for v11: > > > - remove renaming > > > - delete removing qe_reset and delete adding qe_init. > > > Changes for v12: > > > - SPI_FSL_CPM depends on QE-MURAM, select QUICC_ENGINE for it. > > > > Why is the SPI change part of this patch? Why is it even part of this > > patchset, > > rather than an independent patch sent to the SPI list and maintainer? If > > it's tied > > to other changes you're making, explain that. As is, there is zero > > mention of > > the SPI change in the part of the e-mail that will become the git > > changelog. > > > This SPI_FSL_CPM is cpm-spi, it is part of CPM. So then why are you selecting QUICC_ENGINE? And again, what does it have to do with this patch? -Scott