From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
James Bottomley <JBottomley@Odin.com>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] lib/string_helpers: fix precision issues and introduce tests
Date: Mon, 26 Oct 2015 14:55:17 +0100 [thread overview]
Message-ID: <1445867720-25473-1-git-send-email-vkuznets@redhat.com> (raw)
Linux always lies about your storage size when it has 4k sectors and its size
is big enough. E.g. a device with 8192 4k sectors will be reported as
"32.7 MB/32 MiB" while "33.5 MB/32 MiB" is expected. This series is supposed
to fix the issue by fixing calculation precision in string_get_size() for all
possible inputs.
PATCH 1/3 is a preparatory change, PATCH 2/3 re-factors string_get_size() fixing
the issue, PATCH 3/3 introduces tests for string_get_size().
PATCH 3/3 was previously sent as part of "lib/string_helpers.c: fix infinite
loop in string_get_size()" series but afaics wasn't merged. In this submission
I add additional tests to it.
Vitaly Kuznetsov (3):
lib/string_helpers: change blk_size to u32 for string_get_size()
interface
lib/string_helpers.c: don't lose precision in string_get_size()
lib/test-string_helpers.c: add string_get_size() tests
include/linux/string_helpers.h | 2 +-
lib/string_helpers.c | 48 +++++++++++++++++++++++-------------------
lib/test-string_helpers.c | 44 ++++++++++++++++++++++++++++++++++++++
3 files changed, 71 insertions(+), 23 deletions(-)
--
2.4.3
next reply other threads:[~2015-10-26 13:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 13:55 Vitaly Kuznetsov [this message]
2015-10-26 13:55 ` [PATCH 1/3] lib/string_helpers: change blk_size to u32 for string_get_size() interface Vitaly Kuznetsov
2015-10-26 13:55 ` [PATCH 2/3] lib/string_helpers.c: don't lose precision in string_get_size() Vitaly Kuznetsov
2015-10-26 16:08 ` Andy Shevchenko
2015-10-27 8:36 ` Vitaly Kuznetsov
2015-10-27 9:34 ` Andy Shevchenko
2015-10-26 21:48 ` Rasmus Villemoes
2015-10-27 8:45 ` Vitaly Kuznetsov
2015-10-26 13:55 ` [PATCH 3/3] lib/test-string_helpers.c: add string_get_size() tests Vitaly Kuznetsov
2015-10-26 15:13 ` Andy Shevchenko
2015-10-26 15:18 ` Vitaly Kuznetsov
2015-10-26 15:21 ` Andy Shevchenko
2015-10-26 15:50 ` Vitaly Kuznetsov
2015-10-26 21:54 ` Rasmus Villemoes
2015-10-27 8:56 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445867720-25473-1-git-send-email-vkuznets@redhat.com \
--to=vkuznets@redhat.com \
--cc=JBottomley@Odin.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome