From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbbJZRBU (ORCPT ); Mon, 26 Oct 2015 13:01:20 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:35466 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbbJZRBS (ORCPT ); Mon, 26 Oct 2015 13:01:18 -0400 From: Fida Mohammad To: Bryan Wu , Richard Purdie , Jacek Anaszewski , linux-leds@vger.kernel.org, LKML Cc: Muhammad Falak , Kristoffer , Fida Mohammad Subject: [PATCH] leds: leds-hp6xx: Use of devm_classdev_register Date: Mon, 26 Oct 2015 10:00:28 -0700 Message-Id: <1445878828-32514-1-git-send-email-fmthoker@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use resource managed function devm_classdev_register to make error path simpler. Also removed the redundant remove function. Signed-off-by: Fida Mohammad --- drivers/leds/leds-hp6xx.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/leds/leds-hp6xx.c b/drivers/leds/leds-hp6xx.c index 0b84c01..ffb6d5b 100644 --- a/drivers/leds/leds-hp6xx.c +++ b/drivers/leds/leds-hp6xx.c @@ -59,28 +59,17 @@ static int hp6xxled_probe(struct platform_device *pdev) { int ret; - ret = led_classdev_register(&pdev->dev, &hp6xx_red_led); + ret = devm_led_classdev_register(&pdev->dev, &hp6xx_red_led); if (ret < 0) return ret; - ret = led_classdev_register(&pdev->dev, &hp6xx_green_led); - if (ret < 0) - led_classdev_unregister(&hp6xx_red_led); + return devm_led_classdev_register(&pdev->dev, &hp6xx_green_led); - return ret; } -static int hp6xxled_remove(struct platform_device *pdev) -{ - led_classdev_unregister(&hp6xx_red_led); - led_classdev_unregister(&hp6xx_green_led); - - return 0; -} static struct platform_driver hp6xxled_driver = { .probe = hp6xxled_probe, - .remove = hp6xxled_remove, .driver = { .name = "hp6xx-led", }, -- 1.9.1