From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932603AbbJ0On4 (ORCPT ); Tue, 27 Oct 2015 10:43:56 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33140 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964819AbbJ0OnZ (ORCPT ); Tue, 27 Oct 2015 10:43:25 -0400 From: Sudip Mukherjee To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 11/11] parport: avoid assignment in if Date: Tue, 27 Oct 2015 20:12:37 +0530 Message-Id: <1445956957-13607-12-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1445956957-13607-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1445956957-13607-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sudip Mukherjee It is not an usual practise to assign some value to a variable in the if test condition. Signed-off-by: Sudip Mukherjee --- drivers/parport/share.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/parport/share.c b/drivers/parport/share.c index b68f194..3308427 100644 --- a/drivers/parport/share.c +++ b/drivers/parport/share.c @@ -1120,7 +1120,8 @@ int parport_claim(struct pardevice *dev) /* Preempt any current device */ write_lock_irqsave(&port->cad_lock, flags); - if ((oldcad = port->cad) != NULL) { + oldcad = port->cad; + if (oldcad) { if (oldcad->preempt) { if (oldcad->preempt(oldcad->private)) goto blocked; -- 1.9.1