From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965122AbbJ0TAr (ORCPT ); Tue, 27 Oct 2015 15:00:47 -0400 Received: from smtprelay0068.hostedemail.com ([216.40.44.68]:39950 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964950AbbJ0TAq (ORCPT ); Tue, 27 Oct 2015 15:00:46 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2896:3138:3139:3140:3141:3142:3350:3622:3865:3868:4321:5007:6261:10004:10400:10848:11026:11473:11658:11914:12043:12296:12438:12517:12519:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: pain74_40974a446394e X-Filterd-Recvd-Size: 1647 Message-ID: <1445972443.2757.34.camel@perches.com> Subject: Re: [PATCH] kernel: power: replacing printk From: Joe Perches To: Saurabh Sengar Cc: rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 27 Oct 2015 12:00:43 -0700 In-Reply-To: <1445919397-6807-1-git-send-email-saurabh.truth@gmail.com> References: <1445919397-6807-1-git-send-email-saurabh.truth@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-10-27 at 09:46 +0530, Saurabh Sengar wrote: > replacing prink(s) with appropriate pr_info and pr_err [] > diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c [] > @@ -486,9 +486,9 @@ static int enter_state(suspend_state_t state) > > #ifndef CONFIG_SUSPEND_SKIP_SYNC > trace_suspend_resume(TPS("sync_filesystems"), 0, true); > - printk(KERN_INFO "PM: Syncing filesystems ... "); > + pr_info("PM: Syncing filesystems ... "); > sys_sync(); > - printk("done.\n"); > + pr_info("done.\n"); > trace_suspend_resume(TPS("sync_filesystems"), 0, false); > #endif > This isn't the same output. The original code emits on a single line. This new code emits on two lines, the second line without a "PM: " prefix.