From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754454AbbJ0TcW (ORCPT ); Tue, 27 Oct 2015 15:32:22 -0400 Received: from smtprelay0073.hostedemail.com ([216.40.44.73]:48971 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751957AbbJ0TcV (ORCPT ); Tue, 27 Oct 2015 15:32:21 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3743:3865:3866:3871:3873:3874:4250:4321:4605:5007:6261:7903:8603:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12740:13069:13095:13311:13357:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: bead43_3154b23e85854 X-Filterd-Recvd-Size: 2223 Message-ID: <1445974338.2757.44.camel@perches.com> Subject: Re: [PATCH 2/3] megaraid_sas: Convert printk to printk_ From: Joe Perches To: Weidong Wang Cc: kashyap.desai@avagotech.com, sumit.saxena@avagotech.com, uday.lingala@avagotech.com, JBottomley@odin.com, megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 27 Oct 2015 12:32:18 -0700 In-Reply-To: <1445934375-17784-3-git-send-email-wangweidong1@huawei.com> References: <1445934375-17784-1-git-send-email-wangweidong1@huawei.com> <1445934375-17784-3-git-send-email-wangweidong1@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-10-27 at 16:26 +0800, Weidong Wang wrote: > Reduce object size a little by using pr_ > calls instead of printk(KERN_. pr_debug does not behave the same as printk(KERN_DEBUG pr_debug is only active when DEBUG is #defined or dynamic_debug is enabled. printk(KERN_DEBUG is always emitted as long as the debug level is enabled for the console. At a minimum, your commit message should show you know that. > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c [] > @@ -5889,7 +5889,7 @@ static int megasas_mgmt_fasync(int fd, struct file *filep, int mode) > return 0; > } > > - printk(KERN_DEBUG "megasas: fasync_helper failed [%d]\n", rc); > + pr_debug("megasas: fasync_helper failed [%d]\n", rc); [] > @@ -6233,7 +6233,7 @@ static int megasas_mgmt_ioctl_aen(struct file *file, unsigned long arg) > u32 wait_time = MEGASAS_RESET_WAIT_TIME; > > if (file->private_data != file) { > - printk(KERN_DEBUG "megasas: fasync_helper was not " > + pr_debug("megasas: fasync_helper was not " > "called first\n"); Please also coalesce format strings where possible.