From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965279AbbJ0Tyh (ORCPT ); Tue, 27 Oct 2015 15:54:37 -0400 Received: from smtprelay0068.hostedemail.com ([216.40.44.68]:51221 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965138AbbJ0Tyg (ORCPT ); Tue, 27 Oct 2015 15:54:36 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:966:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2551:2553:2559:2562:2828:2909:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4385:5007:6261:8660:9036:10004:10400:10471:10848:11026:11232:11658:11914:12050:12296:12517:12519:12679:12740:13019:13069:13095:13148:13230:13255:13311:13357:14096:14097:21080:21094,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: pen00_620747ed48518 X-Filterd-Recvd-Size: 3188 Message-ID: <1445975672.2757.51.camel@perches.com> Subject: Re: [PATCH 2/2] Fixed Trivial Warnings in file: Deleted Spaces prior to tabs, and added lines. modified: kernel/auditfilter.c From: Joe Perches To: Richard Guy Briggs Cc: Scott Matheina , Paul Moore , linux-audit@redhat.com, trivial@kernel.org, linux-kernel@vger.kernel.org Date: Tue, 27 Oct 2015 12:54:32 -0700 In-Reply-To: <20151022021500.GD5269@madcap2.tricolour.ca> References: <1444528675-13184-1-git-send-email-scott@matheina.com> <10476084.rIoW7K08e6@sifl> <5623DBF5.8020500@matheina.com> <20151019161035.GB11501@madcap2.tricolour.ca> <1445435918.9220.9.camel@perches.com> <20151021153339.GA5269@madcap2.tricolour.ca> <56282E2E.4010207@matheina.com> <20151022021500.GD5269@madcap2.tricolour.ca> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-10-21 at 22:15 -0400, Richard Guy Briggs wrote: > On 15/10/21, Scott Matheina wrote: > > On 10/21/2015 10:33 AM, Richard Guy Briggs wrote: > > > On 15/10/21, Joe Perches wrote: > > >> On Mon, 2015-10-19 at 12:10 -0400, Richard Guy Briggs wrote: > > >>> On 15/10/18, Scott Matheina wrote: > > >>>> On 10/14/2015 04:54 PM, Paul Moore wrote: > > >>>>> On Saturday, October 10, 2015 08:57:55 PM Scott Matheina wrote: > > >> [] > > >>>>>> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c > > >> [] > > >>>>>> @@ -109,6 +109,7 @@ void audit_free_rule_rcu(struct rcu_head *head) > > >>>>>> { > > >>>>>> struct audit_entry *e = container_of(head, struct audit_entry, rcu); > > >>>>>> audit_free_rule(e); > > >>>>>> + > > >>>>>> } > > >>>>> Why? > > >>>> I was following the error messages in checkpatch.pl, but the warning > > >>>> went away after adding this line. No problem with the code. > > >>> That sounds like a bug in checkpatch.pl, since that blank line should be > > >>> tween the declaration and the function call. > > >> checkpatch message asks for a blank line after the > > >> "struct audit_entry *e = ..." declaration. > > > Well then maybe it is a bug in his interpretation of the output of > > > checkpatch.pl? Scott, did you re-run checkpatch.pl after adding those > > > spaces? Did it pass? > > > > The error did go away. > > Joe, I confirm the error went away. Looks like a bug in checkpatch.pl > to me. It's not a bug in checkpatch. checkpatch doesn't care if there are blank lines between declarations. Here's the output of checkpatch for this area: WARNING: Missing a blank line after declarations #111: FILE: kernel/auditfilter.c:111: + struct audit_entry *e = container_of(head, struct audit_entry, rcu); + audit_free_rule(e); That doesn't suggest putting a blank line before line 111. It suggests putting a blank line after the declaration of e.