From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755882AbbJ1Lm2 (ORCPT ); Wed, 28 Oct 2015 07:42:28 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:55417 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755854AbbJ1Lm0 (ORCPT ); Wed, 28 Oct 2015 07:42:26 -0400 Message-ID: <1446032542.12590.33.camel@pengutronix.de> Subject: Re: [PATCH V5 Base on RC7 3/3] Add reset controller for hi6220 SoC platform. From: Philipp Zabel To: Chen Feng Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk Date: Wed, 28 Oct 2015 12:42:22 +0100 In-Reply-To: <1445939498-94147-3-git-send-email-puck.chen@hisilicon.com> References: <1445939498-94147-1-git-send-email-puck.chen@hisilicon.com> <1445939498-94147-3-git-send-email-puck.chen@hisilicon.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 27.10.2015, 17:51 +0800 schrieb Chen Feng: > reset: add driver for hi6220 reset controller > > Signed-off-by: Chen Feng > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index 3f03380..3f055e2 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -167,5 +167,12 @@ > clocks = <&ao_ctrl 36>, <&ao_ctrl 36>; > clock-names = "uartclk", "apb_pclk"; > }; > + > + reset_ctrl: reset_ctrl@f7030000 { > + compatible = "hisilicon,hi6220-reset-ctl"; > + reg = <0x0 0xf7030000 0x0 0x1000>; > + #reset-cells = <1>; > + }; > + While applying I just noticed that the device tree already contains a node claiming the same address space: sys_ctrl: sys_ctrl@f7030000 { compatible = "hisilicon,hi6220-sysctrl", "syscon"; reg = <0x0 0xf7030000 0x0 0x2000>; #clock-cells = <1>; }; It is documented in Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt and Documentation/devicetree/bindings/clock/hi6220-clock.txt. Could you clarify whether the reset controls are just part of the sys_ctrl block? If so, I think you should add #reset-cells = <1> to the sys_ctrl node instead. regards Philipp