From: Joe Perches <joe@perches.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "Lee Jones" <lee.jones@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
k.kozlowski.k@gmail.com, wsa@the-dreams.de,
linus.walleij@linaro.org, "Sebastian Reichel" <sre@kernel.org>,
linux-kernel@vger.kernel.org,
"Chanwoo Choi" <cw00.choi@samsung.com>,
broonie@kernel.org, ben-linux@fluff.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] get_maintainer: Add subsystem to reviewer output
Date: Wed, 28 Oct 2015 09:41:46 -0700 [thread overview]
Message-ID: <1446050506.2757.109.camel@perches.com> (raw)
In-Reply-To: <5630CA06.7050503@samsung.com>
Reviewer output currently does not include the subsystem
that matched. Add it.
Miscellanea:
o Add a get_subsystem_name routine to centralize this
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/get_maintainer.pl | 31 ++++++++++++++++---------------
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 98bae86..d641541 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -970,20 +970,29 @@ sub find_ending_index {
return $index;
}
-sub get_maintainer_role {
+sub get_subsystem_name {
my ($index) = @_;
- my $i;
my $start = find_starting_index($index);
- my $end = find_ending_index($index);
- my $role = "unknown";
my $subsystem = $typevalue[$start];
if ($output_section_maxlen && length($subsystem) > $output_section_maxlen) {
$subsystem = substr($subsystem, 0, $output_section_maxlen - 3);
$subsystem =~ s/\s*$//;
$subsystem = $subsystem . "...";
}
+ return $subsystem;
+}
+
+sub get_maintainer_role {
+ my ($index) = @_;
+
+ my $i;
+ my $start = find_starting_index($index);
+ my $end = find_ending_index($index);
+
+ my $role = "unknown";
+ my $subsystem = get_subsystem_name($index);
for ($i = $start + 1; $i < $end; $i++) {
my $tv = $typevalue[$i];
@@ -1017,16 +1026,7 @@ sub get_maintainer_role {
sub get_list_role {
my ($index) = @_;
- my $i;
- my $start = find_starting_index($index);
- my $end = find_ending_index($index);
-
- my $subsystem = $typevalue[$start];
- if ($output_section_maxlen && length($subsystem) > $output_section_maxlen) {
- $subsystem = substr($subsystem, 0, $output_section_maxlen - 3);
- $subsystem =~ s/\s*$//;
- $subsystem = $subsystem . "...";
- }
+ my $subsystem = get_subsystem_name($index);
if ($subsystem eq "THE REST") {
$subsystem = "";
@@ -1114,7 +1114,8 @@ sub add_categories {
}
}
if ($email_reviewer) {
- push_email_addresses($pvalue, 'reviewer');
+ my $subsystem = get_subsystem_name($i);
+ push_email_addresses($pvalue, "reviewer:$subsystem");
}
} elsif ($ptype eq "T") {
push(@scm, $pvalue);
next prev parent reply other threads:[~2015-10-28 16:41 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 15:42 [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag Lee Jones
2015-10-27 17:24 ` Sebastian Reichel
2015-10-27 18:15 ` Lee Jones
2015-10-27 18:44 ` Joe Perches
2015-10-28 1:46 ` Krzysztof Kozlowski
2015-10-28 8:24 ` Lee Jones
2015-10-28 9:21 ` Javier Martinez Canillas
2015-10-28 9:25 ` Javier Martinez Canillas
2015-10-28 9:31 ` Krzysztof Kozlowski
2015-10-28 10:28 ` Lee Jones
2015-10-28 10:53 ` Javier Martinez Canillas
2015-10-28 11:06 ` Joe Perches
2015-10-28 11:25 ` Javier Martinez Canillas
2015-10-28 11:39 ` Lee Jones
2015-10-28 12:14 ` Lee Jones
2015-10-28 12:20 ` Joe Perches
2015-10-28 12:24 ` Lee Jones
2015-10-28 12:46 ` Joe Perches
2015-10-28 13:06 ` Javier Martinez Canillas
2015-10-28 13:34 ` Lee Jones
2015-10-28 14:09 ` Javier Martinez Canillas
2015-10-28 14:38 ` Lee Jones
2015-10-28 14:54 ` Javier Martinez Canillas
2015-10-28 23:56 ` Krzysztof Kozlowski
2015-10-29 0:12 ` Javier Martinez Canillas
2015-10-30 16:51 ` Lee Jones
2015-10-30 16:51 ` Lee Jones
2015-10-28 9:23 ` Krzysztof Kozlowski
2015-10-28 9:39 ` Uwe Kleine-König
2015-10-28 9:55 ` Lee Jones
2015-10-28 13:13 ` Krzysztof Kozlowski
2015-10-28 16:41 ` Joe Perches [this message]
2015-10-28 17:01 ` [PATCH] get_maintainer: Add subsystem to reviewer output Lee Jones
2015-10-28 17:08 ` Joe Perches
2015-10-28 17:22 ` Lee Jones
2015-10-28 17:30 ` Joe Perches
2015-10-28 17:49 ` Lee Jones
2015-10-28 17:56 ` Joe Perches
2015-10-29 9:20 ` Lee Jones
2015-10-29 14:14 ` Joe Perches
2015-10-29 16:17 ` Lee Jones
2015-10-28 17:18 ` Joe Perches
2015-10-28 23:49 ` Krzysztof Kozlowski
2015-10-28 10:14 ` [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag Lee Jones
2015-10-28 13:27 ` Krzysztof Kozlowski
2015-10-28 13:49 ` Lee Jones
2015-10-28 16:26 ` Bartlomiej Zolnierkiewicz
2015-10-28 16:33 ` Lee Jones
2015-10-28 8:57 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446050506.2757.109.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski.k@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sre@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome