From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756029AbbJ1SX4 (ORCPT ); Wed, 28 Oct 2015 14:23:56 -0400 Received: from smtprelay0093.hostedemail.com ([216.40.44.93]:39737 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754062AbbJ1SXz (ORCPT ); Wed, 28 Oct 2015 14:23:55 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3867:3870:3871:3872:3873:4321:4605:5007:6261:6691:10004:10400:10848:11026:11232:11473:11658:11914:12043:12114:12296:12517:12519:12679:12740:13069:13255:13311:13357:21080:21212,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: seed27_5c10f82b12d40 X-Filterd-Recvd-Size: 1785 Message-ID: <1446056631.2757.143.camel@perches.com> Subject: Re: [PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match open parenthesis From: Joe Perches To: Bogicevic Sasa Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Date: Wed, 28 Oct 2015 11:23:51 -0700 In-Reply-To: <1446056004-6092-1-git-send-email-brutallesale@gmail.com> References: <1446056004-6092-1-git-send-email-brutallesale@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-10-28 at 19:13 +0100, Bogicevic Sasa wrote: > This fixes all Alignment should match open parenthesis > messages from checkpatch.pl What you suggest is not at all generally accepted kernel style. > diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c [] > @@ -161,12 +161,15 @@ static int gdm_lte_emulate_arp(struct sk_buff *skb_in, u32 nic_type) > return -ENOMEM; > skb_reserve(skb_out, NET_IP_ALIGN); > > - memcpy(skb_put(skb_out, mac_header_len), mac_header_data, > + memcpy( > + skb_put(skb_out, mac_header_len), mac_header_data, > mac_header_len); What's desired here is: memcpy(skb_put(skb_out, mac_header_len), mac_header_data, mac_header_len); Second line should be: [tab][7 spaces]mac_header_len); etc... btw: Please run your _patches_ through checkpatch.pl, not just use it to find style issues in files.