From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751487AbbJ2EME (ORCPT ); Thu, 29 Oct 2015 00:12:04 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:34953 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751110AbbJ2EMC (ORCPT ); Thu, 29 Oct 2015 00:12:02 -0400 From: Saurabh Sengar To: paul@paul-moore.com, eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Cc: Saurabh Sengar Subject: [PATCH v2] audit: removing unused variable Date: Thu, 29 Oct 2015 09:41:52 +0530 Message-Id: <1446091912-6001-1-git-send-email-saurabh.truth@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org variable rc is unnecessary hence removing it, also as the return type of function audit_log_common_recv_msg is no where used changing it to void. Signed-off-by: Saurabh Sengar --- kernel/audit.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c index 662c007..b572115 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -684,25 +684,24 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type) return err; } -static int audit_log_common_recv_msg(struct audit_buffer **ab, u16 msg_type) +static void audit_log_common_recv_msg(struct audit_buffer **ab, u16 msg_type) { - int rc = 0; uid_t uid = from_kuid(&init_user_ns, current_uid()); pid_t pid = task_tgid_nr(current); if (!audit_enabled && msg_type != AUDIT_USER_AVC) { *ab = NULL; - return rc; + return ; } *ab = audit_log_start(NULL, GFP_KERNEL, msg_type); if (unlikely(!*ab)) - return rc; + return ; audit_log_format(*ab, "pid=%d uid=%u", pid, uid); audit_log_session_info(*ab); audit_log_task_context(*ab); - return rc; + return ; } int is_audit_feature_set(int i) -- 1.9.1