From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756350AbbJ2Ecy (ORCPT ); Thu, 29 Oct 2015 00:32:54 -0400 Received: from smtprelay0096.hostedemail.com ([216.40.44.96]:50017 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751147AbbJ2Ecv (ORCPT ); Thu, 29 Oct 2015 00:32:51 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3871:3872:3874:4321:5007:6261:7903:10004:10400:10848:11026:11473:11658:11914:12043:12296:12438:12517:12519:12740:13019:13069:13161:13229:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: pan70_18c2469ebe131 X-Filterd-Recvd-Size: 2318 Message-ID: <1446093168.2757.154.camel@perches.com> Subject: Re: [PATCH v2] audit: removing unused variable From: Joe Perches To: Saurabh Sengar Cc: paul@paul-moore.com, eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Date: Wed, 28 Oct 2015 21:32:48 -0700 In-Reply-To: <1446091912-6001-1-git-send-email-saurabh.truth@gmail.com> References: <1446091912-6001-1-git-send-email-saurabh.truth@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-10-29 at 09:41 +0530, Saurabh Sengar wrote: > variable rc is unnecessary hence removing it, > also as the return type of function audit_log_common_recv_msg is no > where used changing it to void. Almost, but not quite. Keep at it. Ideally your first attempts at kernel patching should be done in the drivers/staging/ directory before attempting patches outside of that path. > diff --git a/kernel/audit.c b/kernel/audit.c [] > @@ -684,25 +684,24 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type) > return err; > } > > -static int audit_log_common_recv_msg(struct audit_buffer **ab, u16 msg_type) > +static void audit_log_common_recv_msg(struct audit_buffer **ab, u16 msg_type) > { > - int rc = 0; > uid_t uid = from_kuid(&init_user_ns, current_uid()); > pid_t pid = task_tgid_nr(current); > > if (!audit_enabled && msg_type != AUDIT_USER_AVC) { > *ab = NULL; > - return rc; > + return ; There's an unnecessary space before the semicolon. This should be return; > } > > *ab = audit_log_start(NULL, GFP_KERNEL, msg_type); > if (unlikely(!*ab)) > - return rc; > + return ; here too > audit_log_format(*ab, "pid=%d uid=%u", pid, uid); > audit_log_session_info(*ab); > audit_log_task_context(*ab); > > - return rc; > + return ; No return statement necessary here at all > } > > int is_audit_feature_set(int i)